22 add camera for quick image adding v2 #31
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,63 +1,102 @@ | ||
| # Wally | ||
|
|
||
| **A simple, ad-free Android wallpaper carousel.** | ||
|
|
||
| [](https://github.com/Fector101/wallpaper-carousel/actions/workflows/android-release.yml) | ||
|
|
||
| **[Download APK](https://github.com/Fector101/wallpaper-carousel/releases/download/v1.0.6/waller.apk)** | ||
|
|
||
| --- | ||
|
|
||
| ## Overview | ||
|
|
||
| Wally automatically rotates your wallpapers using images you choose. | ||
|
|
||
| * Change wallpapers every **2 minutes** (or any custom interval) | ||
| * Option to update wallpapers on **screen wake** | ||
| * Fully **offline** and **ad-free** | ||
|
|
||
| --- | ||
|
|
||
| ## Features | ||
|
|
||
| ### Wallpaper Carousel | ||
|
|
||
| * Automatically cycles through selected images | ||
| * Custom time intervals | ||
| * Optional change on screen wake | ||
|
|
||
| ### Home Screen Widget | ||
|
|
||
| * View current lock-screen wallpaper from your home screen | ||
| * Tap the widget to quickly open the app | ||
|
|
||
| ### Notification Controls | ||
|
|
||
| * Preview the next wallpaper (large icon) | ||
| * Skip to the next image | ||
| * Stop the carousel anytime | ||
|
|
||
| ### Image Import & Sharing | ||
|
|
||
| * Share images directly to Wally from other apps | ||
| * Easily share images from Wally to other apps | ||
|
|
||
| --- | ||
|
|
||
| ## Permissions | ||
|
|
||
| * Images only — no unnecessary access | ||
| * Notifications — for controls and previews | ||
|
Comment on lines
+47
to
+50
There was a problem hiding this comment. 🔒 Security & Privacy | 🟡 Minor | ⚡ Quick win Document the camera permission. This PR adds native camera capture, but the permissions section lists only Images and Notifications. Add camera access and state that it is requested only when the user takes a photo. 🤖 Prompt for AI Agents |
||
|
|
||
| --- | ||
|
|
||
| ## Help & Notes | ||
|
|
||
| * Images are stored inside the app’s internal directory | ||
| * Use the Export feature before uninstalling to keep your images | ||
| * Automatically adapts to system theme (dark mode recommended) | ||
|
|
||
| --- | ||
|
|
||
| ## Screenshots | ||
|
|
||
| *All screenshots are low resolution for faster loading* | ||
|
|
||
| ### Main Screens | ||
|
|
||
| | View Screen | Home Screen Widget | | ||
| | ---------------------------------------------------------------- | -------------------------------------------------------- | | ||
| |  |  | | ||
|
|
||
| --- | ||
|
|
||
| ### Gallery & Preview | ||
|
|
||
| | Gallery Screen | Preview Screen | | ||
| | ------------------------------------------------------ | --------------------------------------------------- | | ||
| |  |  | | ||
|
|
||
| --- | ||
|
|
||
| ### Request Screens | ||
|
|
||
| | Light Mode | Dark Mode | | ||
| | ------------------------------------------------------ | ---------------------------------------------------------- | | ||
| |  |  | | ||
|
|
||
| --- | ||
|
|
||
| ### Share Feature | ||
|
|
||
|  | ||
|
|
||
| --- | ||
|
|
||
| ## Why Wally? | ||
|
|
||
| * No ads | ||
| * No tracking | ||
| * Clean, focused wallpaper experience | ||
|
|
||
| --- | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -114,6 +114,11 @@ def after_apk_build(toolchain: ToolchainCL): | |
| </activity> | ||
| """ | ||
| manifest_file_content = manifest_file_content.replace("</activity>", f"{image_share_from_other_apps_to_app_activity}") | ||
| manifest_file_content = insert_to_end_of_xml(f""" | ||
| <activity | ||
| android:name="{package}.CameraActivity" | ||
| android:exported="false" | ||
| android:screenOrientation="fullSensor" />""",manifest_file_content) | ||
|
|
||
| android_manifest_file_path.write_text(manifest_file_content, encoding="utf-8") | ||
| print("Successfully: Updated Manifest!\n",manifest_file_content) | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Fail the job when no APK is produced.
steps.build.outputs.apkis empty iffind ./bin -name "*-debug.apk"matches nothing.actions/upload-artifact@v4then only warns, so the workflow reports success with no artifact. Setif-no-files-found: errorto surface the failure.🛠️ Proposed fix
- name: Upload artifacts uses: actions/upload-artifact@v4 with: name: package path: ${{ steps.build.outputs.apk }} + if-no-files-found: error📝 Committable suggestion
🤖 Prompt for AI Agents