Add Enum to Schema generation - #20
Open
stevebell117 wants to merge 6 commits into
Open
Conversation
Author
|
The flake8 error that's being thrown doesn't make sense to me, but I'll continue looking in this more over the next few days. |
Author
|
Update: The output now looks like: Handles if no default is specified in the schema, and also includes a No default: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, noticed that the
enumlogic was setup but not fully implemented so I went ahead and implemented it. I'm not super familiar with this repository, so I don't know how to fully test this but it worked well with the file I used against it (which I can attach, it's a bit large), but here's an example of the output I am now receiving after implementing it.generates (See latest comment)
I am concerned about backwards compatibility, as those who have used this library previously may not be able to handle the conversion from
strtoEnum(since they'd need to do.value. Would you recommend adding a argument to explicitly enable this behavior?Addresses #19