fix(index): add guard for short files in magic number check#598
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the RTF “magic number” detection in UnRTF.convert() to safely handle inputs shorter than the expected header length, and switches the header buffer allocation to an unsafe variant for a minor performance win while preserving correctness.
Changes:
- Add a
bytesReadguard so files shorter thanRTF_MAGIC_NUMBER_LENGTHcan’t be misclassified. - Switch from
Buffer.alloctoBuffer.allocUnsafefor the magic-number read buffer.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fileHandle.read()may return fewer bytes than requested for files smaller than 6 bytes. Without checkingbytesRead, the comparison against the RTF magic number{\rtf1could produce a false positive on truncated input.Also switches to
Buffer.allocUnsafeas all bytes are immediately overwritten by the read, so the filling of all zeroes inBuffer.allocwas wasted. Teeny tiny micro-optimisation that saves ~2.84µs per call. All adds up when converting millions of files though!Checklist