Skip to content

fix(index): hide spawned unrtf console window on windows#597

Merged
Fdawgs merged 1 commit into
mainfrom
fix/windows-splash
Jul 5, 2026
Merged

fix(index): hide spawned unrtf console window on windows#597
Fdawgs merged 1 commit into
mainfrom
fix/windows-splash

Conversation

@Fdawgs

@Fdawgs Fdawgs commented Jul 4, 2026

Copy link
Copy Markdown
Owner

On Windows, spawn may briefly flash a console window for the child process.
Teeny tiny performance boost on Windows OS as the window isn't visible/created.

Checklist

Copilot AI review requested due to automatic review settings July 4, 2026 18:36

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the UnRTF wrapper to prevent a spawned unrtf child process from flashing a console window on Windows by using Node’s windowsHide spawn option.

Changes:

  • Add windowsHide: true to the spawnSync() call that locates unrtf via where/which.
  • Add windowsHide: true to the spawnSync() call that reads unrtf --version.
  • Add windowsHide: true to the spawn() call used by convert().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/index.js
@Fdawgs Fdawgs merged commit 344d9e9 into main Jul 5, 2026
21 checks passed
@Fdawgs Fdawgs deleted the fix/windows-splash branch July 5, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants