Skip to content

Let left-click canvas panning work #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
r4stered wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Let left-click canvas panning work #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions include/ImNodeFlow.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,6 +453,12 @@ namespace ImFlow
*/
[[nodiscard]] bool isNodeDragged() const { return m_draggingNode; }

/**
* @brief <BR>Get link drag-out status
* @return [TRUE] if the user is currently dragging a new link out of a pin
*/
[[nodiscard]] bool isLinkDragging() const { return m_dragOut != nullptr; }

/**
* @brief <BR>Get current style
* @return Reference to style variables
Expand Down
26 changes: 24 additions & 2 deletions src/context_wrapper.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,12 @@ struct ContainedContextConfig
float default_zoom = 1.f;
ImGuiKey reset_zoom_key = ImGuiKey_R;
ImGuiMouseButton scroll_button = ImGuiMouseButton_Middle;
// Per-frame veto on canvas panning, set by the host before end(). Useful
// when scroll_button is remapped to Left, where panning has to share the
// button with node dragging, link drag-out and selection: the host can set
// this from ImNodeFlow::isNodeDragged() / isLinkDragging() / "anything
// selected" so those gestures win over the pan.
bool block_scroll = false;
};

class ContainedContext
Expand Down Expand Up @@ -291,7 +297,23 @@ inline void ContainedContext::end()
if (m_config.extra_window_wrapper && ImGui::IsWindowHovered())
m_anyWindowHovered = false;

m_anyItemActive = ImGui::IsAnyItemActive();
// Not simply IsAnyItemActive(): clicking empty space in a window makes
// ImGui set ActiveId to that window's MoveId, and it does so even for
// windows flagged ImGuiWindowFlags_NoMove -- see the comment in
// StartMouseMovingWindow(), the id is kept alive purely so that dragging
// away from the window does not light up hover on other windows. Our
// viewport container is NoMove, so a plain IsAnyItemActive() reports "an
// item is active" for the whole duration of any left-press on empty
// canvas. That is harmless for the default middle-button pan, but it
// silently kills panning whenever scroll_button is remapped to Left.
// Treat a bare MoveId as "nothing active" so left-drag can pan, while a
// genuinely held widget (button, slider, drag-float in a node) still
// blocks it.
{
ImGuiContext& g = *ImGui::GetCurrentContext();
m_anyItemActive = g.ActiveId != 0 &&
!(g.ActiveIdWindow && g.ActiveIdWindow->MoveId == g.ActiveId);
}

if (m_config.extra_window_wrapper)
ImGui::End();
Expand Down Expand Up @@ -354,7 +376,7 @@ inline void ContainedContext::end()
m_scaleTarget = m_config.default_zoom;

// Scrolling
if (m_hovered && !m_anyItemActive && ImGui::IsMouseDragging(m_config.scroll_button, 0.f))
if (!m_config.block_scroll && m_hovered && !m_anyItemActive && ImGui::IsMouseDragging(m_config.scroll_button, 0.f))
{
m_scroll += ImGui::GetIO().MouseDelta / m_scale;
}
Expand Down