Skip to content

PR - removing reliance on RTTI #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lpastrana-phaseview wants to merge 1 commit into
base: master
Choose a base branch
from
Open

PR - removing reliance on RTTI #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions include/ImNodeFlow.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#ifndef IM_NODE_FLOW
#define IM_NODE_FLOW
#include <type_traits>
#pragma once

#include <iostream>
Expand Down Expand Up @@ -1088,9 +1089,9 @@ namespace ImFlow
class ConnectionFilter
{
public:
static std::function<bool(Pin*, Pin*)> None() { return [](Pin* out, Pin* in){ return true; }; }
static std::function<bool(Pin*, Pin*)> SameType() { return [](Pin* out, Pin* in) { return out->getDataType() == in->getDataType(); }; }
static std::function<bool(Pin*, Pin*)> Numbers() { return [](Pin* out, Pin* in){ return out->getDataType() == typeid(double) || out->getDataType() == typeid(float) || out->getDataType() == typeid(int); }; }
static auto None() { return [](auto*, auto*){ return true; }; }
static auto SameType() { return [](auto* out, auto* in) { return std::is_same_v<decltype(out->val()),decltype(in->val())>; }; }
static auto Numbers() { return [](auto* out, auto*){ return std::is_arithmetic_v<decltype(out->val())>; }; }
};

/**
Expand Down Expand Up @@ -1152,7 +1153,7 @@ namespace ImFlow
* @brief <BR>Get pin's data type (aka: \<T>)
* @return String containing unique information identifying the data type
*/
[[nodiscard]] const std::type_info& getDataType() const override { return typeid(T); };
// [[nodiscard]] const std::type_info& getDataType() const override { return typeid(T); };

/**
* @brief <BR>Get pin's link attachment point (socket)
Expand Down Expand Up @@ -1245,7 +1246,7 @@ namespace ImFlow
* @brief <BR>Get pin's data type (aka: \<T>)
* @return String containing unique information identifying the data type
*/
[[nodiscard]] const std::type_info& getDataType() const override { return typeid(T); };
// [[nodiscard]] const std::type_info& getDataType() const override { return typeid(T); };
private:
std::vector<std::weak_ptr<Link>> m_links;
std::function<T()> m_behaviour;
Expand Down