Potential fix for code scanning alert no. 7: Clear-text storage of sensitive information - #255
Open
jkterry1 wants to merge 1 commit into
Open
Potential fix for code scanning alert no. 7: Clear-text storage of sensitive information#255jkterry1 wants to merge 1 commit into
jkterry1 wants to merge 1 commit into
Conversation
…nsitive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
jkterry1
marked this pull request as ready for review
August 2, 2026 18:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Farama-Foundation/Stable-Retro/security/code-scanning/7
Best fix: avoid storing the API token in
crowdin.yamlentirely. Instead, keepcrowdin.yamltoken placeholder unchanged and pass the token securely at runtime via an environment variable tosubprocess.run. Crowdin CLI supportsCROWDIN_PERSONAL_TOKEN, so we can inject it into the subprocess environment (env=...) and remove all token write/reset logic. This preserves functionality (CLI still authenticates) while eliminating clear-text persistence.In
cores/flycast/intl/initial_sync.py:/_core_name_replacement), since that is not secret.crowdin_env = os.environ.copy(); crowdin_env['CROWDIN_PERSONAL_TOKEN'] = API_KEY.env=crowdin_envto both CLIsubprocess.runcalls.API_KEY = None) to reduce lingering secret lifetime.No new imports or dependencies required.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.