Fix incorrect boundary check in CVE-2020-0499 patch for FLAC bitreader - #205
Closed
MatPoliquin with Copilot wants to merge 2 commits into
Closed
Fix incorrect boundary check in CVE-2020-0499 patch for FLAC bitreader#205MatPoliquin with Copilot wants to merge 2 commits into
MatPoliquin with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: MatPoliquin <7024551+MatPoliquin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Review PR for potential bugs
Fix incorrect boundary check in CVE-2020-0499 patch for FLAC bitreader
Jan 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #179 attempts to fix CVE-2020-0499 in FLAC's bitreader but uses
br->capacity(allocated buffer size) instead ofbr->words(actual valid data). This still allows reading uninitialized memory between valid data and buffer end.Changes
capacitytowordscapacitytowordsThe
wordsvariable is set tobr->wordstwo lines above and represents completed words in buffer. This matches the boundary check pattern used elsewhere in the same function (line 866) and the original xiph/flac security fix.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.