Add historical/fantasy units (issue #3) - #8
Open
Arararararagi wants to merge 1 commit into
Open
Arararararagi wants to merge 1 commit into
Arararararagi wants to merge 1 commit into
Conversation
Adds span, rod, pole, perch, chain, ell, hand and pace (cubit/league/ furlong/stone already existed). Approximate English-standard values. False-positive defense: the short homographs (span/rod/pole/ell/hand/pace) and the 5-letter perch (fish) / chain (common noun) are gated by a new FootFree._GATED_UNITS / _GATED_LONG pair: they only convert when the book shows >=2 distinct gated units AND the number is written as digits, so 'life span', 'fishing rod', 'two hands of cards', 'keep pace', 'a chain of events' and 'caught two perch' never convert, while '3 ell and 5 span' and '15 hands and 4 chain' convert normally. Plural forms normalize to one gate key. Length help text updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds span, rod, pole, perch, chain, ell, hand and pace (cubit/league/ furlong/stone already existed). Approximate English-standard values.
False-positive defense: the short homographs (span/rod/pole/ell/hand/pace) and the 5-letter perch (fish) / chain (common noun) are gated by a new FootFree._GATED_UNITS / _GATED_LONG pair: they only convert when the book shows >=2 distinct gated units AND the number is written as digits, so 'life span', 'fishing rod', 'two hands of cards', 'keep pace', 'a chain of events' and 'caught two perch' never convert, while '3 ell and 5 span' and '15 hands and 4 chain' convert normally. Plural forms normalize to one gate key. Length help text updated.
Also, semi-related, TIL people outside Portugal also measure stuff in hands. In retrospect, it's a bit obvious, but I've never seen it before, I think. e.g. the tv show "Six Feet Under" is called "Seven Hands/Palms of Dirt" (A Sete Palmos in BR/Sete Palmos de Terra in PT) in Portuguese.