Skip to content

Clean: Update glossiness API, to be able to have a default specular color if none provided#279

Open
FarhadG wants to merge 3 commits into
Famous:developfrom
FarhadG:specular
Open

Clean: Update glossiness API, to be able to have a default specular color if none provided#279
FarhadG wants to merge 3 commits into
Famous:developfrom
FarhadG:specular

Conversation

@FarhadG

@FarhadG FarhadG commented Jun 12, 2015

Copy link
Copy Markdown
Contributor

A more intuitive glossiness API, along with a default specular color if none was provided (based off the light color).

@FarhadG

FarhadG commented Jun 12, 2015

Copy link
Copy Markdown
Contributor Author

Just FYI, this will break the old API, as the previous one required that you pass in a Color as the first argument (if not a material express) with a strength. Now, on the other hand, you pass in strength as the first argument and an optional Color for the second argument.

I will push up a demo for this, very soon.

@FarhadG

FarhadG commented Jun 15, 2015

Copy link
Copy Markdown
Contributor Author

All updates have been made and here's a DEMO showcasing the updates.

@michaelobriena

@michaelobriena

Copy link
Copy Markdown
Member

@FarhadG Can you update the commits so that the second commit is marked as a breaking change?

Thanks.

@FarhadG

FarhadG commented Jul 8, 2015

Copy link
Copy Markdown
Contributor Author

Updated to breaking commit.

@michaelobriena

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants