chore(rebrand): regenerate tool wrappers + fix GenerateTools target + update CI header#67
Merged
Merged
Conversation
Closes #39. ## Changes ### CI config generator - src/Fallout.Build/CICD/ConfigurationAttributeBase.cs: generated YAML/ Kotlin header comment now reads "fallout --generate-configuration ..." instead of "nuke --generate-configuration ...". - .github/workflows/{ubuntu,windows,macos}-latest.yml: refreshed headers to match. Tests under tests/Fallout.Common.Tests/CI/*.verified.txt re-baselined alongside (6 snapshots, one header line each). ### Tool wrappers - build/Build.CodeGeneration.cs: SpecificationsDirectory was pointing at the pre-#54 `source/` directory; GlobFiles returned empty and the GenerateTools target silently no-op'd. Fixed to `src/`. - 62 Generated.cs files regenerated via `GenerateTools`. Picks up the WriterExtensions.cs URL update made earlier in the rebrand — every `<remarks>` block now links to github.com/ChrisonSimtian/Fallout instead of the dead `https://www.nuke.build/docs/...` URL. Also picks up the GitHub source-file URL change from `nuke-build/nuke` paths to `ChrisonSimtian/Fallout`. - .fallout/build.schema.json: regenerated as a side-effect. ## Verification - dotnet build fallout.slnx -c Debug: 0 errors, 11 pre-existing warnings - dotnet test fallout.slnx: 391 passed, 7 skipped, 0 failed - Spot check: src/Fallout.Common/Tools/Boots/Boots.Generated.cs no longer contains "nuke.build"; remarks link now points at github.com/ChrisonSimtian/Fallout Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
PR #67 didn't trigger ubuntu-latest CI — root cause: the GitHub Actions trigger generator emits a `paths:` block of only `!`-prefixed entries when only ExcludePaths is configured (no IncludePaths). GitHub treats that as "fire only when files match these negative patterns", which is never true, so the workflow never runs. Fix in GitHubActionsVcsTrigger.cs: when only ExcludePaths is set, emit `paths-ignore:` (without `!`) instead of `paths:` with negative-only entries. Mixed include+exclude still uses `paths:` as before. The repo's own .github/workflows/ubuntu-latest.yml regenerated as a side-effect — now uses `paths-ignore`. Expectation: this PR's next push finally fires the ubuntu-latest workflow. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #39.
Three connected things:
fallout --generate-configuration ...instead ofnuke --generate-configuration ....GenerateToolstarget bug:SpecificationsDirectorypointed at the pre-chore(rebrand): rename Nuke.* → Fallout.* (namespaces, csprojs, assemblies, package IDs) #54source/folder, soGlobFilesreturned empty and the target silently did nothing. Fixed tosrc/.GenerateToolsactually runs. Picks up theWriterExtensions.csURL fix from earlier in the rebrand — every<remarks>block stops linking to the deadhttps://www.nuke.build/docs/...URL and points atgithub.com/ChrisonSimtian/Falloutinstead. Also fixes the source-file provider URLs (nuke-build/nuke→ChrisonSimtian/Fallout).Diff: 74 files, +618 / −695 — most of it is XML doc URL changes in
*.Generated.cs.Why the tool wrappers had stale URLs
Generated code is regenerated manually per release (per
CLAUDE.md). #54 updated the generator template (WriterExtensions.cs) to point at GitHub, but never ranGenerateToolsbecause the target was silently broken (#39's root cause). This PR is the first regeneration since #54.Side-effects on this repo's CI
The three top-level GitHub Actions workflow files (
.github/workflows/{ubuntu,windows,macos}-latest.yml) had their header comments refreshed too — they're generated artifacts of the same code path.Snapshot test updates
Six
tests/Fallout.Common.Tests/CI/*.verified.txtsnapshots updated to match the new YAML header. One-line change per snapshot.Verification
dotnet build fallout.slnx -c Debug: 0 errors, 11 pre-existing warnings.dotnet test fallout.slnx: 391 passed, 7 skipped, 0 failed.nuke.buildreferences; remarks URL points at the Fallout repo.🤖 Generated with Claude Code