feat(release): generate rich release notes from milestone + auto PR list#21
Merged
Conversation
The base ICreateGitHubRelease implementation pulls the release body from CHANGELOG.md's [vNext] section, which we don't maintain on this fork — first release ended up with an empty body. Rewrites the override to: - Find the milestone whose title starts with the release version (matches our "10.2.0 - <desc>" convention and the legacy "v10.2.0" form). - List pull requests and issues from the milestone, grouped, with links and author handles. - Set GenerateReleaseNotes=true so GitHub appends its auto-generated PR-since-last-tag list — covers anything not attached to a milestone. - Comment "Released in <version>! 🎉" on every milestone item once the release is created. Drops .Inherit<ICreateGitHubRelease>() so we own the create-release call directly; preserves Octokit usage idiomatic to the rest of the codebase. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The first release (`10.2.0`, just merged) shipped with an empty body because the base `ICreateGitHubRelease` implementation reads from `CHANGELOG.md`'s `[vNext]` section, which we don't maintain.
Replaces that with a milestone-aware release-notes builder that produces something actually useful.
What changes in the release body
For each release tag pushed to main, the generated GitHub Release now contains:
Each milestone item also gets a "Released in vX.Y.Z! 🎉" comment, same as before — but the milestone-lookup is now prefix-matched instead of requiring an exact `v10.2.0` title.
Why not inherit the base
The base `.Inherit()` always runs first and creates the release with the CHANGELOG body. Then our override would add to it. To replace the body entirely, we own the create-release call directly. Octokit usage is consistent with the rest of `Build.cs`.
Test plan
Follow-ups
🤖 Generated with Claude Code