fix(publish): --skip-duplicate so nuget push is idempotent#108
Merged
Conversation
Without --skip-duplicate, a single failed push aborts the whole publish
target, and a rerun then fails with HTTP 409 ("already exists") on
every package that did succeed the first time. That makes release.yml
non-recoverable from any partial-failure state, which we hit twice
today (#107 → SolutionPersistence prefix-reservation, then again
mid-key-permission-debug).
With --skip-duplicate, the push step returns success when a version
is already on nuget.org. Reruns are now safe and only the genuinely
missing packages get uploaded.
Wired via IPublish.PushSettings override (Configure<DotNetNuGetPushSettings>),
which composes on top of the existing PushSettingsBase in
Fallout.Components.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Without `--skip-duplicate`, one failed push during `IPublish.Publish` aborts the whole batch, and any retry fails with HTTP 409 on every package that did succeed the first time. We hit this twice today (#107 SolutionPersistence prefix-reservation, then again during key-permission debugging), and it's painful: the release pipeline becomes non-recoverable from any partial-failure state.
Adds an `IPublish.PushSettings` override that calls `.EnableSkipDuplicate()`. Composes on top of the existing `PushSettingsBase` in `Fallout.Components`, so `--source` and `--api-key` still flow through.
Test plan
🤖 Generated with Claude Code