Skip to content

Don't erase stack/raven if wisp's caster is in another dim #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Robotgiggle wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Don't erase stack/raven if wisp's caster is in another dim #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbb9f89
Don't erase stack and raven if wisp's caster leaves dim
Robotgiggle May 26, 2026
ee57154
Update changelog
Robotgiggle May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
- Fixed wisps being able to generate infinite media by consuming themselves.
- Fixed wisps being unable to access the offhand or inventory of their caster.
- Fixed wisps without a caster being frozen forever.
- Fixed wisps erasing their stack and ravenmind if loaded while their caster is in another dimension.
- Fixed the Relay block not dropping when broken.
- Fixed an error when a playerless caster tries to create a link.
- Fixed an error when passing null or an empty mote to Use Item On.
Expand Down
7 changes: 1 addition & 6 deletions Common/src/main/java/ram/talia/hexal/api/casting/wisp/WispCastingManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,14 +98,9 @@ class WispCastingManager(private val casterUUID: UUID, private var cachedServer:
val wisp = cast.wisp ?: caster!!.serverLevel().getEntity(cast.wispUUID) as? BaseCastingWisp ?: continue
cast.wisp = wisp

if (wisp.isRemoved)
if (wisp.isRemoved || wisp.level().dimension() != caster?.level()?.dimension())
continue

if (wisp.level().dimension() != caster?.level()?.dimension()) {
wisp.castCallback(WispCastResult(wisp, false, mutableListOf(), CompoundTag(), true))
continue
}

results += cast(cast)

evalsLeft--
Expand Down
Loading