Use successful deployment tags for DAR versions #290
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,131 +1,81 @@ | ||
| #!/usr/bin/env node | ||
| /** Replace the one undeployed candidate backup while preserving every deployed DAR. */ | ||
|
|
||
| import * as fs from 'fs'; | ||
| import * as path from 'path'; | ||
| import * as yaml from 'yaml'; | ||
|
|
||
| import { computeSha256, getDarLockKey, getDarsDir, loadDarsLock, saveDarsLock } from './dar-utils'; | ||
| import { planCandidateBackup, readDeploymentTags } from './dar-version-policy'; | ||
| import { getAllPackages, getPackage, parsePackageArg, parseVersionArg } from './packages'; | ||
|
|
||
| function usage(message?: string): never { | ||
| if (message) console.error(`❌ ${message}\n`); | ||
| console.error('Usage: tsx scripts/backup-dar.ts --package <name> --version <version>'); | ||
| console.error( | ||
| `Packages: ${getAllPackages() | ||
| .map((pkg) => pkg.name) | ||
| .join(', ')}` | ||
| ); | ||
| process.exit(1); | ||
| } | ||
|
|
||
| function sdkVersion(sourceDir: string): string { | ||
| const parsed = yaml.parse(fs.readFileSync(path.join(__dirname, '..', sourceDir, 'daml.yaml'), 'utf8')) as { | ||
| 'sdk-version'?: string; | ||
| }; | ||
| return parsed['sdk-version'] ?? 'unknown'; | ||
| } | ||
|
|
||
| function main(): void { | ||
| const packageArg = parsePackageArg(); | ||
| const version = parseVersionArg(); | ||
| if (!packageArg || !version) usage('Missing required arguments'); | ||
| const pkg = getPackage(packageArg); | ||
| if (!pkg) usage(`Unknown package: ${packageArg}`); | ||
| if (version !== pkg.version) usage(`daml.yaml is v${pkg.version}, not v${version}`); | ||
|
|
||
| const root = path.join(__dirname, '..'); | ||
| const source = path.join(root, pkg.sourceDir, '.daml', 'dist', `${pkg.darName}-${version}.dar`); | ||
| if (!fs.existsSync(source)) usage(`Source DAR not found: ${source}. Run npm run build first.`); | ||
|
|
||
| const sha256 = computeSha256(source); | ||
| const { size } = fs.statSync(source); | ||
| const lock = loadDarsLock(); | ||
| const plan = planCandidateBackup(pkg, lock, readDeploymentTags(pkg, root), sha256, size); | ||
| const key = getDarLockKey(pkg.name, version, pkg.darName); | ||
| const destination = path.join(getDarsDir(), key); | ||
|
|
||
| if (plan.replace) { | ||
|
There was a problem hiding this comment.
If a current candidate already has a matching Useful? React with 👍 / 👎. |
||
| fs.mkdirSync(path.dirname(destination), { recursive: true }); | ||
| const temporary = `${destination}.tmp-${process.pid}`; | ||
| try { | ||
| fs.copyFileSync(source, temporary); | ||
|
Comment on lines
+49
to
+53
|
||
| if (computeSha256(temporary) !== sha256) throw new Error('Temporary DAR copy failed integrity verification'); | ||
| fs.renameSync(temporary, destination); | ||
| } finally { | ||
| if (fs.existsSync(temporary)) fs.unlinkSync(temporary); | ||
| } | ||
| lock.packages[key] = { | ||
| sha256, | ||
| size, | ||
| sdkVersion: sdkVersion(pkg.sourceDir), | ||
| uploadedAt: new Date().toISOString(), | ||
| networks: [], | ||
| }; | ||
| } | ||
|
|
||
| lock.packages = Object.fromEntries( | ||
| Object.entries(lock.packages).sort(([left], [right]) => left.localeCompare(right)) | ||
| ); | ||
| saveDarsLock(lock); | ||
| console.log(`${plan.replace ? '✅ Backed up' : '✅ Verified'}: ${key}`); | ||
| console.log(` SHA256: ${sha256}`); | ||
|
There was a problem hiding this comment. Backup skips missing file checkMedium Severity When   Reviewed by Cursor Bugbot for commit e6b8979. Configure here.
Comment on lines
+45
to
+73
|
||
| } | ||
|
|
||
| try { | ||
| main(); | ||
| } catch (error) { | ||
| console.error(`❌ ${error instanceof Error ? error.message : String(error)}`); | ||
| process.exit(1); | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this workflow runs for a push to
main, the preceding fetch step updatesrefs/remotes/origin/mainto the commit that is currently being built (git fetchaccepts the explicitmain:refs/remotes/origin/mainrefspec). Passing that same ref as--basemakeschangedPackages()useHEADas the merge base and see an empty diff, so direct main pushes can skip the DAR version policy entirely. Usegithub.event.beforefor main pushes or run the policy with--allin that context.Useful? React with 👍 / 👎.