Enforce authorized and reserved share ceilings

OpenCapTable-v34/daml/Fairmint/OpenCapTable/OCF/StockConsolidation.daml

@@ -6,7 +6,7 @@ module Fairmint.OpenCapTable.OCF.StockConsolidation where
 -- OCF: https://raw.githubusercontent.com/Open-Cap-Table-Coalition/Open-Cap-Format-OCF/main/schema/objects/transactions/consolidation/StockConsolidation.schema.json
 
 import Fairmint.OpenCapTable.Types.Core (Context)
-import Fairmint.OpenCapTable.Types.Validation (validateNonEmptyStringsArray)
+import Fairmint.OpenCapTable.Types.Validation (validateNonEmptyStringsArray, validateUniqueStringsArray)
 import Fairmint.Shared.TypeHelpers (validateOptionalText)
 
 
@@ -62,4 +62,5 @@ validateStockConsolidationOcfData d =
   -- Arrays element validation (security_ids required per Consolidation base schema)
   validateNonEmptyStringsArray d.comments &&
   validateNonEmptyStringsArray d.security_ids &&
+  validateUniqueStringsArray d.security_ids &&
   not (null d.security_ids)

OpenCapTable-v34/daml/Fairmint/OpenCapTable/Types/Validation.daml

@@ -8,13 +8,27 @@ module Fairmint.OpenCapTable.Types.Validation where
 
 import qualified DA.Text as Text
 import qualified DA.Crypto.Text as CryptoText
+import qualified DA.Set as Set
 import Fairmint.Shared.TypeHelpers (validateRequiredText)
 
 -- Shared Text array validator
 -- Ensures no element is an empty string; empty arrays are allowed
 validateNonEmptyStringsArray : [Text] -> Bool
 validateNonEmptyStringsArray xs = all validateRequiredText xs
 
+hasDuplicateTexts : [Text] -> Bool
+hasDuplicateTexts = hasDuplicateTextsWith Set.empty
+
+hasDuplicateTextsWith : Set.Set Text -> [Text] -> Bool
+hasDuplicateTextsWith seen remaining = case remaining of
+  [] -> False
+  text :: rest ->
+    text `Set.member` seen || hasDuplicateTextsWith (Set.insert text seen) rest
+
+-- Ensures no element appears more than once; empty arrays are allowed
+validateUniqueStringsArray : [Text] -> Bool
+validateUniqueStringsArray xs = not (hasDuplicateTexts xs)
+
 -- Country code
 -- OCF: https://raw.githubusercontent.com/Open-Cap-Table-Coalition/Open-Cap-Format-OCF/main/schema/types/CountryCode.schema.json
 validCountryCodes : [Text]

Test/daml/OpenCapTable/Setup.daml

@@ -1,13 +1,11 @@
 module OpenCapTable.Setup where
 
-import Fairmint.OpenCapTable.OCF.Issuer
 import Fairmint.OpenCapTable.CapTable
 import Fairmint.OpenCapTable.IssuerAuthorization
 import Fairmint.OpenCapTable.Types.Core (Context(..))
 import Fairmint.OpenCapTable.Types.Stock (OcfInitialSharesAuthorized(..))
+import OpenCapTable.TestHelpers (defaultIssuerWithAuthorizedShares)
 import Daml.Script
-import DA.Date
-import DA.Time
 
 data TestUsers = TestUsers{ tu_system_operator: Party, tu_issuer: Party, tu_alice: Party, tu_bob: Party, tu_charlie: Party, tu_rando: Party }
 
@@ -42,20 +40,7 @@ setupTestOcp = script do
 
   capTableCid <- submit issuer do
     exerciseCmd authCid CreateCapTable with
-      issuer_data = IssuerOcfData with
-        id = "ISSUER_1"
-        legal_name = "TestIssuer Inc."
-        formation_date = time (DA.Date.date 2020 Jan 15) 12 0 0
-        country_of_formation = "US"
-        dba = None
-        country_subdivision_of_formation = None
-        country_subdivision_name_of_formation = None
-        tax_ids = []
-        email = None
-        phone = None
-        address = None
-        initial_shares_authorized = Some (OcfInitialSharesNumeric 1000.0)
-        comments = []
+      issuer_data = defaultIssuerWithAuthorizedShares "ISSUER_1" (Some (OcfInitialSharesNumeric 100_000_000.0))
 
   return TestOcp
     { system_operator = system_operator

Test/daml/OpenCapTable/TestConvertibleConversion.daml

@@ -6,7 +6,7 @@ import Fairmint.OpenCapTable.Types.Monetary (OcfMonetary(..))
 import Fairmint.OpenCapTable.Types.Conversion (OcfConversionTriggerType(..), OcfConvertibleConversionRight(..), OcfConvertibleConversionMechanism(..), OcfSAFEConversionMechanism(..), OcfConvertibleType(..), OcfCapitalizationDefinition(..))
 import qualified Fairmint.OpenCapTable.CapTable as CT
 import OpenCapTable.Setup
-import OpenCapTable.TestHelpers (addDefaultStakeholder)
+import OpenCapTable.TestHelpers (defaultStockIssuance, setupForStockIssuance)
 import qualified DA.Date as DA
 import DA.Date (Month(..))
 import qualified DA.Time as DT
@@ -59,72 +59,105 @@ createConvertibleIssuance issuer capTableCid securityId amount =
 -- Based on prod: SAFE conversion to Series Seed-2 Preferred
 testConvertibleConversion_SAFEConversion = script do
   TestOcp{system_operator, issuer, ctx, cap_table} <- setupTestOcp
-  capTableCid <- addDefaultStakeholder issuer cap_table
+  (capTableCid, stockClassId, stakeholderId) <- setupForStockIssuance issuer cap_table
   let securityId = "7b8c9d0e-1f2a-3b4c-5d6e-7f8a9b0c1d2e"
+  let resultSecurityId = "5f4a6b7c-9d0e-2f3a-6b7c-8d9e0f1a2b3c"
+  let conversionDate = DT.time (DA.date 2025 Nov 10) 0 0 0
   result <- createConvertibleIssuance issuer capTableCid securityId 100000.0
   _ <- submit issuer do
     exerciseCmd result.updatedCapTableCid CT.UpdateCapTable with
-      creates = [CT.OcfCreateConvertibleConversion ConvertibleConversionOcfData with
-        id = "25d377f8-a8de-4d8d-853c-2d75927e7927"
-        date = DT.time (DA.date 2025 Nov 10) 0 0 0
-        security_id = securityId
-        trigger_id = "equity-financing-trigger"
-        reason_text = "Automatic conversion upon Series Seed-2 equity financing"
-        resulting_security_ids = ["5f4a6b7c-9d0e-2f3a-6b7c-8d9e0f1a2b3c"]
-        comments = ["SAFE conversion to Series Seed-2 Preferred for Investor A"]
-        balance_security_id = None
-        capitalization_definition = None
-        quantity_converted = None]
+      creates =
+        [ CT.OcfCreateConvertibleConversion ConvertibleConversionOcfData with
+            id = "25d377f8-a8de-4d8d-853c-2d75927e7927"
+            date = conversionDate
+            security_id = securityId
+            trigger_id = "equity-financing-trigger"
+            reason_text = "Automatic conversion upon Series Seed-2 equity financing"
+            resulting_security_ids = [resultSecurityId]
+            comments = ["SAFE conversion to Series Seed-2 Preferred for Investor A"]
+            balance_security_id = None
+            capitalization_definition = None
+            quantity_converted = None
+        , CT.OcfCreateStockIssuance ((defaultStockIssuance
+            "TX_CONV_RESULT_1"
+            resultSecurityId
+            stakeholderId
+            stockClassId) with
+              date = conversionDate
+              quantity = 100.0)
+        ]
       edits = []
       deletes = []
   pure ()
 
 -- Test 2: Convertible conversion with capitalization definition
 testConvertibleConversion_WithCapDefinition = script do
   TestOcp{system_operator, issuer, ctx, cap_table} <- setupTestOcp
-  capTableCid <- addDefaultStakeholder issuer cap_table
+  (capTableCid, stockClassId, stakeholderId) <- setupForStockIssuance issuer cap_table
   let securityId = "CONV-SEC-002"
+  let resultSecurityId = "SSEC-PREFERRED-001"
+  let conversionDate = DT.time (DA.date 2025 Dec 01) 0 0 0
   result <- createConvertibleIssuance issuer capTableCid securityId 250000.0
   _ <- submit issuer do
     exerciseCmd result.updatedCapTableCid CT.UpdateCapTable with
-      creates = [CT.OcfCreateConvertibleConversion ConvertibleConversionOcfData with
-        id = "TX_CONV_CONVERSION_2"
-        date = DT.time (DA.date 2025 Dec 01) 0 0 0
-        security_id = securityId
-        trigger_id = "equity-financing-trigger"
-        reason_text = "Conversion based on fully diluted capitalization at $16M valuation cap"
-        resulting_security_ids = ["SSEC-PREFERRED-001"]
-        comments = ["Conversion of $250,000 SAFE at $16M post-money valuation cap"]
-        balance_security_id = None
-        capitalization_definition = Some (OcfCapitalizationDefinition with
-          exclude_security_ids = []
-          include_security_ids = []
-          include_stock_class_ids = ["COMMON", "PREFERRED"]
-          include_stock_plans_ids = ["ESOP-2024"])
-        quantity_converted = Some 15625.0]  -- $250K / $16 per share
+      creates =
+        [ CT.OcfCreateConvertibleConversion ConvertibleConversionOcfData with
+            id = "TX_CONV_CONVERSION_2"
+            date = conversionDate
+            security_id = securityId
+            trigger_id = "equity-financing-trigger"
+            reason_text = "Conversion based on fully diluted capitalization at $16M valuation cap"
+            resulting_security_ids = [resultSecurityId]
+            comments = ["Conversion of $250,000 SAFE at $16M post-money valuation cap"]
+            balance_security_id = None
+            capitalization_definition = Some (OcfCapitalizationDefinition with
+              exclude_security_ids = []
+              include_security_ids = []
+              include_stock_class_ids = ["COMMON", "PREFERRED"]
+              include_stock_plans_ids = ["ESOP-2024"])
+            quantity_converted = Some 15625.0
+        , CT.OcfCreateStockIssuance ((defaultStockIssuance
+            "TX_CONV_RESULT_2"
+            resultSecurityId
+            stakeholderId
+            stockClassId) with
+              date = conversionDate
+              quantity = 15625.0)
+        ]
       edits = []
       deletes = []
   pure ()
 
 -- Test 3: Partial conversion with balance security
 testConvertibleConversion_PartialConversion = script do
   TestOcp{system_operator, issuer, ctx, cap_table} <- setupTestOcp
-  capTableCid <- addDefaultStakeholder issuer cap_table
+  (capTableCid, stockClassId, stakeholderId) <- setupForStockIssuance issuer cap_table
   let securityId = "CONV-SEC-003"
+  let resultSecurityId = "SSEC-PREFERRED-002"
+  let conversionDate = DT.time (DA.date 2025 Nov 15) 0 0 0
   result <- createConvertibleIssuance issuer capTableCid securityId 500000.0
   _ <- submit issuer do
     exerciseCmd result.updatedCapTableCid CT.UpdateCapTable with
-      creates = [CT.OcfCreateConvertibleConversion ConvertibleConversionOcfData with
-        id = "TX_CONV_CONVERSION_3"
-        date = DT.time (DA.date 2025 Nov 15) 0 0 0
-        security_id = securityId
-        trigger_id = "equity-financing-trigger"
-        reason_text = "Partial conversion - investor electing to convert $300,000 of $500,000 SAFE"
-        resulting_security_ids = ["SSEC-PREFERRED-002"]
-        comments = []
-        balance_security_id = Some "CONV-SEC-003-REMAINDER"
-        capitalization_definition = None
-        quantity_converted = Some 300000.0]
+      creates =
+        [ CT.OcfCreateConvertibleConversion ConvertibleConversionOcfData with
+            id = "TX_CONV_CONVERSION_3"
+            date = conversionDate
+            security_id = securityId
+            trigger_id = "equity-financing-trigger"
+            reason_text = "Partial conversion - investor electing to convert $300,000 of $500,000 SAFE"
+            resulting_security_ids = [resultSecurityId]
+            comments = []
+            balance_security_id = Some "CONV-SEC-003-REMAINDER"
+            capitalization_definition = None
+            quantity_converted = Some 300000.0
+        , CT.OcfCreateStockIssuance ((defaultStockIssuance
+            "TX_CONV_RESULT_3"
+            resultSecurityId
+            stakeholderId
+            stockClassId) with
+              date = conversionDate
+              quantity = 300000.0)
+        ]
       edits = []
       deletes = []
   pure ()

Test/daml/OpenCapTable/TestEquityCompensationAcceptance.daml

@@ -25,7 +25,7 @@ createEquityCompensationIssuance issuer capTableCid =
         stockholder_approval_date = None
         consideration_text = Some "Services rendered"
         security_law_exemptions = []
-        stock_plan_id = Some "SP_2024"
+        stock_plan_id = None
         stock_class_id = Some "SC_COMMON"
         compensation_type = OcfCompensationTypeOptionISO
         quantity = 10000.0

Test/daml/OpenCapTable/TestEquityCompensationCancellation.daml

@@ -25,7 +25,7 @@ createEquityCompensationIssuance issuer capTableCid securityId quantity =
         stockholder_approval_date = None
         consideration_text = None
         security_law_exemptions = []
-        stock_plan_id = Some "PLAN-2020"
+        stock_plan_id = None
         stock_class_id = Some "COMMON"
         compensation_type = OcfCompensationTypeOptionNSO
         quantity = quantity
@@ -90,17 +90,43 @@ testEquityCompensationCancellation_PartialWithOptionals = script do
   TestOcp{system_operator, issuer, ctx, cap_table} <- setupTestOcp
   capTableCid <- addDefaultStakeholder issuer cap_table
   let securityId = "SEC-EC-PARTIAL"
+  let balanceSecurityId = "SEC-EC-PARTIAL-BAL"
+  let cancellationDate = DT.time (DA.date 2024 Jun 30) 0 0 0
   result <- createEquityCompensationIssuance issuer capTableCid securityId 500000.0
   _ <- submit issuer do
     exerciseCmd result.updatedCapTableCid CT.UpdateCapTable with
-      creates = [CT.OcfCreateEquityCompensationCancellation EquityCompensationCancellationOcfData with
-        id = "TX_EC_CANCEL_PARTIAL"
-        date = DT.time (DA.date 2024 Jun 30) 0 0 0
-        security_id = securityId
-        quantity = 150000.0
-        reason_text = "Partial forfeiture due to early departure"
-        balance_security_id = Some "SEC-EC-PARTIAL-BAL"
-        comments = ["Partial cancellation per separation agreement", "Remaining vested options: 350,000"]]
+      creates =
+        [ CT.OcfCreateEquityCompensationCancellation EquityCompensationCancellationOcfData with
+            id = "TX_EC_CANCEL_PARTIAL"
+            date = cancellationDate
+            security_id = securityId
+            quantity = 150000.0
+            reason_text = "Partial forfeiture due to early departure"
+            balance_security_id = Some balanceSecurityId
+            comments = ["Partial cancellation per separation agreement", "Remaining vested options: 350,000"]
+        , CT.OcfCreateEquityCompensationIssuance EquityCompensationIssuanceOcfData with
+            id = "TX_EC_CANCEL_PARTIAL_BALANCE"
+            date = cancellationDate
+            security_id = balanceSecurityId
+            custom_id = "GRANT-001-BALANCE"
+            stakeholder_id = "SH-1"
+            board_approval_date = None
+            stockholder_approval_date = None
+            consideration_text = None
+            security_law_exemptions = []
+            stock_plan_id = None
+            stock_class_id = Some "COMMON"
+            compensation_type = OcfCompensationTypeOptionNSO
+            quantity = 350000.0
+            exercise_price = Some (OcfMonetary with amount = 0.10, currency = "USD")
+            base_price = None
+            early_exercisable = Some False
+            vesting_terms_id = None
+            vestings = []
+            expiration_date = None
+            termination_exercise_windows = []
+            comments = []
+        ]
       edits = []
       deletes = []
   pure ()

Test/daml/OpenCapTable/TestEquityCompensationExercise.daml

@@ -2,7 +2,7 @@ module OpenCapTable.TestEquityCompensationExercise where
 import Fairmint.OpenCapTable.OCF.EquityCompensationExercise
 import qualified Fairmint.OpenCapTable.CapTable as CT
 import OpenCapTable.Setup
-import OpenCapTable.TestHelpers (addDefaultStakeholder, addEquityCompensationIssuance)
+import OpenCapTable.TestHelpers (addPrerequisites, addEquityCompensationIssuance)
 import qualified DA.Date as DA
 import DA.Date (Month(..))
 import qualified DA.Time as DT
@@ -11,7 +11,7 @@ import Daml.Script
 testCreateAndArchiveEquityCompensationExercise = script do
   TestOcp{system_operator, issuer, ctx, cap_table} <- setupTestOcp
   -- Add stakeholder and equity compensation issuance before exercising
-  cap_table <- addDefaultStakeholder issuer cap_table
+  cap_table <- addPrerequisites issuer cap_table
   cap_table <- addEquityCompensationIssuance issuer cap_table "EC-ISS-1" "EC-1" "SH-1"
   _ <- submit issuer do
     exerciseCmd cap_table CT.UpdateCapTable with
@@ -30,7 +30,7 @@ testCreateAndArchiveEquityCompensationExercise = script do
 testCreateAndArchiveEquityCompensationExerciseBuiltIn = script do
   TestOcp{system_operator, issuer, ctx, cap_table} <- setupTestOcp
   -- Add stakeholder and equity compensation issuance before exercising
-  cap_table <- addDefaultStakeholder issuer cap_table
+  cap_table <- addPrerequisites issuer cap_table
   cap_table <- addEquityCompensationIssuance issuer cap_table "EC-ISS-1" "EC-1" "SH-1"
   _ <- submit issuer do
     exerciseCmd cap_table CT.UpdateCapTable with
@@ -50,7 +50,7 @@ testCreateAndArchiveEquityCompensationExerciseBuiltIn = script do
 testEquityCompensationExercise_OptionalsSome = script do
   TestOcp{system_operator, issuer, ctx, cap_table} <- setupTestOcp
   -- Add stakeholder and equity compensation issuance before exercising
-  cap_table <- addDefaultStakeholder issuer cap_table
+  cap_table <- addPrerequisites issuer cap_table
   cap_table <- addEquityCompensationIssuance issuer cap_table "EC-ISS-2" "EC-2" "SH-1"
   _ <- submit issuer do
     exerciseCmd cap_table CT.UpdateCapTable with

Test/daml/OpenCapTable/TestEquityCompensationIssuance.daml

@@ -122,7 +122,7 @@ testEquityCompensationIssuance_OptionalsSome = script do
         exercise_price = Some (OcfMonetary with amount = 2.5, currency = "USD")
         expiration_date = Some (DT.time (DA.date 2034 Feb 01) 0 0 0)
         stock_class_id = Some "SC-1"
-        stock_plan_id = Some "PLAN-1"
+        stock_plan_id = None
         stockholder_approval_date = Some (DT.time (DA.date 2024 Jan 20) 0 0 0)
         vesting_terms_id = Some "VT-1"
         security_law_exemptions = [OcfSecurityExemption with description = "ISO", jurisdiction = "US"]