Validate stakeholder event payloads#438
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Note Reviews pausedUse the following commands to manage reviews:
Use the checkboxes below for quick actions:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai pause |
✅ Action performedReviews paused. |
|
Stakeholder-event hardening and exact #437 parent integration are pushed at audited head db093d7. The implementation validates full generated wrappers/context/template identity and losslessness across direct, generic, dispatcher, batch, and OcpClient paths; relationship started, ended, both, and same-value transitions are valid while neither is rejected; all nine statuses map to CE_STAKEHOLDER_STATUS; exact Text/date/comment order and duplicates are preserved; hostile proxy/accessor/sparse-array boundaries are trap-safe. Source, built, and package tests include any-resistant proofs for event types and fields. Independent audits found no issue. Exact validation passes: full 118 suites / 7,628 tests, typecheck, lint, formatting, build, declarations, exact-public/cardinality, and package-consumer gates. Keeping this PR draft/unassigned while remote CI runs and until the finalized upstream #417-derived chain is propagated. |
|
Fixed the hosted clean-checkout lint failure at exact head |
|
Restacked onto hosted-green #437 exact Conflict resolution preserved #437s detached/frozen global decoder architecture and #438s stakeholder-specific wrapper extraction, semantic validation, exact diagnostics, immutable outputs, and package-facing type proofs. Generic and operation DAML writer proofs now assert the stronger inherited Local validation is green: focused 9 suites / 534 tests; full coverage 121 suites / 8,021 tests; declarations/build/exact-public/cardinality/package-consumer; typecheck; lint; formatting; deterministic inventories; package dry-run (1,278 files, 595,534 bytes); clean diff, ancestry, and remerge audits. The PR remains draft and unassigned while exact-head hosted build-and-test and QuickStart checks run. No reviewer requests will be made in this phase. |
|
Exact head
The PR remains draft and unassigned as requested. No reviewers were requested. |
# Conflicts: # src/functions/OpenCapTable/capTable/batchTypes.ts # src/functions/OpenCapTable/capTable/damlEntityData.ts # src/functions/OpenCapTable/capTable/damlToOcf.ts # src/functions/OpenCapTable/capTable/entityTypes.ts # src/functions/OpenCapTable/stakeholder/getStakeholderAsOcf.ts # src/utils/ocfNormalization.ts # src/utils/ocfZodSchemas.ts # src/utils/replicationHelpers.ts # test/declarations/damlReadDispatch.types.ts # test/declarations/replicationHelpers.types.ts # test/functions/stakeholderEventReaders.test.ts # test/package-consumer/publicEntrypoint.types.ts # test/schemaAlignment/canonicalOcfObjectInventory.json # test/types/capTableBatch.types.ts # test/types/damlReadDispatch.types.ts # test/types/replicationHelpers.types.ts # test/utils/ocfNormalization.test.ts # test/utils/replicationHelpers.test.ts
1 participant
Summary
event_datawrapper the only accepted stakeholder event contract shapeOcpClientreadsReadonlyDamlDataTypeForcontractIntentional breaking changes
relationship_change_dataandstatus_change_dataare no longer accepted as legacy wrapper aliasesnullare rejected losslesslyRecord<string, unknown>Stack
206539f66ad6ec21e53ddabebb5c3e6ba6f4df744373e834b070bf7b2c92f1475b91e2f3feec2576Validation
npm run test:ci: 121 suites / 8,021 testsnpm run typechecknpm run test:declarationsincluding build, exact-public, built-cardinality, and package-consumer checksnpm run lintnpm run formate1ac1de3030914e4d1c25872bb43f2dd4af2d0794a1d78180ad446cb2b941a56npm pack --dry-run: 1,278 files, 595,534 bytesThe PR remains draft and unassigned. Reviewer requests are intentionally deferred to the owning automation stage.