Enforce canonical OCF schema property purity

src/functions/OpenCapTable/capTable/batchTypes.ts

@@ -117,8 +117,7 @@ type OcfEntityRegistry = {
 /**
  * Single source of truth for entity-level metadata.
  *
- * Schema-supported PlanSecurity objects normalize to the canonical EquityCompensation family
- * before reaching typed batch operations.
+ * Only canonical OCF object types reach typed batch operations.
  */
 export const ENTITY_REGISTRY = {
   convertibleAcceptance: {

src/functions/OpenCapTable/document/createDocument.ts

@@ -69,20 +69,6 @@ function objectTypeToDaml(t: OcfObjectReference['object_type']): string {
       return 'OcfObjTxEquityCompensationTransfer';
     case 'TX_EQUITY_COMPENSATION_REPRICING':
       return 'OcfObjTxEquityCompensationRepricing';
-    case 'TX_PLAN_SECURITY_ACCEPTANCE':
-      return 'OcfObjTxPlanSecurityAcceptance';
-    case 'TX_PLAN_SECURITY_CANCELLATION':
-      return 'OcfObjTxPlanSecurityCancellation';
-    case 'TX_PLAN_SECURITY_EXERCISE':
-      return 'OcfObjTxPlanSecurityExercise';
-    case 'TX_PLAN_SECURITY_ISSUANCE':
-      return 'OcfObjTxPlanSecurityIssuance';
-    case 'TX_PLAN_SECURITY_RELEASE':
-      return 'OcfObjTxPlanSecurityRelease';
-    case 'TX_PLAN_SECURITY_RETRACTION':
-      return 'OcfObjTxPlanSecurityRetraction';
-    case 'TX_PLAN_SECURITY_TRANSFER':
-      return 'OcfObjTxPlanSecurityTransfer';
     case 'TX_STOCK_ACCEPTANCE':
       return 'OcfObjTxStockAcceptance';
     case 'TX_STOCK_CANCELLATION':

src/functions/OpenCapTable/document/getDocumentAsOcf.ts

@@ -81,19 +81,19 @@ function objectTypeToNative(t: Fairmint.OpenCapTable.OCF.Document.OcfObjectType)
     case 'OcfObjTxEquityCompensationRepricing':
       return 'TX_EQUITY_COMPENSATION_REPRICING';
     case 'OcfObjTxPlanSecurityAcceptance':
-      return 'TX_PLAN_SECURITY_ACCEPTANCE';
+      return 'TX_EQUITY_COMPENSATION_ACCEPTANCE';
     case 'OcfObjTxPlanSecurityCancellation':
-      return 'TX_PLAN_SECURITY_CANCELLATION';
+      return 'TX_EQUITY_COMPENSATION_CANCELLATION';
     case 'OcfObjTxPlanSecurityExercise':
-      return 'TX_PLAN_SECURITY_EXERCISE';
+      return 'TX_EQUITY_COMPENSATION_EXERCISE';
     case 'OcfObjTxPlanSecurityIssuance':
-      return 'TX_PLAN_SECURITY_ISSUANCE';
+      return 'TX_EQUITY_COMPENSATION_ISSUANCE';
     case 'OcfObjTxPlanSecurityRelease':
-      return 'TX_PLAN_SECURITY_RELEASE';
+      return 'TX_EQUITY_COMPENSATION_RELEASE';
     case 'OcfObjTxPlanSecurityRetraction':
-      return 'TX_PLAN_SECURITY_RETRACTION';
+      return 'TX_EQUITY_COMPENSATION_RETRACTION';
     case 'OcfObjTxPlanSecurityTransfer':
-      return 'TX_PLAN_SECURITY_TRANSFER';
+      return 'TX_EQUITY_COMPENSATION_TRANSFER';
     case 'OcfObjTxStockAcceptance':
       return 'TX_STOCK_ACCEPTANCE';
     case 'OcfObjTxStockCancellation':

src/functions/OpenCapTable/equityCompensationIssuance/createEquityCompensationIssuance.ts

@@ -1,11 +1,6 @@
 import { type Fairmint } from '@fairmint/open-captable-protocol-daml-js';
 import { OcpErrorCodes, OcpParseError } from '../../../errors';
-import type {
-  CompensationType,
-  OcfEquityCompensationIssuance,
-  OcfPlanSecurityIssuance,
-  TerminationWindow,
-} from '../../../types';
+import type { CompensationType, OcfEquityCompensationIssuance, TerminationWindow } from '../../../types';
 import {
   cleanComments,
   dateStringToDAMLTime,
@@ -64,34 +59,29 @@ export const terminationWindowPeriodTypeMap: Record<
   YEARS: 'OcfPeriodYears',
 };
 
+type EquityCompensationIssuanceWriterInput = OcfEquityCompensationIssuance & {
+  id: string;
+  date: string;
+  security_id: string;
+  custom_id: string;
+  stakeholder_id: string;
+  stock_plan_id?: string;
+  stock_class_id?: string;
+  board_approval_date?: string;
+  stockholder_approval_date?: string;
+  consideration_text?: string;
+  vesting_terms_id?: string;
+};
+
 export function equityCompensationIssuanceDataToDaml(
-  d: OcfEquityCompensationIssuance & {
-    id: string;
-    date: string;
-    security_id: string;
-    custom_id: string;
-    stakeholder_id: string;
-    stock_plan_id?: string;
-    stock_class_id?: string;
-    board_approval_date?: string;
-    stockholder_approval_date?: string;
-    consideration_text?: string;
-    vesting_terms_id?: string;
-  }
+  d: EquityCompensationIssuanceWriterInput
 ): Record<string, unknown> {
-  return equityCompensationIssuanceLikeDataToDaml(d, 'equityCompensationIssuance');
+  return equityCompensationIssuancePayloadToDaml(d);
 }
 
-/**
- * Shared canonical DAML payload builder for equity-compensation issuance aliases.
- *
- * Keeping the entire conversion here prevents legacy aliases from bypassing the
- * discriminator-driven pricing and exact Monetary boundary used by the canonical writer.
- */
-export function equityCompensationIssuanceLikeDataToDaml(
-  d: OcfEquityCompensationIssuance | OcfPlanSecurityIssuance,
-  source: 'equityCompensationIssuance' | 'planSecurityIssuance'
-): Record<string, unknown> {
+/** Build the complete canonical issuance payload behind the exact pricing boundary. */
+function equityCompensationIssuancePayloadToDaml(d: EquityCompensationIssuanceWriterInput): Record<string, unknown> {
+  const source = 'equityCompensationIssuance';
   const damlCompensationType = compensationTypeToDaml(d.compensation_type);
   const pricing = validateEquityCompensationPricing(d.compensation_type, d.exercise_price, d.base_price, source);
   return {

src/functions/OpenCapTable/index.ts

@@ -18,8 +18,6 @@ export * from './factory';
 export * from './issuer';
 export * from './issuerAuthorization';
 export * from './issuerAuthorizedSharesAdjustment';
-export * from './planSecurityExercise';
-export * from './planSecurityIssuance';
 export * from './stakeholder';
 export * from './stakeholderRelationshipChangeEvent';
 export * from './stakeholderStatusChangeEvent';

src/functions/OpenCapTable/stakeholder/stakeholderDataToDaml.ts

@@ -60,18 +60,6 @@ function contactInfoWithoutNameToDaml(
   };
 }
 
-function getRelationshipsWithLegacyFallback(
-  data: OcfStakeholder
-): NonNullable<OcfStakeholder['current_relationships']> {
-  if (Array.isArray(data.current_relationships)) {
-    return data.current_relationships;
-  }
-  if (data.current_relationship) {
-    return [data.current_relationship];
-  }
-  return [];
-}
-
 export function stakeholderDataToDaml(data: OcfStakeholder): Fairmint.OpenCapTable.OCF.Stakeholder.StakeholderOcfData {
   assertSafeOcfJson(data, 'stakeholder');
   // Validate input data using the entity validator
@@ -87,7 +75,7 @@ export function stakeholderDataToDaml(data: OcfStakeholder): Fairmint.OpenCapTab
     addresses: (data.addresses ?? []).map(addressToDaml),
     tax_ids: data.tax_ids ?? [],
     comments: cleanComments(data.comments),
-    current_relationships: getRelationshipsWithLegacyFallback(data).map(stakeholderRelationshipTypeToDaml),
+    current_relationships: (data.current_relationships ?? []).map(stakeholderRelationshipTypeToDaml),
     current_status: data.current_status ? stakeholderStatusToDaml(data.current_status) : null,
   };
 

src/functions/OpenCapTable/stockClassSplit/stockClassSplitDataToDaml.ts

@@ -9,12 +9,7 @@ import { cleanComments, dateStringToDAMLTime, normalizeNumericString } from '../
 /**
  * Convert native OCF StockClassSplit data to DAML format.
  *
- * DAML expects split_ratio as an OcfRatio object { numerator, denominator }
- * while OCF has flat split_ratio_numerator and split_ratio_denominator fields.
- *
- * Note: The OCF type includes optional `board_approval_date` and `stockholder_approval_date`
- * fields, but the DAML StockClassSplitOcfData contract does not support these fields.
- * They are intentionally omitted from the conversion.
+ * Both canonical OCF and DAML represent split_ratio as an OcfRatio object.
  */
 export function stockClassSplitDataToDaml(d: OcfStockClassSplit): Record<string, unknown> {
   if (!d.id) {

src/functions/OpenCapTable/stockConsolidation/stockConsolidationDataToDaml.ts

@@ -9,8 +9,7 @@ import { cleanComments, dateStringToDAMLTime, optionalString } from '../../../ut
 /**
  * Convert native OCF StockConsolidation data to DAML format.
  *
- * DAML expects resulting_security_id (singular) while OCF has resulting_security_ids (array).
- * Takes the first item from the array to match DAML schema.
+ * Both canonical OCF and DAML use resulting_security_id (singular).
  */
 export function stockConsolidationDataToDaml(d: OcfStockConsolidation): Record<string, unknown> {
   if (!d.id) {

src/functions/OpenCapTable/warrantExercise/damlToOcf.ts

@@ -4,7 +4,7 @@
 
 import { OcpErrorCodes, OcpValidationError } from '../../../errors';
 import type { OcfWarrantExercise } from '../../../types';
-import { damlTimeToDateString, normalizeNumericString } from '../../../utils/typeConversions';
+import { damlTimeToDateString } from '../../../utils/typeConversions';
 
 /**
  * Convert DAML WarrantExercise data to native OCF format.
@@ -14,20 +14,6 @@ import { damlTimeToDateString, normalizeNumericString } from '../../../utils/typ
  * @returns The native OCF WarrantExercise object
  */
 export function damlWarrantExerciseToNative(d: Record<string, unknown>): OcfWarrantExercise {
-  const quantity =
-    d.quantity === undefined || d.quantity === null
-      ? undefined
-      : typeof d.quantity === 'number'
-        ? d.quantity.toString()
-        : d.quantity;
-  if (quantity !== undefined && typeof quantity !== 'string') {
-    throw new OcpValidationError('warrantExercise.quantity', `Must be string or number, got ${typeof d.quantity}`, {
-      code: OcpErrorCodes.INVALID_TYPE,
-      expectedType: 'string | number',
-      receivedValue: d.quantity,
-    });
-  }
-
   // Validate resulting_security_ids
   if (!Array.isArray(d.resulting_security_ids) || d.resulting_security_ids.length === 0) {
     throw new OcpValidationError('warrantExercise.resulting_security_ids', 'Required field must be a non-empty array', {
@@ -50,7 +36,6 @@ export function damlWarrantExerciseToNative(d: Record<string, unknown>): OcfWarr
     date: damlTimeToDateString(d.date, 'warrantExercise.date'),
     security_id: d.security_id as string,
     trigger_id: d.trigger_id,
-    ...(quantity !== undefined ? { quantity: normalizeNumericString(quantity) } : {}),
     resulting_security_ids: d.resulting_security_ids as string[],
     ...(d.consideration_text ? { consideration_text: d.consideration_text as string } : {}),
     ...(Array.isArray(d.comments) && d.comments.length > 0 ? { comments: d.comments as string[] } : {}),

src/functions/OpenCapTable/warrantExercise/warrantExerciseDataToDaml.ts

@@ -2,14 +2,12 @@
  * OCF to DAML converter for WarrantExercise entities.
  */
 
+import type { Fairmint } from '@fairmint/open-captable-protocol-daml-js';
 import { OcpValidationError } from '../../../errors';
 import type { OcfWarrantExercise } from '../../../types';
-import {
-  cleanComments,
-  dateStringToDAMLTime,
-  normalizeNumericString,
-  optionalString,
-} from '../../../utils/typeConversions';
+import { cleanComments, dateStringToDAMLTime, optionalString } from '../../../utils/typeConversions';
+
+type DamlWarrantExerciseData = Fairmint.OpenCapTable.OCF.WarrantExercise.WarrantExerciseOcfData;
 
 /**
  * Convert native OCF WarrantExercise data to DAML format.
@@ -18,7 +16,7 @@ import {
  * @returns The DAML-formatted warrant exercise data
  * @throws OcpValidationError if required fields are missing
  */
-export function warrantExerciseDataToDaml(d: OcfWarrantExercise): Record<string, unknown> {
+export function warrantExerciseDataToDaml(d: OcfWarrantExercise): DamlWarrantExerciseData {
   if (!d.id) {
     throw new OcpValidationError('warrantExercise.id', 'Required field is missing or empty', {
       expectedType: 'string',
@@ -36,7 +34,8 @@ export function warrantExerciseDataToDaml(d: OcfWarrantExercise): Record<string,
     date: dateStringToDAMLTime(d.date, 'warrantExercise.date'),
     security_id: d.security_id,
     trigger_id: d.trigger_id,
-    quantity: d.quantity ? normalizeNumericString(d.quantity) : null,
+    // DAML retains this ledger-only field; canonical OCF has no corresponding input.
+    quantity: null,
     resulting_security_ids: d.resulting_security_ids,
     consideration_text: optionalString(d.consideration_text),
     comments: cleanComments(d.comments),