Enforce exact optional properties across the SDK

package.json

@@ -50,11 +50,10 @@
     "test:coverage": "jest --coverage --passWithNoTests",
     "test:declarations": "ts-node --project tsconfig.tests.json scripts/check-declarations.ts && tsc -p tsconfig.declaration-tests.json --noEmit && npm run -s test:exact-public-config",
     "test:exact-public-config": "tsc -p tsconfig.exact-public-config-tests.json --noEmit",
-    "test:exact-source": "tsc -p tsconfig.exact-source.json --noEmit",
     "test:integration": "npm run -s typecheck && jest -c jest.integration.config.js --passWithNoTests",
     "test:integration:ci": "npm run -s typecheck && jest -c jest.integration.config.js --runInBand",
     "test:watch": "jest --watch",
-    "typecheck": "tsc -p tsconfig.tests.json --noEmit && npm run -s test:exact-source"
+    "typecheck": "tsc -p tsconfig.tests.json --noEmit"
   },
   "config": {
     "localnet_quickstart_ref": "5c90cf4d0eb934712fd8c269b56e6272b605ccad"

src/functions/OpenCapTable/shared/conversionMechanisms.ts

@@ -617,13 +617,8 @@ export function warrantMechanismToDaml(mechanism: WarrantConversionMechanism): D
           description: mechanism.description,
           discount: mechanism.discount,
           discount_percentage:
-            'discount_percentage' in mechanism && mechanism.discount_percentage !== undefined
-              ? normalizeNumericString(mechanism.discount_percentage)
-              : null,
-          discount_amount:
-            'discount_amount' in mechanism && mechanism.discount_amount
-              ? monetaryToDaml(mechanism.discount_amount)
-              : null,
+            mechanism.discount_percentage !== undefined ? normalizeNumericString(mechanism.discount_percentage) : null,
+          discount_amount: mechanism.discount_amount !== undefined ? monetaryToDaml(mechanism.discount_amount) : null,
         },
       };
     default:

test/capTable/archiveFullCapTable.test.ts

@@ -42,14 +42,16 @@ function mockActiveContractsForCapTableState(
   responses: { current?: unknown[] }
 ): void {
   const current = responses.current ?? [];
-  mockClient.getActiveContracts.mockImplementation(async (req: { templateIds?: string[] }) => {
-    await Promise.resolve();
-    const ids = req.templateIds;
-    if (isCurrentTemplateQuery(ids)) {
-      return current as never;
+  mockClient.getActiveContracts.mockImplementation(
+    async (req: Parameters<LedgerJsonApiClient['getActiveContracts']>[0]) => {
+      await Promise.resolve();
+      const ids = req.templateIds;
+      if (isCurrentTemplateQuery(ids)) {
+        return current as never;
+      }
+      throw new Error(`Unexpected getActiveContracts templateIds in test: ${JSON.stringify(ids)}`);
     }
-    throw new Error(`Unexpected getActiveContracts templateIds in test: ${JSON.stringify(ids)}`);
-  });
+  );
 }
 
 interface TestIssuerData {

test/capTable/getCapTableState.test.ts

@@ -41,14 +41,16 @@ function mockActiveContractsForCapTableState(
   responses: { current?: unknown[] }
 ): void {
   const current = responses.current ?? [];
-  mockClient.getActiveContracts.mockImplementation(async (req: { templateIds?: string[] }) => {
-    await Promise.resolve();
-    const ids = req.templateIds;
-    if (isCurrentTemplateQuery(ids)) {
-      return current as never;
+  mockClient.getActiveContracts.mockImplementation(
+    async (req: Parameters<LedgerJsonApiClient['getActiveContracts']>[0]) => {
+      await Promise.resolve();
+      const ids = req.templateIds;
+      if (isCurrentTemplateQuery(ids)) {
+        return current as never;
+      }
+      throw new Error(`Unexpected getActiveContracts templateIds in test: ${JSON.stringify(ids)}`);
     }
-    throw new Error(`Unexpected getActiveContracts templateIds in test: ${JSON.stringify(ids)}`);
-  });
+  );
 }
 
 /**

test/client/OcpClient.test.ts

@@ -296,7 +296,7 @@ describe('OcpClient OpenCapTable.issuerAuthorization.authorize', () => {
     expect(mockedAuthorizeIssuer).toHaveBeenCalledTimes(1);
   });
 
-  it('keeps client-level observability defaults when per-call fields are undefined', async () => {
+  it('keeps client-level observability defaults when per-call fields are omitted', async () => {
     const ledger = createLedgerJsonApiClient(config);
     const logger = {
       debug: jest.fn(),
@@ -318,9 +318,6 @@ describe('OcpClient OpenCapTable.issuerAuthorization.authorize', () => {
 
     await ocp.OpenCapTable.issuerAuthorization.authorize({
       issuer: 'issuer::party',
-      logger: undefined,
-      metrics: undefined,
-      defaultContext: undefined,
       context: { commandId: 'command-call' },
     });
 

test/client/OcpContextManager.test.ts

@@ -77,11 +77,9 @@ describe('OcpContextManager', () => {
       expect(contextManager.issuerParty).toBeNull();
     });
 
-    it('should not change values when undefined is passed', () => {
+    it('should not change omitted values', () => {
       contextManager.setIssuerParty('issuer::party-123');
-      contextManager.setAll({
-        issuerParty: undefined,
-      });
+      contextManager.setAll({});
 
       expect(contextManager.issuerParty).toBe('issuer::party-123');
     });

test/integration/entities/acceptanceTypes.integration.test.ts

@@ -33,6 +33,7 @@ import {
   setupStockSecurity,
   setupTestIssuer,
   setupWarrantSecurity,
+  withCapTableContractDetails,
 } from '../utils';
 
 /**
@@ -141,7 +142,7 @@ createIntegrationTestSuite('Acceptance Type operations', (getContext) => {
 
     const batch = ctx.ocp.OpenCapTable.capTable.update({
       capTableContractId: stockSecurity.capTableContractId,
-      capTableContractDetails: updatedCapTableDetails,
+      ...withCapTableContractDetails(updatedCapTableDetails),
       actAs: [ctx.issuerParty],
     });
 
@@ -189,7 +190,7 @@ createIntegrationTestSuite('Acceptance Type operations', (getContext) => {
 
     const batch = ctx.ocp.OpenCapTable.capTable.update({
       capTableContractId: warrantSecurity.capTableContractId,
-      capTableContractDetails: updatedCapTableDetails,
+      ...withCapTableContractDetails(updatedCapTableDetails),
       actAs: [ctx.issuerParty],
     });
 
@@ -239,7 +240,7 @@ createIntegrationTestSuite('Acceptance Type operations', (getContext) => {
 
     const batch = ctx.ocp.OpenCapTable.capTable.update({
       capTableContractId: convertibleSecurity.capTableContractId,
-      capTableContractDetails: updatedCapTableDetails,
+      ...withCapTableContractDetails(updatedCapTableDetails),
       actAs: [ctx.issuerParty],
     });
 
@@ -287,7 +288,7 @@ createIntegrationTestSuite('Acceptance Type operations', (getContext) => {
 
     const batch = ctx.ocp.OpenCapTable.capTable.update({
       capTableContractId: eqCompSecurity.capTableContractId,
-      capTableContractDetails: updatedCapTableDetails,
+      ...withCapTableContractDetails(updatedCapTableDetails),
       actAs: [ctx.issuerParty],
     });
 
@@ -336,7 +337,7 @@ createIntegrationTestSuite('Acceptance Type operations', (getContext) => {
     const warrantSecurity = await setupWarrantSecurity(ctx.ocp, {
       issuerContractId: stockSecurity.capTableContractId,
       issuerParty: ctx.issuerParty,
-      capTableContractDetails: currentCapTableDetails,
+      ...withCapTableContractDetails(currentCapTableDetails),
     });
 
     events = await ctx.ocp.ledger.getEventsByContractId({ contractId: warrantSecurity.capTableContractId });
@@ -353,7 +354,7 @@ createIntegrationTestSuite('Acceptance Type operations', (getContext) => {
     const convertibleSecurity = await setupConvertibleSecurity(ctx.ocp, {
       issuerContractId: warrantSecurity.capTableContractId,
       issuerParty: ctx.issuerParty,
-      capTableContractDetails: currentCapTableDetails,
+      ...withCapTableContractDetails(currentCapTableDetails),
     });
 
     events = await ctx.ocp.ledger.getEventsByContractId({ contractId: convertibleSecurity.capTableContractId });
@@ -370,7 +371,7 @@ createIntegrationTestSuite('Acceptance Type operations', (getContext) => {
     const eqCompSecurity = await setupEquityCompensationSecurity(ctx.ocp, {
       issuerContractId: convertibleSecurity.capTableContractId,
       issuerParty: ctx.issuerParty,
-      capTableContractDetails: currentCapTableDetails,
+      ...withCapTableContractDetails(currentCapTableDetails),
     });
 
     events = await ctx.ocp.ledger.getEventsByContractId({ contractId: eqCompSecurity.capTableContractId });
@@ -402,7 +403,7 @@ createIntegrationTestSuite('Acceptance Type operations', (getContext) => {
 
     const batch = ctx.ocp.OpenCapTable.capTable.update({
       capTableContractId: eqCompSecurity.capTableContractId,
-      capTableContractDetails: finalCapTableDetails,
+      ...withCapTableContractDetails(finalCapTableDetails),
       actAs: [ctx.issuerParty],
     });
 
@@ -459,7 +460,7 @@ createIntegrationTestSuite('Acceptance Type operations', (getContext) => {
 
     const batch = ctx.ocp.OpenCapTable.capTable.update({
       capTableContractId: stockSecurity.capTableContractId,
-      capTableContractDetails: updatedCapTableDetails,
+      ...withCapTableContractDetails(updatedCapTableDetails),
       actAs: [ctx.issuerParty],
     });
 
@@ -512,7 +513,7 @@ createIntegrationTestSuite('Acceptance Type operations', (getContext) => {
     // Create the acceptance first
     const createBatch = ctx.ocp.OpenCapTable.capTable.update({
       capTableContractId: stockSecurity.capTableContractId,
-      capTableContractDetails: currentCapTableDetails,
+      ...withCapTableContractDetails(currentCapTableDetails),
       actAs: [ctx.issuerParty],
     });
 
@@ -594,7 +595,7 @@ createIntegrationTestSuite('Acceptance Type operations', (getContext) => {
     // Create the acceptance first
     const createBatch = ctx.ocp.OpenCapTable.capTable.update({
       capTableContractId: stockSecurity.capTableContractId,
-      capTableContractDetails: currentCapTableDetails,
+      ...withCapTableContractDetails(currentCapTableDetails),
       actAs: [ctx.issuerParty],
     });
 

test/integration/entities/stockClassAdjustments.integration.test.ts

@@ -27,6 +27,7 @@ import {
   requireCreatedEventBlob,
   setupStockSecurity,
   setupTestIssuer,
+  withCapTableContractDetails,
 } from '../utils';
 
 createIntegrationTestSuite('Stock Class Adjustments', (getContext) => {
@@ -178,7 +179,7 @@ createIntegrationTestSuite('Stock Class Adjustments', (getContext) => {
     const stockSecurity2 = await setupStockSecurity(ctx.ocp, {
       issuerContractId: stockSecurity1.capTableContractId,
       issuerParty: ctx.issuerParty,
-      capTableContractDetails: currentCapTableDetails,
+      ...withCapTableContractDetails(currentCapTableDetails),
     });
 
     events = await ctx.ocp.ledger.getEventsByContractId({ contractId: stockSecurity2.capTableContractId });
@@ -194,7 +195,7 @@ createIntegrationTestSuite('Stock Class Adjustments', (getContext) => {
     const stockSecurity3 = await setupStockSecurity(ctx.ocp, {
       issuerContractId: stockSecurity2.capTableContractId,
       issuerParty: ctx.issuerParty,
-      capTableContractDetails: currentCapTableDetails,
+      ...withCapTableContractDetails(currentCapTableDetails),
     });
 
     events = await ctx.ocp.ledger.getEventsByContractId({ contractId: stockSecurity3.capTableContractId });
@@ -212,7 +213,7 @@ createIntegrationTestSuite('Stock Class Adjustments', (getContext) => {
 
     const batch = ctx.ocp.OpenCapTable.capTable.update({
       capTableContractId: stockSecurity3.capTableContractId,
-      capTableContractDetails: finalCapTableDetails,
+      ...withCapTableContractDetails(finalCapTableDetails),
       actAs: [ctx.issuerParty],
     });
 
@@ -269,7 +270,7 @@ createIntegrationTestSuite('Stock Class Adjustments', (getContext) => {
 
     const batch = ctx.ocp.OpenCapTable.capTable.update({
       capTableContractId: stockSecurity.capTableContractId,
-      capTableContractDetails: updatedCapTableDetails,
+      ...withCapTableContractDetails(updatedCapTableDetails),
       actAs: [ctx.issuerParty],
     });
 
@@ -325,7 +326,7 @@ createIntegrationTestSuite('Stock Class Adjustments', (getContext) => {
     const stockSecurity2 = await setupStockSecurity(ctx.ocp, {
       issuerContractId: stockSecurity1.capTableContractId,
       issuerParty: ctx.issuerParty,
-      capTableContractDetails: currentCapTableDetails,
+      ...withCapTableContractDetails(currentCapTableDetails),
     });
 
     events = await ctx.ocp.ledger.getEventsByContractId({ contractId: stockSecurity2.capTableContractId });
@@ -341,7 +342,7 @@ createIntegrationTestSuite('Stock Class Adjustments', (getContext) => {
     const stockSecurity3 = await setupStockSecurity(ctx.ocp, {
       issuerContractId: stockSecurity2.capTableContractId,
       issuerParty: ctx.issuerParty,
-      capTableContractDetails: currentCapTableDetails,
+      ...withCapTableContractDetails(currentCapTableDetails),
     });
 
     events = await ctx.ocp.ledger.getEventsByContractId({ contractId: stockSecurity3.capTableContractId });
@@ -356,7 +357,7 @@ createIntegrationTestSuite('Stock Class Adjustments', (getContext) => {
 
     const batch = ctx.ocp.OpenCapTable.capTable.update({
       capTableContractId: stockSecurity3.capTableContractId,
-      capTableContractDetails: finalCapTableDetails,
+      ...withCapTableContractDetails(finalCapTableDetails),
       actAs: [ctx.issuerParty],
     });
 

test/integration/entities/transferTypes.integration.test.ts

@@ -34,6 +34,7 @@ import {
   setupStockSecurity,
   setupTestIssuer,
   setupWarrantSecurity,
+  withCapTableContractDetails,
 } from '../utils';
 
 /** Extract a contract ID from a transaction tree response. */
@@ -107,7 +108,7 @@ createIntegrationTestSuite('Transfer Type operations', (getContext) => {
     const cmd = buildUpdateCapTableCommand(
       {
         capTableContractId: stockSecurity.capTableContractId,
-        capTableContractDetails: updatedCapTableDetails,
+        ...withCapTableContractDetails(updatedCapTableDetails),
       },
       { creates: [{ type: 'stockTransfer', data: transferData }] }
     );
@@ -185,7 +186,7 @@ createIntegrationTestSuite('Transfer Type operations', (getContext) => {
     const cmd = buildUpdateCapTableCommand(
       {
         capTableContractId: convertibleSecurity.capTableContractId,
-        capTableContractDetails: updatedCapTableDetails,
+        ...withCapTableContractDetails(updatedCapTableDetails),
       },
       { creates: [{ type: 'convertibleTransfer', data: transferData }] }
     );
@@ -258,7 +259,7 @@ createIntegrationTestSuite('Transfer Type operations', (getContext) => {
     const cmd = buildUpdateCapTableCommand(
       {
         capTableContractId: eqCompSecurity.capTableContractId,
-        capTableContractDetails: updatedCapTableDetails,
+        ...withCapTableContractDetails(updatedCapTableDetails),
       },
       { creates: [{ type: 'equityCompensationTransfer', data: transferData }] }
     );
@@ -330,7 +331,7 @@ createIntegrationTestSuite('Transfer Type operations', (getContext) => {
     const cmd = buildUpdateCapTableCommand(
       {
         capTableContractId: warrantSecurity.capTableContractId,
-        capTableContractDetails: updatedCapTableDetails,
+        ...withCapTableContractDetails(updatedCapTableDetails),
       },
       { creates: [{ type: 'warrantTransfer', data: transferData }] }
     );

test/integration/entities/valuationVesting.integration.test.ts

@@ -29,6 +29,7 @@ import {
   requireCreatedEventBlob,
   setupStockSecurity,
   setupTestIssuer,
+  withCapTableContractDetails,
 } from '../utils';
 
 function extractContractIdString(cid: { value: unknown }): string {
@@ -193,7 +194,7 @@ createIntegrationTestSuite('Valuation and Vesting types via batch API', (getCont
 
     const batch = ctx.ocp.OpenCapTable.capTable.update({
       capTableContractId: stockSecurity.capTableContractId,
-      capTableContractDetails: updatedCapTableDetails,
+      ...withCapTableContractDetails(updatedCapTableDetails),
       actAs: [ctx.issuerParty],
     });
 
@@ -254,7 +255,7 @@ createIntegrationTestSuite('Valuation and Vesting types via batch API', (getCont
 
     const batch = ctx.ocp.OpenCapTable.capTable.update({
       capTableContractId: stockSecurity.capTableContractId,
-      capTableContractDetails: updatedCapTableDetails,
+      ...withCapTableContractDetails(updatedCapTableDetails),
       actAs: [ctx.issuerParty],
     });
 
@@ -314,7 +315,7 @@ createIntegrationTestSuite('Valuation and Vesting types via batch API', (getCont
 
     const batch = ctx.ocp.OpenCapTable.capTable.update({
       capTableContractId: stockSecurity.capTableContractId,
-      capTableContractDetails: updatedCapTableDetails,
+      ...withCapTableContractDetails(updatedCapTableDetails),
       actAs: [ctx.issuerParty],
     });
 
@@ -365,7 +366,7 @@ createIntegrationTestSuite('Valuation and Vesting types via batch API', (getCont
     const stockSecurity2 = await setupStockSecurity(ctx.ocp, {
       issuerContractId: stockSecurity1.capTableContractId,
       issuerParty: ctx.issuerParty,
-      capTableContractDetails: currentCapTableDetails,
+      ...withCapTableContractDetails(currentCapTableDetails),
     });
 
     events = await ctx.ocp.ledger.getEventsByContractId({ contractId: stockSecurity2.capTableContractId });
@@ -380,7 +381,7 @@ createIntegrationTestSuite('Valuation and Vesting types via batch API', (getCont
 
     const batch = ctx.ocp.OpenCapTable.capTable.update({
       capTableContractId: stockSecurity2.capTableContractId,
-      capTableContractDetails: finalCapTableDetails,
+      ...withCapTableContractDetails(finalCapTableDetails),
       actAs: [ctx.issuerParty],
     });