Enable unchecked indexed access checks

scripts/audit-ocf-schema-alignment.ts

@@ -121,14 +121,17 @@ function extractSdkFields(interfaceName: string): Map<string, { type: string; re
   if (!match) return fields;
 
   const body = match[1];
+  if (body === undefined) return fields;
   const lines = body.split('\n');
 
   for (const line of lines) {
     const declMatch = line.match(/^\s*([a-zA-Z_][a-zA-Z0-9_]*)\??\s*:\s*(.+?);?\s*$/);
     if (declMatch) {
       const name = declMatch[1];
+      const typeDeclaration = declMatch[2];
+      if (name === undefined || typeDeclaration === undefined) continue;
       const hasOptional = line.includes(`${name}?:`);
-      const typeStr = declMatch[2].trim();
+      const typeStr = typeDeclaration.trim();
       const required = !hasOptional;
       fields.set(name, { type: typeStr, required });
     }
@@ -208,7 +211,8 @@ function findSdkField(
   if (sdkFields.has(ocfName)) return ocfName;
   const aliases = FIELD_ALIASES[sdkInterface];
   const aliasMap = aliases ?? {};
-  if (ocfName in aliasMap) return aliasMap[ocfName];
+  const alias = aliasMap[ocfName];
+  if (Object.prototype.hasOwnProperty.call(aliasMap, ocfName) && alias !== undefined) return alias;
   return null;
 }
 
@@ -306,12 +310,12 @@ function main(): void {
     report.push(`| Field | OCF Type | OCF Required? | SDK Type | SDK Required? | Status |`);
     report.push(`|-------|----------|----------------|----------|---------------|--------|`);
 
-    const ocfFieldNames = new Set(Object.keys(properties));
+    const ocfFields = Object.entries(properties).sort(([left], [right]) => left.localeCompare(right));
+    const ocfFieldNames = new Set(ocfFields.map(([name]) => name));
     const sdkFieldNames = new Set(sdkFields.keys());
 
-    for (const ocfField of [...ocfFieldNames].sort()) {
+    for (const [ocfField, prop] of ocfFields) {
       if (ocfField === 'object_type') continue; // Output discriminator, not input
-      const prop = properties[ocfField];
       const ocfType = getOcfType(prop);
       const ocfReq = required.has(ocfField);
       const sdkField = findSdkField(sdkFields, ocfField, sdkInterface);

scripts/optimize-fixtures.ts

@@ -15,6 +15,7 @@
 import { execSync } from 'child_process';
 import fs from 'fs';
 import path from 'path';
+import { requireDefined } from '../src/utils/requireDefined';
 
 interface CoverageData {
   statements: number;
@@ -61,10 +62,10 @@ function parseCoverage(coverageOutput: string): CoverageData {
   }
 
   return {
-    statements: parseFloat(percentages[0]),
-    branches: parseFloat(percentages[1]),
-    functions: parseFloat(percentages[2]),
-    lines: parseFloat(percentages[3]),
+    statements: parseFloat(requireDefined(percentages[0], 'statement coverage percentage')),
+    branches: parseFloat(requireDefined(percentages[1], 'branch coverage percentage')),
+    functions: parseFloat(requireDefined(percentages[2], 'function coverage percentage')),
+    lines: parseFloat(requireDefined(percentages[3], 'line coverage percentage')),
   };
 }
 
@@ -154,8 +155,7 @@ function main() {
   const ESTIMATION_SAMPLE_SIZE = 5;
 
   // Test each file
-  for (let i = 0; i < files.length; i++) {
-    const file = files[i];
+  for (const [i, file] of files.entries()) {
     const progress = `[${i + 1}/${files.length}]`;
     const sizeKB = (file.size / 1024).toFixed(2);
 

scripts/prepare-release.ts

@@ -75,7 +75,11 @@ function parseVersion(version: string): { major: number; minor: number; patch: n
   if (!parts.every((part) => Number.isInteger(part) && part >= 0)) {
     return null;
   }
-  return { major: parts[0], minor: parts[1], patch: parts[2] };
+  const [major, minor, patch] = parts;
+  if (major === undefined || minor === undefined || patch === undefined) {
+    return null;
+  }
+  return { major, minor, patch };
 }
 
 interface ParsedVersion {

src/functions/OpenCapTable/capTable/archiveFullCapTable.ts

@@ -56,7 +56,8 @@ function getArchiveMatchByContractId(
   }
 
   const matchedContracts = candidates.filter((match) => match.capTableContractId === expectedCapTableContractId);
-  return matchedContracts.length === 1 ? matchedContracts[0] : null;
+  const [matchedContract] = matchedContracts;
+  return matchedContracts.length === 1 && matchedContract !== undefined ? matchedContract : null;
 }
 
 function getSingletonArchiveMatch(classification: {

src/functions/OpenCapTable/capTable/getCapTableState.ts

@@ -475,7 +475,14 @@ export async function classifyIssuerCapTables(
   if (currentRows.length === 0) {
     return { status: 'none', current: null };
   }
-  return { status: 'current', current: currentRows[0] };
+  const [current] = currentRows;
+  if (current === undefined) {
+    throw new OcpContractError('CapTable query returned an inconsistent non-empty result', {
+      code: OcpErrorCodes.SCHEMA_MISMATCH,
+      contractId: 'unknown',
+    });
+  }
+  return { status: 'current', current };
 }
 
 /**

src/functions/OpenCapTable/convertibleConversion/getConvertibleConversionAsOcf.ts

@@ -110,7 +110,7 @@ export async function getConvertibleConversionAsOcf(
   const event: OcfConvertibleConversionEvent = {
     object_type: 'TX_CONVERTIBLE_CONVERSION',
     id: d.id,
-    date: d.date.split('T')[0],
+    date: d.date.split('T')[0] ?? d.date,
     reason_text: d.reason_text,
     security_id: d.security_id,
     trigger_id: d.trigger_id,

src/functions/OpenCapTable/convertibleIssuance/getConvertibleIssuanceAsOcf.ts

@@ -636,7 +636,7 @@ export function damlConvertibleIssuanceDataToNative(d: Record<string, unknown>):
   const issuance = {
     object_type: 'TX_CONVERTIBLE_ISSUANCE',
     id: d.id,
-    date: d.date.split('T')[0],
+    date: d.date.split('T')[0] ?? d.date,
     security_id: d.security_id,
     custom_id: d.custom_id as string,
     stakeholder_id: d.stakeholder_id as string,

src/functions/OpenCapTable/convertibleTransfer/getConvertibleTransferAsOcf.ts

@@ -42,7 +42,7 @@ export async function getConvertibleTransferAsOcf(
   const event: OcfConvertibleTransferEvent = {
     object_type: 'TX_CONVERTIBLE_TRANSFER',
     id: data.id,
-    date: data.date.split('T')[0],
+    date: data.date.split('T')[0] ?? data.date,
     security_id: data.security_id,
     amount: {
       amount: normalizeNumericString(amountStr),

src/functions/OpenCapTable/equityCompensationCancellation/getEquityCompensationCancellationAsOcf.ts

@@ -54,7 +54,7 @@ export async function getEquityCompensationCancellationAsOcf(
   const event: OcfEquityCompensationCancellationEvent = {
     object_type: 'TX_EQUITY_COMPENSATION_CANCELLATION',
     id: data.id,
-    date: data.date.split('T')[0],
+    date: data.date.split('T')[0] ?? data.date,
     security_id: data.security_id,
     quantity: normalizeNumericString(quantityStr),
     ...(data.balance_security_id ? { balance_security_id: data.balance_security_id } : {}),

src/functions/OpenCapTable/equityCompensationExercise/getEquityCompensationExerciseAsOcf.ts

@@ -50,7 +50,7 @@ export function damlEquityCompensationExerciseDataToNative(d: Record<string, unk
   return {
     object_type: 'TX_EQUITY_COMPENSATION_EXERCISE',
     id: d.id,
-    date: d.date.split('T')[0],
+    date: d.date.split('T')[0] ?? d.date,
     security_id: d.security_id,
     quantity: normalizeNumericString(typeof d.quantity === 'number' ? d.quantity.toString() : d.quantity),
     ...(d.consideration_text ? { consideration_text: d.consideration_text as string } : {}),

src/functions/OpenCapTable/equityCompensationIssuance/getEquityCompensationIssuanceAsOcf.ts

@@ -200,13 +200,15 @@ export function damlEquityCompensationIssuanceDataToNative(d: Record<string, unk
   return {
     object_type: 'TX_EQUITY_COMPENSATION_ISSUANCE',
     id: d.id,
-    date: d.date.split('T')[0],
+    date: d.date.split('T')[0] ?? d.date,
     security_id: d.security_id,
     custom_id: d.custom_id,
     stakeholder_id: d.stakeholder_id,
     compensation_type: compensationType,
     quantity: normalizeNumericString(typeof d.quantity === 'number' ? d.quantity.toString() : d.quantity),
-    expiration_date: d.expiration_date ? (d.expiration_date as string).split('T')[0] : null,
+    expiration_date: d.expiration_date
+      ? ((d.expiration_date as string).split('T')[0] ?? (d.expiration_date as string))
+      : null,
     termination_exercise_windows: termination_exercise_windows ?? [],
     ...(exercise_price ? { exercise_price } : {}),
     ...(base_price ? { base_price } : {}),

src/functions/OpenCapTable/equityCompensationTransfer/getEquityCompensationTransferAsOcf.ts

@@ -43,7 +43,7 @@ export async function getEquityCompensationTransferAsOcf(
   const event: OcfEquityCompensationTransferEvent = {
     object_type: 'TX_EQUITY_COMPENSATION_TRANSFER',
     id: data.id,
-    date: data.date.split('T')[0],
+    date: data.date.split('T')[0] ?? data.date,
     security_id: data.security_id,
     quantity: normalizeNumericString(quantityStr),
     resulting_security_ids: data.resulting_security_ids,

src/functions/OpenCapTable/issuerAuthorizedSharesAdjustment/getIssuerAuthorizedSharesAdjustmentAsOcf.ts

@@ -49,7 +49,7 @@ export function damlIssuerAuthorizedSharesAdjustmentDataToNative(
   return {
     object_type: 'TX_ISSUER_AUTHORIZED_SHARES_ADJUSTMENT',
     id: d.id,
-    date: d.date.split('T')[0],
+    date: d.date.split('T')[0] ?? d.date,
     issuer_id: d.issuer_id,
     new_shares_authorized: normalizeNumericString(
       typeof d.new_shares_authorized === 'number' ? String(d.new_shares_authorized) : d.new_shares_authorized

src/functions/OpenCapTable/stakeholderRelationshipChangeEvent/getStakeholderRelationshipChangeEventAsOcf.ts

@@ -131,7 +131,7 @@ export async function getStakeholderRelationshipChangeEventAsOcf(
   const event: OcfStakeholderRelationshipChangeEvent = {
     object_type: 'CE_STAKEHOLDER_RELATIONSHIP',
     id: data.id,
-    date: data.date.split('T')[0],
+    date: data.date.split('T')[0] ?? data.date,
     stakeholder_id: data.stakeholder_id,
     ...relationshipFields,
     ...(data.comments.length ? { comments: data.comments } : {}),

src/functions/OpenCapTable/stakeholderStatusChangeEvent/getStakeholderStatusChangeEventAsOcf.ts

@@ -98,7 +98,7 @@ export async function getStakeholderStatusChangeEventAsOcf(
   const event: OcfStakeholderStatusChangeEvent = {
     object_type: 'CE_STAKEHOLDER_STATUS',
     id: data.id,
-    date: data.date.split('T')[0],
+    date: data.date.split('T')[0] ?? data.date,
     stakeholder_id: data.stakeholder_id,
     new_status: damlStakeholderStatusToNative(data.new_status),
     ...(data.comments.length ? { comments: data.comments } : {}),

src/functions/OpenCapTable/stockCancellation/getStockCancellationAsOcf.ts

@@ -41,7 +41,7 @@ export async function getStockCancellationAsOcf(
   const event: OcfStockCancellationEvent = {
     object_type: 'TX_STOCK_CANCELLATION',
     id: data.id,
-    date: data.date.split('T')[0],
+    date: data.date.split('T')[0] ?? data.date,
     security_id: data.security_id,
     quantity: normalizeNumericString(quantityStr),
     ...(data.balance_security_id ? { balance_security_id: data.balance_security_id } : {}),

src/functions/OpenCapTable/stockClassConversionRatioAdjustment/damlToStockClassConversionRatioAdjustment.ts

@@ -41,7 +41,7 @@ export function damlStockClassConversionRatioAdjustmentToNative(
   return {
     object_type: 'TX_STOCK_CLASS_CONVERSION_RATIO_ADJUSTMENT',
     id: d.id,
-    date: d.date.split('T')[0],
+    date: d.date.split('T')[0] ?? d.date,
     stock_class_id: d.stock_class_id,
     new_ratio_conversion_mechanism: {
       type: 'RATIO_CONVERSION',

src/functions/OpenCapTable/stockClassConversionRatioAdjustment/getStockClassConversionRatioAdjustmentAsOcf.ts

@@ -49,7 +49,7 @@ export async function getStockClassConversionRatioAdjustmentAsOcf(
   const event: OcfStockClassConversionRatioAdjustmentEvent = {
     object_type: 'TX_STOCK_CLASS_CONVERSION_RATIO_ADJUSTMENT',
     id: data.id,
-    date: data.date.split('T')[0],
+    date: data.date.split('T')[0] ?? data.date,
     stock_class_id: data.stock_class_id,
     new_ratio_conversion_mechanism: {
       type: 'RATIO_CONVERSION',

src/functions/OpenCapTable/stockClassSplit/damlToStockClassSplit.ts

@@ -31,7 +31,7 @@ export function damlStockClassSplitToNative(d: DamlStockClassSplitData): OcfStoc
   return {
     object_type: 'TX_STOCK_CLASS_SPLIT',
     id: d.id,
-    date: d.date.split('T')[0],
+    date: d.date.split('T')[0] ?? d.date,
     stock_class_id: d.stock_class_id,
     split_ratio: {
       numerator: normalizeNumericString(numeratorStr),

src/functions/OpenCapTable/stockClassSplit/getStockClassSplitAsOcf.ts

@@ -44,7 +44,7 @@ export async function getStockClassSplitAsOcf(
   const event: OcfStockClassSplitEvent = {
     object_type: 'TX_STOCK_CLASS_SPLIT',
     id: data.id,
-    date: data.date.split('T')[0],
+    date: data.date.split('T')[0] ?? data.date,
     stock_class_id: data.stock_class_id,
     split_ratio: {
       numerator: normalizeNumericString(splitRatioNumeratorStr),

src/functions/OpenCapTable/stockConsolidation/damlToStockConsolidation.ts

@@ -23,7 +23,7 @@ export function damlStockConsolidationToNative(d: DamlStockConsolidationData): O
   return {
     object_type: 'TX_STOCK_CONSOLIDATION',
     id: d.id,
-    date: d.date.split('T')[0],
+    date: d.date.split('T')[0] ?? d.date,
     security_ids: d.security_ids,
     resulting_security_id: d.resulting_security_id,
     ...(d.reason_text ? { reason_text: d.reason_text } : {}),

src/functions/OpenCapTable/stockConsolidation/getStockConsolidationAsOcf.ts

@@ -35,7 +35,7 @@ export async function getStockConsolidationAsOcf(
   const event: OcfStockConsolidationEvent = {
     object_type: 'TX_STOCK_CONSOLIDATION',
     id: data.id,
-    date: data.date.split('T')[0],
+    date: data.date.split('T')[0] ?? data.date,
     security_ids: data.security_ids,
     resulting_security_id: data.resulting_security_id,
     ...(data.reason_text ? { reason_text: data.reason_text } : {}),

src/functions/OpenCapTable/stockConversion/getStockConversionAsOcf.ts

@@ -93,7 +93,7 @@ export async function getStockConversionAsOcf(
   const event: OcfStockConversionEvent = {
     object_type: 'TX_STOCK_CONVERSION',
     id: d.id,
-    date: d.date.split('T')[0],
+    date: d.date.split('T')[0] ?? d.date,
     security_id: d.security_id,
     quantity_converted: normalizeNumericString(
       typeof d.quantity_converted === 'number' ? d.quantity_converted.toString() : d.quantity_converted

src/functions/OpenCapTable/stockPlanPoolAdjustment/getStockPlanPoolAdjustmentAsOcf.ts

@@ -31,7 +31,7 @@ export function damlStockPlanPoolAdjustmentDataToNative(
   return {
     object_type: 'TX_STOCK_PLAN_POOL_ADJUSTMENT',
     id: data.id,
-    date: data.date.split('T')[0],
+    date: data.date.split('T')[0] ?? data.date,
     stock_plan_id: data.stock_plan_id,
     shares_reserved: normalizeNumericString(sharesReservedStr),
     ...(data.board_approval_date ? { board_approval_date: data.board_approval_date.split('T')[0] } : {}),

src/functions/OpenCapTable/stockReissuance/damlToStockReissuance.ts

@@ -22,7 +22,7 @@ export function damlStockReissuanceToNative(d: DamlStockReissuanceData): OcfStoc
   return {
     object_type: 'TX_STOCK_REISSUANCE',
     id: d.id,
-    date: d.date.split('T')[0],
+    date: d.date.split('T')[0] ?? d.date,
     security_id: d.security_id,
     resulting_security_ids: d.resulting_security_ids,
     ...(d.reason_text ? { reason_text: d.reason_text } : {}),

src/functions/OpenCapTable/stockReissuance/getStockReissuanceAsOcf.ts

@@ -36,7 +36,7 @@ export async function getStockReissuanceAsOcf(
   const event: OcfStockReissuanceEvent = {
     object_type: 'TX_STOCK_REISSUANCE',
     id: data.id,
-    date: data.date.split('T')[0],
+    date: data.date.split('T')[0] ?? data.date,
     security_id: data.security_id,
     resulting_security_ids: data.resulting_security_ids,
     ...(data.reason_text ? { reason_text: data.reason_text } : {}),

src/functions/OpenCapTable/stockRepurchase/getStockRepurchaseAsOcf.ts

@@ -42,7 +42,7 @@ export async function getStockRepurchaseAsOcf(
   const event: OcfStockRepurchaseEvent = {
     object_type: 'TX_STOCK_REPURCHASE',
     id: data.id,
-    date: data.date.split('T')[0],
+    date: data.date.split('T')[0] ?? data.date,
     security_id: data.security_id,
     quantity: normalizeNumericString(quantityStr),
     price: damlMonetaryToNative(data.price),

src/functions/OpenCapTable/stockTransfer/getStockTransferAsOcf.ts

@@ -42,7 +42,7 @@ export async function getStockTransferAsOcf(
   const event: OcfStockTransferEvent = {
     object_type: 'TX_STOCK_TRANSFER',
     id: data.id,
-    date: data.date.split('T')[0],
+    date: data.date.split('T')[0] ?? data.date,
     security_id: data.security_id,
     quantity: normalizeNumericString(quantityStr),
     resulting_security_ids: data.resulting_security_ids,

src/functions/OpenCapTable/valuation/damlToOcf.ts

@@ -19,13 +19,14 @@ const DAML_VALUATION_TYPE_MAP: Record<string, ValuationType> = {
  * @throws OcpParseError if the DAML type is unknown
  */
 export function damlValuationTypeToNative(damlType: string): ValuationType {
-  if (!(damlType in DAML_VALUATION_TYPE_MAP)) {
+  const valuationType = DAML_VALUATION_TYPE_MAP[damlType];
+  if (!Object.prototype.hasOwnProperty.call(DAML_VALUATION_TYPE_MAP, damlType) || valuationType === undefined) {
     throw new OcpParseError(`Unknown DAML valuation type: ${damlType}`, {
       source: 'valuation.valuation_type',
       code: OcpErrorCodes.UNKNOWN_ENUM_VALUE,
     });
   }
-  return DAML_VALUATION_TYPE_MAP[damlType];
+  return valuationType;
 }
 
 /**

src/functions/OpenCapTable/warrantCancellation/getWarrantCancellationAsOcf.ts

@@ -53,7 +53,7 @@ export async function getWarrantCancellationAsOcf(
   const event: OcfWarrantCancellationEvent = {
     object_type: 'TX_WARRANT_CANCELLATION',
     id: data.id,
-    date: data.date.split('T')[0],
+    date: data.date.split('T')[0] ?? data.date,
     security_id: data.security_id,
     quantity: normalizeNumericString(quantityStr),
     ...(data.balance_security_id ? { balance_security_id: data.balance_security_id } : {}),

src/functions/OpenCapTable/warrantIssuance/getWarrantIssuanceAsOcf.ts

@@ -414,7 +414,7 @@ export function damlWarrantIssuanceDataToNative(d: Record<string, unknown>): Ocf
             });
           }
           return {
-            date: v.date.split('T')[0],
+            date: v.date.split('T')[0] ?? v.date,
             amount: normalizeNumericString(amountStr),
           };
         })
@@ -455,7 +455,7 @@ export function damlWarrantIssuanceDataToNative(d: Record<string, unknown>): Ocf
   return {
     object_type: 'TX_WARRANT_ISSUANCE',
     id: d.id,
-    date: d.date.split('T')[0],
+    date: d.date.split('T')[0] ?? d.date,
     security_id: d.security_id,
     custom_id: d.custom_id,
     stakeholder_id: d.stakeholder_id,

src/functions/OpenCapTable/warrantTransfer/getWarrantTransferAsOcf.ts

@@ -42,7 +42,7 @@ export async function getWarrantTransferAsOcf(
   const event: OcfWarrantTransferEvent = {
     object_type: 'TX_WARRANT_TRANSFER',
     id: data.id,
-    date: data.date.split('T')[0],
+    date: data.date.split('T')[0] ?? data.date,
     security_id: data.security_id,
     quantity: normalizeNumericString(quantityStr),
     resulting_security_ids: data.resulting_security_ids,