copiado el codigo de mc20printer y actualizado a la ultima versión de electron#4
copiado el codigo de mc20printer y actualizado a la ultima versión de electron#4Pabloferrandezroca wants to merge 1 commit into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 21c7e2dba7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| // find the apikey in resPrinters and update lastactivity | ||
| for (const item of resTickets.data) { | ||
| if (item.appversion > 1.0) { |
There was a problem hiding this comment.
With package.json now declaring 1.4.0, this hard-coded > 1.0 rejects any ticket whose API reports appversion 1.1–1.4 even though this client should handle it. In that branch no send-to-printer is sent, and the loop still executes the unconditional printed=1 update below, so those tickets are acknowledged without printing; compare against the actual app version and don't mark skipped tickets printed.
Useful? React with 👍 / 👎.
| - name: Build | ||
| run: npm run ${{ matrix.script }} | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
On release events this matrix build runs on the tag ref, and passing GH_TOKEN enables electron-builder's implicit GitHub publishing (its v26 docs state that when GH_TOKEN/GITHUB_TOKEN is defined, GitHub is the default publisher and CI tag builds publish). That makes each OS build try to upload release assets before the dedicated release job, which can fail in repos where this build job's token is read-only or duplicate the assets that softprops/action-gh-release uploads; remove the token/use --publish never in the build step and publish only in the release job.
Useful? React with 👍 / 👎.
1 participant
No description provided.