fix(linux): enforce reproducible AppImage build baseline - #40
Conversation
kalopsia-space
left a comment
There was a problem hiding this comment.
Reviewed PR #40 against linux. I found no blocking correctness or security issues in the changed files. The pinned AppImage tool/runtime inputs are verified by size and SHA-256 with atomic replacement; the AppImage is built with an explicit runtime and checked against the GLIBC_2.35 ceiling before checksum creation; the Windows manifest update preserves the Linux binding; and the release workflow removal matches the stated build-validation-only policy.
Verified: GitHub checks are passing (Linux AppImage, Linux/Windows engine, Python 3.12/3.14, release verification); mergeable; git diff --check and AST parsing pass locally. I could not run pytest locally because pytest is not installed in this environment. Approving based on the passing CI and code inspection.
Summary
appimagetooland the type-2 runtime by release, commit, exact size, and SHA-256--runtime-fileThis addresses the portability failure reported in #28 without changing the Linux capture implementation.
Validation
git diff --check: passedGitHub CI has physically completed the Ubuntu 22.04 AppImage package and GLIBC validation job successfully. Physical launch/capture validation on Linux hardware remains pending.