Repository navigation
fix: scope Config archive credentials to their feed origin - #456
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Config feed reads used urllib’s default redirect handler, which copies Authorization onto a redirected storage request. Share a credential-safe redirect handler across authenticated archive and enumeration reads: preserve same-origin Authorization and remove it when scheme, hostname or effective port changes. Restrict initial organization Basic credentials to the organization feed origin even when its service index names an external archive endpoint. Retain redacted stage, response host and HTTP status before refusing an unreadable feed.
Validation: actual urllib same/cross-origin controls, explicit default-port and foreign index endpoint controls, redacted index/archive403 controls, existing archive/recovery/readback cases, 35 extracted resolver controls, 30 mutations and Python syntax pass through the maintained harness at exact head 896be69. Original hosted readback37934541796/a1 and both digest-verified artifacts remain preserved. The original403 cause and org distribution readback remain unresolved. No dispatch, package generation or publication retry occurred.