Repository navigation
Avoid repeated opcode allocation in coherent WASM 0.6 source - #722
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The admission instruction loop constructs an eight-element list and equality comparer for every opcode in the generated Worker. Replace that lookup with exact pattern matching for the same eight one-u32 instructions in a coherent unpublished 0.6.0 pair and SDK. The byte/u32 parser, first-error offsets, refusal set, ABI, capacities and original pre-create deadlines remain unchanged. This removes concrete repeated allocation; it does not establish a prior timeout's CPU cause or guarantee future scheduling.
Add public regression coverage for all eight opcodes, one/two/five-byte operands and exact truncated/overflow/unterminated offsets. A separate owned module receives65,536 genuine nop instructions, then uses three actual fresh installed Workers through initial load, candidate abort and new candidate preparation. The existing 250ms limited requests, stage observations and cleanup assertions remain. No private module, warmup, phase reset or clock widening is introduced.
Current mandatory ApiCompat compares against authentic published0.5 P805400/treefa2, manifest4874 and signed served archive hashes. Its original policy remains byte-identical historical evidence data. The finite0.5 installed binder explicitly refuses unpublished0.6; future publication and qualifier inputs require genuine receipts.
Validation:
5d39d89dc2bc2ebe36f9423a26baf12f52d6578e; the review caught and resolved the stale0.4 baseline/missing0.5 historical policy reader before execution.Owning outcome: Game718; WASM-SHARED-01. Atlas
game/closed-worker-build-boundarycaptures source and remaining gates. Published0.5 and all prior accepted P/Q evidence stay immutable. This source PR selects no publication, installed operation, consumer/image/native activation or whole product acceptance.