Repository navigation
Keep controlled supplier verification under the journal lock - #1022
Merged
Merged
Conversation
…v3-checkpoint-source-20261016 # Conflicts: # eng/qualify-portable-supplier-contract.py # tests/FS.GG.Coordination.Orchestration.Execution.Tests/PortableHostAllocationTests.fs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A cold supplier read could release the journal owner lock before signature and current-policy verification. ReadControlledV4 now checks the expected original, revision and fence, compares the complete fresh record against the canonical serializer bytes, and runs the maintained verifier while holding the same lock. The private result remains a controlled source snapshot with durability Unknown.
The signed zero and selected journeys exercise successful rereads, pending and stale/foreign/contended refusals, malformed and noncanonical records, and current-policy failures. The change uses the existing current /4 path and adds no package, schema or production authority. The owning contract and Atlas record describe the boundary.
Validation: independent source and Home evidence review accepted 8117714; supported SDK 10.0.400 locked restore, strict Release build and the exact controlled-source Fact passed. Final-head Bootstrap run 38930658119 passed with zero build warnings/errors. Retained focused TRXs passed 46 allocation, 80 executor, 55 inert, 29 transport, 47 process and 714 architecture cases, including the signed/store/locked-reader journey. The maintained dependency policy and transitive vulnerability audit passed in their existing scope (29 projects; no listed vulnerabilities). Full coherent run 38930658265 passed; independent review accepted its exact source/plan/aggregate binding (receipt 71440ba8). No local CLR execution. Historical failed attempts remain unchanged.