Repository navigation
atlas: record four lessons from the FS.GG.SDD owner-skill refresh - #5236
Merged
Merged
Conversation
FS-GG/FS.GG.SDD#1155) - sdd/driver-pin-bump-repins-goldens-and-lockfiles: a FS.GG.Drivers pin bump also regenerates seven lockfiles, re-pins the embedded-skill goldens and the fixtures modelling a coherent scaffold, and exposed an O(n) effect-log lookup that made doctor 36x slower; the five-version staleness bound is enforced at release preparation. - sdd/upgrade-apply-loop-stalls-when-effect-set-grows: an apply step that waits while anything is planned never emits effects that only become plannable after the first ones run; and re-deriving the whole plan per interpreted result made a refresh take minutes (waits while writes are in flight). - sdd/provenance-must-record-only-landed-writes: write the provenance last, claim only what landed, record a replaced skill all-or-nothing, and let the next run finish a partial one. - sdd/legacy-version-bound-equal-version-strings-prove-nothing: an equal CLI version string is not proof against an older pack in a dev build; the merged rule is a channel floor plus a writer bound. Every record cites FS.GG.SDD at the merge commit of #1161 (4b54aa17) with fresh sha256s. Mirrored into both skill seeds; driver manifest regenerated (generate-driver-manifest --write, --check current); tests/atlas/check.py passes. Source delivery only. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
EHotwagner
force-pushed
the
routine/atlas-sdd-1155-lessons
branch
from
November 2, 2026 05:54
30814cb to
31b772b
Compare
Contributor
Author
|
Root/fdev check of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs FS-GG/FS.GG.SDD#1155
Refs #5222
Atlas capture owed from the FS.GG.SDD owner-skill refresh (FS-GG/FS.GG.SDD#1156, #1155; merged as #1157 and #1158). Four lessons, each a few KiB, each citing the merged source at
4b54aa17(the merge commit of FS-GG/FS.GG.SDD#1161) with fresh sha256s:sdd/driver-pin-bump-repins-goldens-and-lockfiles: a FS.GG.Drivers pin bump also regenerates seven lockfiles and re-pins goldens and fixtures; it exposed an O(n) effect-log lookup (doctor0.3 s to 11.7 s); the five-version staleness bound is enforced at release preparation.sdd/upgrade-apply-loop-stalls-when-effect-set-grows: an apply step that waits while anything is planned never emits effects that only become plannable once the first ones run, and re-deriving the whole plan per interpreted result made a refresh take minutes.sdd/provenance-must-record-only-landed-writes: write the provenance last, claim only what landed, record a replaced skill all-or-nothing, and let the next run finish a partial one.sdd/legacy-version-bound-equal-version-strings-prove-nothing: an equal CLI version string is not proof against an older pack (a dev build); the merged rule (gate: invert repo-filter-monopoly + graphql-monopoly to allow-lists #1161) is a channel floor plus a writer bound.Mechanics: captured with
atlas.py capture, mirrored byte-for-byte into both skill seeds, andregistry/driver-skill-manifest.jsonregenerated withgenerate-driver-manifest --write(--checkis current).tests/atlas/check.pypasses (514 records, 1269 local immutable citations verified). The seed is part of theatlasdriver skill, so this changes the Drivers package content; publishing it remains a separate delivery boundary and no fleet installation is claimed.Hosted CI on the re-cited head: 46 checks pass, 3 skip, 1 fails:
semantic-skill-qualitywas cancelled at its 10-minute timeout (10m17s), as it was on the merged Atlas PR #5235 (10m15s) and on the first head of this PR, so it is inherited rather than caused by these four records.This PR is separate from the consumer doc PR (#5234) because it touches the driver manifest and both skill seeds.
architecture-map: unaffected
🤖 Generated with Claude Code