made a couple of rumble patterns - #149
Open
BrodyKarr wants to merge 4 commits into
Open
Conversation
Wu-Fan-529
reviewed
May 30, 2026
Wu-Fan-529
left a comment
Wu-Fan-529
left a comment
Member
There was a problem hiding this comment.
slectedRumble will always be "steady", you probably want a parameter
Wu-Fan-529
reviewed
May 30, 2026
Wu-Fan-529
reviewed
May 30, 2026
| this.intensity = intensity; | ||
| } | ||
|
|
||
| public static RumblePatterns getRumblePattern(RumbleType rumbleType, double rumbleIntensity) { |
Member
There was a problem hiding this comment.
you should not pass in rumble type and rumble intensity, but only selected rumble. rumble type and rumble intensity can just use the varibles in the class
Wu-Fan-529
reviewed
May 30, 2026
Wu-Fan-529
reviewed
May 30, 2026
| import edu.wpi.first.wpilibj.Timer; | ||
|
|
||
| /** Add your docs here. */ | ||
| public class RumblePatterns { |
Member
There was a problem hiding this comment.
this class by itself is not that useful, especially when wpilib setRumble only takes RumbleType and double. you will need to cerate a function, or make rumble patterns extends from wpilib stuff and over write the function
Member
|
Create new classes extending RumblePattern and in SN_XboxController create new setRumble that take a rumble pattern |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.