changed the naming architypes - #109
Conversation
There was a problem hiding this comment.
Pull request overview
This PR renames several subsystem- and constants-related “archetype” classes to new names and updates RobotContainer and DeviceIDs accordingly so references remain consistent across the robot project.
Changes:
- Renamed subsystem classes
Motion→PositionalComponentsandRotors→FreeSpinComponents, and updatedRobotContainerimports/instances. - Renamed
DeviceIDsnested classesrotorIDs/motionIDs→freeSpinIDs/positionalIDs. - Renamed constants classes
ConstRotors→ConstPositionalandConstMotion→ConstFreeSpin.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/frc/robot/subsystems/PositionalComponents.java | Renames the subsystem class/constructor to PositionalComponents. |
| src/main/java/frc/robot/subsystems/FreeSpinComponents.java | Renames the subsystem class/constructor to FreeSpinComponents. |
| src/main/java/frc/robot/RobotContainer.java | Updates imports and singleton instances to use the renamed subsystems. |
| src/main/java/frc/robot/DeviceIDs.java | Renames ID group nested classes and updates related comments. |
| src/main/java/frc/robot/constants/ConstPositional.java | Renames the constants class to match the file/name pattern. |
| src/main/java/frc/robot/constants/ConstFreeSpin.java | Renames the constants class to match the file/name pattern. |
Comments suppressed due to low confidence (2)
src/main/java/frc/robot/subsystems/FreeSpinComponents.java:12
- Constructor Javadoc still refers to the old class name (“Rotors”), which makes the generated docs misleading after the rename.
src/main/java/frc/robot/subsystems/PositionalComponents.java:12 - Constructor Javadoc doesn’t match the renamed class name; it currently says “Positional”, which can be confusing when searching generated docs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
src/main/java/frc/robot/subsystems/FreeSpin.java:12
- Javadoc still says "Creates a new Rotors" after the class/constructor rename, which is misleading when generating docs or searching by name.
src/main/java/frc/robot/DeviceIDs.java:39 - This comment says "FreeSpin and Positional IDs: 10~29" but the following inner class is named freeSpinIDs only; Positional IDs are defined separately below. This reads like overlapping/duplicated ID ranges.
// FreeSpin and Positional IDs: 10~29
Co-authored-by: Tayler Uva <8679670+TaylerUva@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
src/main/java/frc/robot/DeviceIDs.java:39
- The range comment says "FreeSpin and Positional IDs: 10
29", but the only ID bucket in this range is49 below. This comment is misleading and should match the actual buckets/ranges.freeSpinIDs;positionalIDsis declared for 30
// FreeSpin and Positional IDs: 10~29
Co-authored-by: Tayler Uva <8679670+TaylerUva@users.noreply.github.com>
No description provided.