Skip to content

changed the naming architypes - #109

Merged
BrodyKarr merged 5 commits into
mainfrom
change-to-clearer-architecture
Jul 19, 2026
Merged

changed the naming architypes#109
BrodyKarr merged 5 commits into
mainfrom
change-to-clearer-architecture

Conversation

@BrodyKarr

Copy link
Copy Markdown
Contributor

No description provided.

@BrodyKarr
BrodyKarr requested a review from a team as a code owner July 18, 2026 03:48
@BrodyKarr BrodyKarr linked an issue Jul 18, 2026 that may be closed by this pull request

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR renames several subsystem- and constants-related “archetype” classes to new names and updates RobotContainer and DeviceIDs accordingly so references remain consistent across the robot project.

Changes:

  • Renamed subsystem classes MotionPositionalComponents and RotorsFreeSpinComponents, and updated RobotContainer imports/instances.
  • Renamed DeviceIDs nested classes rotorIDs/motionIDsfreeSpinIDs/positionalIDs.
  • Renamed constants classes ConstRotorsConstPositional and ConstMotionConstFreeSpin.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/main/java/frc/robot/subsystems/PositionalComponents.java Renames the subsystem class/constructor to PositionalComponents.
src/main/java/frc/robot/subsystems/FreeSpinComponents.java Renames the subsystem class/constructor to FreeSpinComponents.
src/main/java/frc/robot/RobotContainer.java Updates imports and singleton instances to use the renamed subsystems.
src/main/java/frc/robot/DeviceIDs.java Renames ID group nested classes and updates related comments.
src/main/java/frc/robot/constants/ConstPositional.java Renames the constants class to match the file/name pattern.
src/main/java/frc/robot/constants/ConstFreeSpin.java Renames the constants class to match the file/name pattern.
Comments suppressed due to low confidence (2)

src/main/java/frc/robot/subsystems/FreeSpinComponents.java:12

  • Constructor Javadoc still refers to the old class name (“Rotors”), which makes the generated docs misleading after the rename.
    src/main/java/frc/robot/subsystems/PositionalComponents.java:12
  • Constructor Javadoc doesn’t match the renamed class name; it currently says “Positional”, which can be confusing when searching generated docs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/main/java/frc/robot/DeviceIDs.java Outdated

@TaylerUva TaylerUva left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apply pattern elsewhere

Comment thread src/main/java/frc/robot/DeviceIDs.java Outdated
Comment thread src/main/java/frc/robot/DeviceIDs.java Outdated
Comment thread src/main/java/frc/robot/subsystems/FreeSpinComponents.java Outdated
Comment thread src/main/java/frc/robot/subsystems/Positional.java Outdated
Comment thread src/main/java/frc/robot/subsystems/FreeSpin.java Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

src/main/java/frc/robot/subsystems/FreeSpin.java:12

  • Javadoc still says "Creates a new Rotors" after the class/constructor rename, which is misleading when generating docs or searching by name.
    src/main/java/frc/robot/DeviceIDs.java:39
  • This comment says "FreeSpin and Positional IDs: 10~29" but the following inner class is named freeSpinIDs only; Positional IDs are defined separately below. This reads like overlapping/duplicated ID ranges.
  // FreeSpin and Positional IDs: 10~29

Co-authored-by: Tayler Uva <8679670+TaylerUva@users.noreply.github.com>
Comment thread src/main/java/frc/robot/DeviceIDs.java Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

src/main/java/frc/robot/DeviceIDs.java:39

  • The range comment says "FreeSpin and Positional IDs: 1029", but the only ID bucket in this range is freeSpinIDs; positionalIDs is declared for 3049 below. This comment is misleading and should match the actual buckets/ranges.
  // FreeSpin and Positional IDs: 10~29

Co-authored-by: Tayler Uva <8679670+TaylerUva@users.noreply.github.com>
@BrodyKarr
BrodyKarr merged commit dcdc454 into main Jul 19, 2026
1 check passed
@BrodyKarr
BrodyKarr deleted the change-to-clearer-architecture branch July 19, 2026 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Decide on architecture

4 participants