Added all neccessary TODOS in each file - #108
Merged
Merged
Conversation
Co-Authored-By: Yutong Zhu <yutong59202@gmail.com> Co-Authored-By: Justinpham17386769 <244249272+Justinpham17386769@users.noreply.github.com>
Co-Authored-By: Yutong Zhu <yutong59202@gmail.com> Co-Authored-By: Justinpham17386769 <244249272+Justinpham17386769@users.noreply.github.com>
Co-Authored-By: Yutong Zhu <yutong59202@gmail.com> Co-Authored-By: Justinpham17386769 <244249272+Justinpham17386769@users.noreply.github.com>
TaylerUva
approved these changes
Jul 18, 2026
TaylerUva
enabled auto-merge (squash)
July 18, 2026 03:08
TaylerUva
requested changes
Jul 18, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates robot configuration constants to better mark placeholders that need real-world calibration, and adjusts practice-bot detection to use the roboRIO serial number constant.
Changes:
- Renames the practice-bot identifier constant and updates
RobotContainer.isPracticeBot()to use the serial-number constant. - Adds TODO markers in vision, drivetrain, and field constants to flag values that need confirmation/tuning/measurement.
- Adds a robot-to-bumper
Transform3dconstant (currently placeholder) inConstSystem.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/frc/robot/RobotContainer.java | Updates practice-bot detection to reference the renamed serial-number constant. |
| src/main/java/frc/robot/constants/ConstVision.java | Adds TODO notes indicating Limelight names/measurements need confirmation. |
| src/main/java/frc/robot/constants/ConstSystem.java | Renames practice-bot constant and introduces a placeholder robot-to-bumper transform. |
| src/main/java/frc/robot/constants/ConstField.java | Adds TODO note for the reset pose placeholder measurement. |
| src/main/java/frc/robot/constants/ConstDrivetrain.java | Adds TODO notes for gear ratios, measurements, and PID placeholders. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TaylerUva
approved these changes
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.