Add Copilot PR review instructions for FRC robot code

[Copilot]

All PRs lacked FRC-aware review context, leaving Copilot unable to enforce team standards like the state machine architecture, FreeSpin/Positional motor subsystem split, constants discipline, and naming conventions from the team wiki.

Changes

• .github/copilot-instructions.md — Global baseline applied to every PR:

  • State machine rules: one RobotState enum, gerund state names (INTAKING not INTAKE), setRobotState() must be first in initialize()
  • Motor architecture: FreeSpin.java = velocity-controlled, Positional.java = position-controlled; no cross-contamination
  • Hardcoded number flagging: any numeric literal outside constants/ or DeviceIDs.java is a violation
  • Follower motor naming: ...FollowerAlignedRequest/...FollowerOpposedRequest, no compass directions in request object names
  • WPILib typed units everywhere (AngularVelocity, Angle, Distance); never raw double for physical quantities
  • @Logged required on every subsystem; wildcard imports preferred

• .github/instructions/*.instructions.md — Path-scoped instructions activated via applyTo front-matter:

File	Scope	Key additions
constants.instructions.md	constants/**	Every TalonFX needs a _CONFIGURATION constant; all setup in static {} block
states.instructions.md	commands/states/**	setRobotState() first rule; BasePreps command/input variable prefix pattern
subsystems.instructions.md	subsystems/**	FreeSpin/Positional split enforcement; follower request naming; periodic() must be lightweight
commands.instructions.md	commands/**	No hardware instantiation in commands; ChoreoTraj constants not raw strings; end() cleanup
deviceids.instructions.md	DeviceIDs.java	CAN ID range comments (0–9, 10–29, 30–49); one constant per motor; no subsystem name repetition
robotcontainer.instructions.md	RobotContainer.java	public static final *Instance + private final logged*Instance pair; TRY_ prefix for state commands; bindings in separate config*Bindings() methods

• Fixes Create co-pilot PR review instructions #55

[Copilot]

Pull request overview

Adds GitHub Copilot review/coding instruction documents tailored to this FRC WPILib command-based robot codebase, so automated PR feedback can consistently enforce the team’s state machine architecture, subsystem split, constants discipline, and naming conventions.

Changes:

• Introduces a repository-wide baseline in .github/copilot-instructions.md covering architecture, naming, constants/units, and logging conventions.
• Adds path-scoped instruction files under .github/instructions/ to enforce tighter rules in key areas (subsystems, state commands, constants, DeviceIDs, RobotContainer, and commands).

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
.github/instructions/subsystems.instructions.md	Adds subsystem-specific architecture and logging rules (FreeSpin/Positional split, follower request naming, constructor/config rules).
.github/instructions/states.instructions.md	Adds strict state-command structure rules (1 command/state, setRobotState() first in initialize(), no numeric literals).
.github/instructions/robotcontainer.instructions.md	Defines RobotContainer composition/binding conventions and state transition command patterns.
.github/instructions/deviceids.instructions.md	Defines DeviceIDs structure, naming, and CAN ID range documentation requirements.
.github/instructions/constants.instructions.md	Defines constants-file structure, typed-units expectations, and TalonFX configuration requirements.
.github/instructions/commands.instructions.md	Adds general command rules around requirements, inputs, constants discipline, and safe cleanup in end().
.github/copilot-instructions.md	Adds the global baseline conventions and review expectations for the whole repo.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.