5-intaking-functional - #7
Merged
Merged
Conversation
i made the intake pivot deploy
Closed
…ting and intaking on the controller. Co-Authored-By: Tej shah <187054380+Tejshah88@users.noreply.github.com> Co-Authored-By: lameesnotlame <258483139+lameesnotlame@users.noreply.github.com>
Contributor
|
looks good👍 |
added intake rollers
AngelaKimmy
reviewed
May 23, 2026
| public static final TalonFXConfiguration HOOD_PIVOT_CONFIGURATION = new TalonFXConfiguration(); | ||
| public static final Angle INTAKE_PIVOT_DEPLOY = Degrees.of(90); | ||
| // jayden in the future make a intake retract/ | ||
| public static final Angle RETRACT_PIVOT_DEPLOY = Degrees.of(-90); |
Contributor
There was a problem hiding this comment.
This name is confusing? What is pivoting? Is it retracting or deploying?
Fixxed naming issue to be less confusing
moved up code
AngelaKimmy
reviewed
May 24, 2026
| public static final TalonFXConfiguration TRANSFER_ROLLERS_WEST_CONFIGURATION = new TalonFXConfiguration(); | ||
| public static final TalonFXConfiguration FLYWHEEL_EAST_CONFIGURATION = new TalonFXConfiguration(); | ||
| public static final TalonFXConfiguration FLYWHEEL_WEST_CONFIGURATION = new TalonFXConfiguration(); | ||
| public static final AngularVelocity INTAKE_ROLLERS_INTAKING = Units.RPM.of(4000); |
Contributor
There was a problem hiding this comment.
This name does not represent what type of value this is. Is it for an angle? For speed?
AngelaKimmy
reviewed
May 24, 2026
| public static final TalonFXConfiguration INTAKE_PIVOT_CONFIGURATION = new TalonFXConfiguration(); | ||
| public static final TalonFXConfiguration HOOD_PIVOT_CONFIGURATION = new TalonFXConfiguration(); | ||
| public static final Angle INTAKE_PIVOT_DEPLOY = Degrees.of(90); | ||
| // justin in the future make a intake retract/ |
Contributor
There was a problem hiding this comment.
We should update these values to match robot values
public static final Angle DEPLOY_INTAKE_PIVOT_ANGLE = Units.Degrees.of(125); public static final Angle RETRACT_INTAKE_PIVOT_ANGLE = Units.Degrees.of(0);
BrodyKarr
reviewed
May 24, 2026
| public static final TalonFXConfiguration TRANSFER_ROLLERS_WEST_CONFIGURATION = new TalonFXConfiguration(); | ||
| public static final TalonFXConfiguration FLYWHEEL_EAST_CONFIGURATION = new TalonFXConfiguration(); | ||
| public static final TalonFXConfiguration FLYWHEEL_WEST_CONFIGURATION = new TalonFXConfiguration(); | ||
| public static final AngularVelocity INTAKE_ROLLERS_SPEED = Units.RPM.of(4000); |
Contributor
There was a problem hiding this comment.
lets keep the value at 0-4, setting it to 4000 will still make it go to its max(4) but, lets keep it to the lower values to keep clarity
AngelaKimmy
approved these changes
May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i made the intake pivot deploy