Skip to content

Refactor rotor subsystem to clarify leader and follower roles for motors (*゜ー゜*) - #69

Merged
AngelaKimmy merged 5 commits into
mainfrom
tuva/transfer_fix
Jun 14, 2026
Merged

Refactor rotor subsystem to clarify leader and follower roles for motors (*゜ー゜*)#69
AngelaKimmy merged 5 commits into
mainfrom
tuva/transfer_fix

Conversation

@Wu-Fan-529

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings June 14, 2026 01:23
@Wu-Fan-529
Wu-Fan-529 requested a review from a team as a code owner June 14, 2026 01:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the Rotors subsystem to make TalonFX motor leader/follower roles explicit (via renames and dedicated Follower control requests) and updates control methods to use those roles consistently.

Changes:

  • Renamed several TalonFX members to explicitly indicate Leader vs Follower.
  • Introduced named Follower control requests for flywheel, transfer, and intake follower motors.
  • Updated rotor control methods to command leaders directly and apply follower requests where appropriate.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/main/java/frc/robot/subsystems/Rotors.java
Comment thread src/main/java/frc/robot/subsystems/Rotors.java
Copilot AI review requested due to automatic review settings June 14, 2026 02:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread src/main/java/frc/robot/subsystems/Rotors.java
@AngelaKimmy
AngelaKimmy merged commit c53ca25 into main Jun 14, 2026
2 checks passed
@AngelaKimmy
AngelaKimmy deleted the tuva/transfer_fix branch June 14, 2026 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants