add eject hopper logic - #41
Merged
FRCTeam3255-Shared-K1-10 merged 10 commits intoMay 30, 2026
Merged
Conversation
Co-Authored-By: lameesnotlame <258483139+lameesnotlame@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fleshes out the previously-empty EjectingHopper command so that it deploys the intake pivot and runs the intake, serializer, and transfer rollers in reverse to eject game pieces, adding the corresponding negative percent-output constants in ConstRotors. A robot.tldr whiteboard file is also modified, but only with incidental editor-state churn.
Changes:
- Added three
REVERSE_*percent-output constants (-0.5) for intake, serializer, and transfer rollers. - Implemented
EjectingHopper.initialize(),execute(), andend()to deploy the intake and drive the three rollers in reverse, stopping them on end. - Unrelated tldraw editor-state diff in
robot.tldr(camera/zoom/selection/screen-bounds/user entry).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/main/java/frc/robot/constants/ConstRotors.java | Adds reverse-speed constants for the intake, serializer, and transfer rollers. |
| src/main/java/frc/robot/commands/states/EjectingHopper.java | Implements the eject behavior using the new constants; deploys intake pivot and stops rollers on end. |
| robot.tldr | Incidental tldraw UI/editor-state changes unrelated to the feature. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: lameesnotlame <258483139+lameesnotlame@users.noreply.github.com>
TaylerUva
requested changes
May 30, 2026
TaylerUva
left a comment
TaylerUva
left a comment
Member
There was a problem hiding this comment.
Remember to addRequirements() and add the statemachine
and remember to setRobotState
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-Authored-By: lameesnotlame <258483139+lameesnotlame@users.noreply.github.com>
…b.com/FRCTeam3255/2026_CopyBot_Code into 34-add-logic-for-state-ejectinghopper
Co-Authored-By: lameesnotlame <258483139+lameesnotlame@users.noreply.github.com>
Co-Authored-By: jayden mendoza <244560677+jaymendo670-png@users.noreply.github.com>
FRCTeam3255-Shared-K1-10
changed the title
FRCTeam3255-Shared-K1-10
changed the title
…b.com/FRCTeam3255/2026_CopyBot_Code into 34-add-logic-for-state-ejectinghopper
TaylerUva
approved these changes
May 30, 2026
FRCTeam3255-Shared-K1-10
enabled auto-merge (squash)
May 30, 2026 22:30
… into 34-add-logic-for-state-ejectinghopper
TaylerUva
approved these changes
May 30, 2026
FRCTeam3255-Shared-K1-10
deleted the
34-add-logic-for-state-ejectinghopper
branch
May 30, 2026 22:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.