1 create motion subsystem - #4
Merged
Merged
Conversation
added motor count made all setter and getter functions set IDs
i added comments
Closed
4 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new Motion subsystem for controlling intake and hood pivot TalonFX motors, and wires it into the robot container with device IDs and placeholder constants.
Changes:
- Adds a
Motionsubsystem with TalonFX pivot control, angle setters/getters, and at-angle checks. - Registers the subsystem in
RobotContainerfor logging/access. - Adds CAN IDs and TalonFX configuration constants for the motion hardware.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/main/java/frc/robot/subsystems/Motion.java |
Implements the new motion subsystem for intake and hood pivots. |
src/main/java/frc/robot/RobotContainer.java |
Instantiates and logs the new motion subsystem. |
src/main/java/frc/robot/DeviceIDs.java |
Adds CAN IDs for hood and intake pivot motors. |
src/main/java/frc/robot/constants/ConstMotion.java |
Adds TalonFX configuration objects for the new motion motors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TaylerUva
requested changes
May 23, 2026
fixed mistakes
fixed mistake
AngelaKimmy
approved these changes
May 23, 2026
Contributor
|
It looks like the build is failing, I recommend trying to build locally to troubleshoot |
fixed words
TaylerUva
approved these changes
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.