Skip to content

further finalize debug_mode removal #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nmschulte wants to merge 5 commits into
base: master
Choose a base branch
from
Open

further finalize debug_mode removal #738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
66b1bc9
fw: remove comments re: debug_mode
nmschulte Mar 19, 2026
6b4a42e
TS ini: remove debug_mode dialog texts
nmschulte Mar 19, 2026
6800dd4
console: TODO re: debug_mode: DBG_LOGIC_ANALYZER
nmschulte Mar 19, 2026
2846aec
TS ini: tidy indentation
nmschulte Mar 19, 2026
867fec8
Merge branch 'master' into nms/rm-debug-mode
mck1117 Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion firmware/config/engines/mazda_miata_vvt.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,6 @@ void setMazdaMiata2003EngineConfiguration() {
// set idle_p 0.05
// set idle_i 0
// set idle_d 0
// set debug_mode 3
// set idle_rpm 1700
// see setDefaultIdleParameters

Expand Down
3 changes: 0 additions & 3 deletions firmware/controllers/actuators/electronic_throttle.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,6 @@
* set mock_pedal_position X
*
*
* set debug_mode 17
* for PID outputs
*
* set_etb_duty X
*
* http://rusefi.com/forum/viewtopic.php?f=5&t=592
Expand Down
2 changes: 0 additions & 2 deletions firmware/controllers/can/can_bmw.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
*
* All the below packets are using 500kb/s
*
* for verbose use "set debug_mode 26" command in console
*
*/
#define CAN_BMW_E46_SPEED 0x153
#define CAN_BMW_E46_RPM 0x316
Expand Down
2 changes: 0 additions & 2 deletions firmware/controllers/can/can_rx.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,6 @@ static void printPacket(CanBusIndex busIndex, const CANRxFrame& rx) {
// return;
// }

// only print info if we're in can debug mode

int id = CAN_ID(rx);

// internet people use both hex and decimal to discuss packed IDs, for usability it's better to print both right
Expand Down
5 changes: 1 addition & 4 deletions firmware/tunerstudio/tunerstudio.template.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3512,8 +3512,6 @@ dialog = launch_control_stateDialog, "launch_control_state"
field = ""
field = "Min adjustment (retard)", idleTimingPid_minValue, {useIdleTimingPidControl}
field = "Max adjustment (advance)", idleTimingPid_maxValue, {useIdleTimingPidControl}
field = ""
field = "#Use debug mode 'Timing' to view idle timing adjustment"

; Engine->Fan Settings
dialog = fan1Settings, "Fan 1"
Expand Down Expand Up @@ -4117,8 +4115,7 @@ dialog = launch_control_stateDialog, "launch_control_state"
panel = crankingAdv

dialog = TpsAccelPanel, "TPS"
field = "Set 'Debug Mode' to see detailed 'TPS acceleration enrichment' diagnostics"
field = "Length", tpsAccelLookback
field = "Length", tpsAccelLookback
field = "Accel Threshold", tpsAccelEnrichmentThreshold
field = "Decel Threshold", tpsDecelEnleanmentThreshold
; field = "Decel Multiplier", tpsDecelEnleanmentMultiplier
Expand Down
1 change: 1 addition & 0 deletions java_console/autotest/src/main/java/com/rusefi/f4discovery/PwmHardwareTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ public void scheduleBurnDoesNotAffectTriggerIssue2839() {
assertEquals("totalTriggerErrorCounter", triggerErrors, totalTriggerErrorsNow);
}

// TODO:: unignore; https://github.com/FOME-Tech/fome-fw/issues/731 (re-enable VssHardwareLoopTest, ...)

@mck1117 mck1117 May 1, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we make unrelated changes in the same pr

@nmschulte nmschulte May 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, it is related by line ~78 of the test, which is why it is @Ignore'd -- added the comment/issue ref. to clarify things; perhaps the unignore; is redundant

@Ignore
@Test
public void testIdlePin() {
Expand Down
Loading