Conversation
…rchipelagoMW#5967) When CasualBounties was enabled, the location names in `exclusion_table["HitlistCasual"]` would be iterated into `self.random_super_boss_list` in `generate_early`, but `exclusion_table["HitlistCasual"]` was a `set`, so its iteration order would vary on each generation, even with same seed. Random location names would be picked from `self.random_super_boss_list` to place Bounty items at, so different locations could be picked on each generation with the same seed. `exclusion_table["Hitlist"]` is similar and was already a `list`, avoiding the issue of nondeterministic iteration order, so `exclusion_table["HitlistCasual"]` has been changed to a `list` to match.
…oMW#5842) * Change timeout and add timeout-specific message * Revert open_timeout
…W#6033) * WebHost: make autolauncher max room timeout configurable * WebHost: launch rooms with assigned port first
…cted recipe needs fluids (ArchipelagoMW#5412)
Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com> Co-authored-by: Emily <35015090+EmilyV99@users.noreply.github.com>
…W#6074) ... next time it gets written to. This makes loading peristent_storage faster in the future.
…ipelagoMW#5684) * Make component launching indicate if no terminal window, add konsole * Attempt to spell better and remove whitespace * Update terminal priority * Make helper for clearing LD_LIBRARY_PATH * Add handling to linux launch * Hopefully fix setter * Apply suggestions from code review Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com> --------- Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com>
…elagoMW#6040) The include_songs option is an OptionSet, whose value is a set, but was being iterated to produce self.included_songs. Sets are unordered and may have a different iteration order each time a python process is run. This meant that the order of the elements in self.included_songs could differ even when generating with a fixed seed. This caused nondeterministic generation with the same seed because create_song_pool() deterministically randomly picks songs from self.included_songs, which could be in a different order each time, so different songs could be picked.
* - Fixed the Dr Seuss Bundle asking for tigerseye (mineral) instead of tiger trout (fish) * - Made blue grass starter more consistent * - Fragments of the past does not rely on ginger island * - Removed legacy hard coded strange bun recipe that messed with chefsanity logic
…elagoMW#6034) The current logic only requires the shorts and a sewing machine, but a gold bar is also necessary
…s could create more items than locations (ArchipelagoMW#6012) * - Improved the dynamic locations count algorithm to take into account the nature of various heavy settings in both directions * - Fixes from Code Review * - We're only testing for sunday locations, might as well only take sunday locations in the list to test * - One more slight optimization * - Added consideration for bundles per room in filler locations counting * - Registered some more IDs to handle items up to 10
Solved indentation error to return to intended functionality
…chipelagoMW#5999) * Remove space before comma * Factorio authors update * Simplify template
* Import Buffer from typing_extensions instead of collections.abc for 3.11 compat * always re-set sound volumes before playing * fix game window scaling if parent is vertical * make default volume lower
…ipelagoMW#6073) * CI: reduce default permissions to minimum * CI: update pin actions Most of them. CodeQL and action-gh-release is untouched for now. Immutable actions and actions/* are pinned to version, other actions are pinned to hash. * CI: make use of archive: false in upload-artifact also set compression level and error behavior for scan-build upload. * CI: update codeql and enable scanning actions
…uired when the box is rotated (ArchipelagoMW#5889) * Unbeatable seed: 11 lasers + redirect when the box is rotated * naming
* Tap to move * inputs * cleanup * oops
Merged
Omnises
approved these changes
Apr 1, 2026
Omnises
pushed a commit
that referenced
this pull request
Apr 1, 2026
* Jak and Daxter: Replace Pymem, Add Linux Support (#5850) * Replace pymem with PyMemoryEditor (nonworking) * Add back pymem for faster windows address searching. * Replace other uses of pymem, parameterize executable names. * Updated to add linux and potential MacOS support to launching gk and … (#84) * Updated to add linux and potential MacOS support to launching gk and goalc. Still needs tested on MacOS. * Switched to using x-terminal-emulator instead of trying to find gnome-terminal or konsole Made argument building for suprocessing goalc easier to read Fixed OS X support to use osascript instead of attempting to run Terminal directly * Changed Terminal usage to use Archipelago's Launh utility, which handles terminal launching for me for both linux and OS X * Added try/except to re-connect the memory process. The process file/id changes over time on linux, and this works to re-connect without needing to restart * Removed Unsetting env var in favor of reporting to the source authors * Putting PyMemoryEditor local. (#85) * Putting PyMemoryEditor local --------- Co-authored-by: massimilianodelliubaldini <8584296+massimilianodelliubaldini@users.noreply.github.com> * Fixing minor problems (#87) * Refactor away circular launcher import. * Push latest PyMemoryEditor scan utility (#91) Co-authored-by: Louis M <Louis M> * Remove Pymem, rely solely on PyMemoryEditor. Add konsole support. * Jak 1: Remove vendored copy of PME, update imports, requirements, and manifest. * Jak 1: Prevent server connect until game is properly setup. * Jak 1: reduce REPL/Compiler confusion, small updates to setup guide. * Write hack for Konsole on AppImage to avoid OpenSSL error. * Refactor LD_LIBRARY_PATH hack. * Update worlds/jakanddaxter/agents/memory_reader.py Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com> * Update worlds/jakanddaxter/agents/memory_reader.py Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com> --------- Co-authored-by: Morgan <morgan07kelley@gmail.com> Co-authored-by: Louis M <prog@tioui.com> Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com> * Docs: add spanish language for MLSS (#5172) * Docs: add spanish language for SM64 * Docs: add spanish language for MLSS * Update worlds/mlss/docs/setup_es.md Co-authored-by: PantoUwUr <99690102+PantoUwUr@users.noreply.github.com> * Update worlds/mlss/docs/es_Mario & Luigi Superstar Saga.md Co-authored-by: RoobyRoo <thegreenrobby@gmail.com> --------- Co-authored-by: PantoUwUr <99690102+PantoUwUr@users.noreply.github.com> Co-authored-by: RoobyRoo <thegreenrobby@gmail.com> * Docs, SM64: Remove outdated FAQ item (#5887) It is no longer possible to connect to a multiworld game on a version of the client with this bug, as all versions with this bug report AP v0.3.5 or less * TWW: Support launcher command line arguments (#5806) * Support launcher command line arguments * Use `launch` instead of `launch_subprocess` * Remove old runner code * Satisfactory: Update Universal Tracker Method for FinalElevatorPhase Option (#5812) * MLSS: Add Manifest + Minor Bugfixes (#5728) * Remove outdated header change for ROM verification * Update Connections to be compatible with python ver. 3.8 * Update inno_setup.iss * Update inno_setup.iss * Merge branch 'main' of https://github.com/jamesbrq/ArchipelagoMainMLSS * Add Manifest + Minor Bugfixes * Even further safeguards for Oho Oasis Temples * Update basepatch.bsdiff * KH2: Add a new "CasualBounties" Setting (#4877) * KH2: casual bounties option * Casual Bounty: Adjust level bounty logic to correspond with max level check setting * Bugfix: We have one less possible bounty with corresponding level bounty logic * Casual Bounty: Move option to better spot * Bugfix: Prevent possible .remove() crash * Revert "Bugfix: We have one less possible bounty with corresponding level bounty logic" This reverts commit 3c929e00db910a176d9d882b6cc08494417177d2. * Bugfix: Typo in conditional * Casual Bounties: Remove Scar, add MCP I knew I was missing one second visit fight and Scar shouldn't be there he's a first visit * Casual Bounties: Add some clarity to the CasualBounty setting * Docs: Update docs to reflect new CasualBounty setting * KH2: Add bounty locations as location groups Feedback on this needed, trying to do this to make it work with the code above the additions made it so the game generated 1 less item than locations, despite linking properly It does function as intended though * KH2: Update docs * KH2: Add SuperBosses, Cups, AtlanticaToggle and SummonLevelLocationToggle to slot data (#5708) * Add SuperBosses, Cups and AtlanticaToggle * Add SummonLevelLocationToggle * Core: Add SDL_MOUSE_FOCUS_CLICKTHROUGH=1 environment variable to kvui (#5804) This variable should fix the 'double click' required when trying to interact with buttons on an unfocused window * SC2: Bump protobuf from 6.31.1 to 6.33.5 in /worlds/_sc2common (#5890) Bumps [protobuf](https://github.com/protocolbuffers/protobuf) from 6.31.1 to 6.33.5. - [Release notes](https://github.com/protocolbuffers/protobuf/releases) - [Commits](https://github.com/protocolbuffers/protobuf/commits) --- updated-dependencies: - dependency-name: protobuf dependency-version: 6.33.5 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Core, Tests: allow Archipelago items in all worlds (#5893) * Core: Add rule builder (#5048) * initial commit of rules engine * implement most of the stuff * add docs and fill out rest of the functionality * add in explain functions * dedupe items and add more docs * pr feedback and optimization updates * Self is not in typing on 3.10 * fix test * Update docs/rule builder.md Co-authored-by: BadMagic100 <dempsey.sean@outlook.com> * pr feedback * love it when CI gives me different results than local * add composition with bitwise and and or * strongly typed option filtering * skip resolving location parent region * update docs * update typing and add decorator * add string explains * move simplify code to world * add wrapper rule * I may need to abandon the generic typing * missing space for faris * fix hashing for resolved rules * thank u typing extensions ilu * remove bad cacheable check * add decorator to assign hash and rule name * more type crimes... * region access rules are now cached * break compatibility so new features work * update docs * replace decorators with __init_subclass__ * ok now the frozen dataclass is automatic * one more type fix for the road * small fixes and caching tests * play nicer with tests * ok actually fix the tests * add item_mapping for faris * add more state helpers as rules * fix has from list rules * fix can reach location caching and add set completion condition * fix can reach entrance caching * implement HasGroup and HasGroupUnique * add more tests and fix some bugs * Add name arg to create_entrance Co-authored-by: roseasromeo <11944660+roseasromeo@users.noreply.github.com> * fix json dumping option filters * restructure and test serialization * add prop to disable caching * switch to __call__ and revert access_rule changes * update docs and make edge cases match * ruff has lured me into a false sense of security * also unused * fix disabling caching * move filter function to filter class * add more docs * tests for explain functions * Update docs/rule builder.md Co-authored-by: roseasromeo <11944660+roseasromeo@users.noreply.github.com> * chore: Strip out uses of TYPE_CHECKING as much as possible * chore: add empty webworld for test * chore: optimize rule evaluations * remove getattr from hot code paths * testing new cache flags * only clear cache for rules cached as false in collect * update test for new behaviour * do not have rules inherit from each other * update docs on caching * fix name of attribute * make explain messages more colorful * fix issue with combining rules with different options * add convenience functions for filtering * use an operator with higher precedence * name conflicts less with optionfilter * move simplify and instance caching code * update docs * kill resolve_rule * kill true_rule and false_rule * move helpers to base classes * update docs * I really should finish all of my * fix test * rename mixin * fix typos * refactor rule builder into folder for better imports * update docs * do not dupe collectionrule * docs review feedback * missed a file * remove rule_caching_enabled from base World * update docs on caching * shuffle around some docs * use option instead of option.value * add in operator and more testing * rm World = object * test fixes * move cache to logic mixin * keep test rule builder world out of global registry * todone * call register_dependencies automatically * move register deps call to call_single * add filtered_resolution * allow bool opts on filters * fix serialization tests * allow reverse operations --------- Co-authored-by: BadMagic100 <dempsey.sean@outlook.com> Co-authored-by: roseasromeo <11944660+roseasromeo@users.noreply.github.com> * Core: Throw OptionError for option type Toggle in certain scenarios (#5874) * Throw OptionError for option type Toggle in certain scenarios * Adding missing space to Options.py Co-authored-by: Katelyn Gigante <clockwork.singularity@gmail.com> --------- Co-authored-by: Katelyn Gigante <clockwork.singularity@gmail.com> * Utils: Improvements to visualize_regions for debugging GER usage (#4685) * Improvements to visualize_regions for debugging GER usage - allow the user to pass in a dict[int, int] to visualize_regions that maps Entrance.randomization_group to a color in RGB form. This allows for better visualization of which dangling entrances should match, or which matching groups are not being correctly respected. - do full region visualization for unreached regions, so that entrances that could connect to new regions can be visualized. - visualize unconnected entrances on regions, in addition to connected and unconnected exits, so that available ER targets can be visualized as well * Add detail_disconnected_regions parameter to visualize_regions * Rename detail_disconnected_regions to detail_other_regions for consistency * Add auto_assign_colors param to visualize_regions * Make auto assignment of entrance colors deterministic * Assume show_other_regions is true if detail_other_regions is true * Remove unused random import * whitespace adjustments * Move overflow check to prevent potential infinite loop It wasn't exactly likely, as the user would have had to manually define all 4096 colors and then need an additional color on top of that, but accounting for that kind of nonsense is easy enough in this case. * positive condition --------- Co-authored-by: CodeGorilla <3672561+Ars-Ignis@users.noreply.github.com> * APQuest: Improve the auto-generated .gitignore for data/sounds (#5670) I didn't quite think this through: In this specific case, you want the gitignore to also ignore itself, since it itself is an auto-generated file. * Webhost: Fix defaults for NamedRange and TextChoice (#5139) * TUNIC: Depriority for some items (#5589) * Stardew Valley: 7.x.x - The Jojapocalypse Update (#5432) Major Content update for Stardew Valley ### Features - New BundleRandomization Value: Meme Bundles - Over 100 custom bundles, designed to be jokes, references, trolls, etc - New Setting: Bundles Per Room modifier - New Setting: Backpack Size - New Setting: Secretsanity - Checks for triggering easter eggs and secrets - New Setting: Moviesanity - Checks for watching movies and sharing snacks with Villagers - New Setting: Eatsanity - Checks for eating items - New Setting: Hatsanity - Checks for wearing Hats - New Setting: Start Without - Allows you to select any combination of various "starting" items, that you will actually not start with. Notably, tools, backpack slots, Day5 unlocks, etc. - New Setting: Allowed Filler Items - Allows you to customize the filler items you'll get - New Setting: Endgame Locations - Checks for various expensive endgame tasks and purchases - New Shipsanity value: Crops and Fish - New Settings: Jojapocalypse and settings to customize it - Bundle Plando: Replaced with BundleWhitelist and BundleBlacklist, for more customization freedom - Added a couple of Host.yaml settings to help hosts allow or ban specific difficult settings that could cause problems if the people don't know what they are signing up for. Plus a truckload of improvements on the mod side, not seen in this PR. ### Removed features - Integration for Stardew Valley Expanded. It is simply disabled, the code is all still there, but I'm extremely tired of providing tech support for it, plus Stardew Valley 1.7 was announced and that will break it again, so I'm done. When a maintainer steps up, it can be re-enabled. * CommonClient: actually close the UI on /exit (#5860) * Aquaria: Adding a lots of options and one check (#4414) First, there is one check that has been added. The location is "Sitting on the throne before the cathedral with the crest on it" and the item is the "Opening of the Cathedral door". In Vanilla, sitting on the crested throne open the door to the cathedral. Now for the options added: - infinite_hot_soup: Make the game impossible to run out of hot soup once you got it as an item. - open_body_tongue: The body level (the ending level) is blocked by a big tongue. This option remove the tongue without having to go to the Sunken City (where it is normally removed) - maximum_ingredient_amount: In the Vanilla game, the ingredients and dishes count is limited to 8. This option make this count configurable. - skip_final_boss_3rd_form: The final boss has 5 forms. The 3rd one is long and not really challenging. So, this option is used to skip this form. - save_healing: Normally, the save points heal the player. There is also beds in the game that can heal the player. This option removed the healing from the save point and forced the player to heal using beds (or healing monsters or healing items) - no_progression_(whatever): Make this "whatever" (generally regions) exempt of progression items. Note that this is not using the exclusion-feature of AP, as these locations may still contain 'Useful' items. It is only guaranteed that no 'Progression' and 'Progression_Skip_Balancing'-items will appear in these regions. This option does not remove locations. I did not exclude or completely remove the regions because I don't have enough location to put every useful item in the game. There is also 2 new goals: - Four gods: The goal is obtained when the player beat the four gods (this is something like half the game). Useful to have quicker runs - Gods and Creator: Like the Four Gods run, but when the four gods are obtained, that open a transportation turtle to the final boss (the Creator) and the player have to beat the final boss to obtain the goal. Note that for the 2 new goals, all locations from the last 4 areas (Abyss, Frozen Veil, Sunken City and The Body) are completely removed (not just excluded). * Launcher: generate templates for option presets (#5062) * Doc: running from source and building on Linux (#5881) * CI: make the comment in 'Build' more verbose * Doc: add Linux running from source and build instructions * Doc: fix name in running from source on Linux * Update docs/running from source.md Co-authored-by: qwint <qwint.42@gmail.com> --------- Co-authored-by: qwint <qwint.42@gmail.com> * core: If a user specifies --no-gui, don't show GUI messageboxes (#5514) * move `gui_enabled` to Utils * docstring * If a user specified no-gui, don't use GUI messageboxes --------- Co-authored-by: alwaysintreble <mmmcheese158@gmail.com> * Launcher: run init_logging before importing from worlds (#5402) * WebHost: Better document config loading fallback (#5948) * change functionality to follow comment * revert code change and explicitly document intent * Celeste (Open World): v1.0.7 Logic Fixes (#5827) ### Logic Fixes: - Old Site A - Logic now allows for going backwards from the `Awake` checkpoint - Golden Ridge A - `Golden Strawberry` now requires `Moving Platforms` as it should - Mirror Temple A - `Room b-01c Strawberry` and `Room b-10 Strawberry` no longer erroneously require `Red Boosters` - `Golden Strawberry` now requires `Dash Refills` as it should - Reflection A - Logic now allows for going backwards from the `Reflection` checkpoint - Reflection B - Logic now allows for going backwards from the `Reflection` checkpoint - Farewell - `Power Source Key 2` now logically requires `Dash Switches` and `Double Dash Refills` as it should * Rule Builder: Make region.connect and add_event support rule builder (#5933) * make region.connect and add_event support rule builder * fix test * oops fix * update tests and typing * rm unused * Options: support "random" and variations for OptionSet with defined valid_keys (#4418) * seemingly works? needs testing * attempt docs update * move to verify resolution (keep?) * account for no valid keys and "random" being passed * Update advanced_settings_en.md * Update Options.py Co-authored-by: qwint <qwint.42@gmail.com> * Update Options.py Co-authored-by: Doug Hoskisson <beauxq@users.noreply.github.com> * unify random handling between range and set * Update Options.py * Update Options.py * Update Options.py Co-authored-by: Doug Hoskisson <beauxq@users.noreply.github.com> * super is weird * fix item/location * remove groups from options * unittest * pep8 * Update Options.py Co-authored-by: Exempt-Medic <60412657+Exempt-Medic@users.noreply.github.com> * Update Options.py --------- Co-authored-by: qwint <qwint.42@gmail.com> Co-authored-by: Doug Hoskisson <beauxq@users.noreply.github.com> Co-authored-by: Exempt-Medic <60412657+Exempt-Medic@users.noreply.github.com> * Core: Add missing args to rule builder inits (#5912) * add filtered_resolution to inits * update from_dict calls too * Saving Princess: Fix each slot sharing the same `music_table` (#5952) `music_table` was initialized on the `SavingPrincessWorld` *class*, so was being shared by each Saving Princess slot in the multiworld. This has been fixed by initializing the `music_table` attribute on each `SavingPrincessWorld` *instance* in `generate_early()` instead. * HK: Fix cached filler item names persisting between generations (#5950) HK's `get_filler_item_name` was writing lists into a ClassVar[dict] on the `HKWorld` class. This dict would not be cleaned out between generations on the same process, leaving behind cached data from previous generations. I confirmed the issue when running single-slot generations on a local webhost, where `self.cached_filler_items` could be already populated during `HKWorld.__init__()`. This has been fixed by putting an individual cache list on each HKWorld instance, instead of a shared cached on the class. * Factorio: Update Download Image in guides (#5953) * Docs: Replace the 'true filler' weasel words in adding games.md's mention of get_filler_item_name() (#5958) * replace the 'true filler' weasel words with a clear term defined by the linked method's docstring * Update docs/adding games.md Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com> --------- Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com> * Core: Better scaling explicit indirect conditions (#4582) * Core: Better scaling explicit indirect conditions When the number of connections to retry was large and `queue` was large `new_entrance not in queue` would get slow. For the average supported world, the difference this change makes is negligible. For a game like Blasphemous, with a lot of explicit indirect conditions, generation of 10 template Blasphemous yamls with `--skip_output --seed 1` and progression balancing disabled went from 19.0s to 17.9s (5.9% reduction in generation duration). * Create a new variable for the new set created from the intersection * WebHost: memory leak fixes (#5966) * ALTTP: remove `world: MultiWorld` and typing (#5974) * WebHost: Add CORS headers to API Endpoints (#5777) * Return new state man (Vi's note: I have chosen not to change this title) (#5978) * The Messenger: minor maintenance (#5965) * CI: upgrade InnoSetup to 6.7.0 (#5979) * MultiServer: don't keep multidata alive for race_mode (#5980) * Fix(undertale): prevent massive bounce msg spam for position updates (#5990) * fix(undertale): prevent massive bounce msg spam for position updates * make sure player is removed on leaving / timing out * do not check for tags: online, as bounce evaluation is or'd * Core: use typing_extensions `deprecated` (#5989) * Undertale: Use check_locations helper to avoid redundant sends (#5993) * Core: allow async def functions as commands (#5859) * Core: introduce finalize_multiworld and pre_output stages (#5700) Co-authored-by: Ishigh1 <bonjour940@yahoo.fr> Co-authored-by: Duck <31627079+duckboycool@users.noreply.github.com> Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com> * MultiServer: graceful shutdown for ctrl+c and sigterm (#5996) * OptionCreator: 0.6.6 reported issues (#5949) * MultiServer: fix Windows compatibility (#6010) * Docs: Better document state.locations_checked (#6018) * MM2: Fix /request command help (#5805) * MLSS: Fix client auto-connect bug + Client cleanup (#5895) * FF1: Added manifest (#5911) * OoT: change setup-guides to have 2.10 be the minimum version recommended (#5799) * Pokemon Emerald: Fix rare fuzzer errors (#5914) * Shivers: Adds Manifest File (#5918) * OOT: UTC deprecation warning fix (#5983) * Saving Princess: add manifest (#6008) * Lingo: Add archipelago.json (#6017) * Mega Man 3: Implement new game (#5237) * Stardew Valley: morel doesn't spawn in fall secret woods (#6003) * Docs: Don't serve non-static files in example_nginx.conf (#5971) * Docs: Don't serve non-static files in example_nginx.conf `try_files` will serve the file as long as it exists, which means I could `GET /autolauncher.py` and be served the file. * Use root instead of alias, add route for favicon * Update deploy/example_nginx.conf * Lingo: Fix logic for Near Eight Painting (#6014) * The Messenger: Universal Tracker support (#5344) * Test: Defaults for Options test (#5428) * Muse Dash: Adds 3 new music packs plus fixes being able to roll songs without a legal way to obtain them (#5698) * Fix missing } in example_nginx.conf (#6027) * Pokemon Emerald: Dexsanity Encounter Type Option (#6016) --------- Co-authored-by: Bryce Wilson <gyroscope15@gmail.com> * Dark Souls 3: Update location descriptions for Red Tearstone Ring and Hood of Prayer (#5602) RTSR's description was incorrect and Hood of Prayer was missing its description * TUNIC: Refactor entrance hint generation (#5620) * Refactor hint generation * Remove debug print * Early out per qwint's comment * WebHost: Update UTC datetime usage (timezone-naive) (#4906) * Saving Princess: Security fixes for issues detected by Bandit (#6013) * Saving Princess: absolute paths on suprocess.run * Saving Princess: more error handling for downloads * Saving Princess: rework launch_command setting Apparently subprocess.Popen requires a list for args instead of a string everywhere but in Windows, so the change was preventing the game from running on Linux. Additionally, the game is now launched using absolute paths. * Saving Princess: prevent bandit warnings * Saving Princess: remove unnecessary compare_digest * Saving Princess: fix Linux paths by using which * Saving Princess: rename launch command setting Previously, launch_command held a string. Now it holds a list of strings. Additionally, the defaults have changed. To prevent the wrong type from being used, the setting has been renamed, effectively abandoning the original launch_command setting. * Saving Princess: fix Linux default command return type Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com> --------- Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com> * Docs: Add references to running from source (#6022) * Docs: Update plando_en.md with item group example (#6024) * Update plando_en.md with item group example Added example YAML block for item placement using an item group, including recommendation of use of `true` value with item groups to avoid unintended behaviors, with an example of the same. Adjustments more than welcome! * Made clarifying revision to description of Generator handling of item groups Clarified the behavior of the Generator regarding item creation when item groups are used in plando. * Tests: fix race in test hosting shutdown (#5987) * WebHost: add stats show cli command (#5995) Usage: flask -A "WebHost:get_app()" stats show Currently only shows sum and top10 biggest games packages. * LttP: add manifest (#6005) * RoR2: Seekers of the Storm (SOTS) DLC Support (#5569) * Core: Make Generic ER only consider the current world in isolation (#4680) * DS3: Use remaining_fill instead of custom fill (#4397) --------- Co-authored-by: Mysteryem <Mysteryem@users.noreply.github.com> * Docs: Reword 'could be generated from json' to avoid encouraging slow world loads (#5960) * Update ffx-rc to AP 0.6.7-RC1 (#111) * Added ability to define custom port ranges the WebHost will use for game servers, instead of pure random. * - Added better fallback to default port range when a custom range fails - Updated config to be clearer * Added ability to define custom port ranges the WebHost will use for game servers, instead of pure random. * - Added better fallback to default port range when a custom range fails - Updated config to be clearer * Updated soft-fail message * Removed dead import from customserver.py * Update requirements.txt Settings requirements to main core branch * Jak and Daxter: Replace Pymem, Add Linux Support (#5850) * Replace pymem with PyMemoryEditor (nonworking) * Add back pymem for faster windows address searching. * Replace other uses of pymem, parameterize executable names. * Updated to add linux and potential MacOS support to launching gk and … (#84) * Updated to add linux and potential MacOS support to launching gk and goalc. Still needs tested on MacOS. * Switched to using x-terminal-emulator instead of trying to find gnome-terminal or konsole Made argument building for suprocessing goalc easier to read Fixed OS X support to use osascript instead of attempting to run Terminal directly * Changed Terminal usage to use Archipelago's Launh utility, which handles terminal launching for me for both linux and OS X * Added try/except to re-connect the memory process. The process file/id changes over time on linux, and this works to re-connect without needing to restart * Removed Unsetting env var in favor of reporting to the source authors * Putting PyMemoryEditor local. (#85) * Putting PyMemoryEditor local --------- Co-authored-by: massimilianodelliubaldini <8584296+massimilianodelliubaldini@users.noreply.github.com> * Fixing minor problems (#87) * Refactor away circular launcher import. * Push latest PyMemoryEditor scan utility (#91) Co-authored-by: Louis M <Louis M> * Remove Pymem, rely solely on PyMemoryEditor. Add konsole support. * Jak 1: Remove vendored copy of PME, update imports, requirements, and manifest. * Jak 1: Prevent server connect until game is properly setup. * Jak 1: reduce REPL/Compiler confusion, small updates to setup guide. * Write hack for Konsole on AppImage to avoid OpenSSL error. * Refactor LD_LIBRARY_PATH hack. * Update worlds/jakanddaxter/agents/memory_reader.py Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com> * Update worlds/jakanddaxter/agents/memory_reader.py Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com> --------- Co-authored-by: Morgan <morgan07kelley@gmail.com> Co-authored-by: Louis M <prog@tioui.com> Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com> * Docs: add spanish language for MLSS (#5172) * Docs: add spanish language for SM64 * Docs: add spanish language for MLSS * Update worlds/mlss/docs/setup_es.md Co-authored-by: PantoUwUr <99690102+PantoUwUr@users.noreply.github.com> * Update worlds/mlss/docs/es_Mario & Luigi Superstar Saga.md Co-authored-by: RoobyRoo <thegreenrobby@gmail.com> --------- Co-authored-by: PantoUwUr <99690102+PantoUwUr@users.noreply.github.com> Co-authored-by: RoobyRoo <thegreenrobby@gmail.com> * Docs, SM64: Remove outdated FAQ item (#5887) It is no longer possible to connect to a multiworld game on a version of the client with this bug, as all versions with this bug report AP v0.3.5 or less * TWW: Support launcher command line arguments (#5806) * Support launcher command line arguments * Use `launch` instead of `launch_subprocess` * Remove old runner code * Satisfactory: Update Universal Tracker Method for FinalElevatorPhase Option (#5812) * MLSS: Add Manifest + Minor Bugfixes (#5728) * Remove outdated header change for ROM verification * Update Connections to be compatible with python ver. 3.8 * Update inno_setup.iss * Update inno_setup.iss * Merge branch 'main' of https://github.com/jamesbrq/ArchipelagoMainMLSS * Add Manifest + Minor Bugfixes * Even further safeguards for Oho Oasis Temples * Update basepatch.bsdiff * KH2: Add a new "CasualBounties" Setting (#4877) * KH2: casual bounties option * Casual Bounty: Adjust level bounty logic to correspond with max level check setting * Bugfix: We have one less possible bounty with corresponding level bounty logic * Casual Bounty: Move option to better spot * Bugfix: Prevent possible .remove() crash * Revert "Bugfix: We have one less possible bounty with corresponding level bounty logic" This reverts commit 3c929e00db910a176d9d882b6cc08494417177d2. * Bugfix: Typo in conditional * Casual Bounties: Remove Scar, add MCP I knew I was missing one second visit fight and Scar shouldn't be there he's a first visit * Casual Bounties: Add some clarity to the CasualBounty setting * Docs: Update docs to reflect new CasualBounty setting * KH2: Add bounty locations as location groups Feedback on this needed, trying to do this to make it work with the code above the additions made it so the game generated 1 less item than locations, despite linking properly It does function as intended though * KH2: Update docs * KH2: Add SuperBosses, Cups, AtlanticaToggle and SummonLevelLocationToggle to slot data (#5708) * Add SuperBosses, Cups and AtlanticaToggle * Add SummonLevelLocationToggle * Core: Add SDL_MOUSE_FOCUS_CLICKTHROUGH=1 environment variable to kvui (#5804) This variable should fix the 'double click' required when trying to interact with buttons on an unfocused window * SC2: Bump protobuf from 6.31.1 to 6.33.5 in /worlds/_sc2common (#5890) Bumps [protobuf](https://github.com/protocolbuffers/protobuf) from 6.31.1 to 6.33.5. - [Release notes](https://github.com/protocolbuffers/protobuf/releases) - [Commits](https://github.com/protocolbuffers/protobuf/commits) --- updated-dependencies: - dependency-name: protobuf dependency-version: 6.33.5 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Core, Tests: allow Archipelago items in all worlds (#5893) * Core: Add rule builder (#5048) * initial commit of rules engine * implement most of the stuff * add docs and fill out rest of the functionality * add in explain functions * dedupe items and add more docs * pr feedback and optimization updates * Self is not in typing on 3.10 * fix test * Update docs/rule builder.md Co-authored-by: BadMagic100 <dempsey.sean@outlook.com> * pr feedback * love it when CI gives me different results than local * add composition with bitwise and and or * strongly typed option filtering * skip resolving location parent region * update docs * update typing and add decorator * add string explains * move simplify code to world * add wrapper rule * I may need to abandon the generic typing * missing space for faris * fix hashing for resolved rules * thank u typing extensions ilu * remove bad cacheable check * add decorator to assign hash and rule name * more type crimes... * region access rules are now cached * break compatibility so new features work * update docs * replace decorators with __init_subclass__ * ok now the frozen dataclass is automatic * one more type fix for the road * small fixes and caching tests * play nicer with tests * ok actually fix the tests * add item_mapping for faris * add more state helpers as rules * fix has from list rules * fix can reach location caching and add set completion condition * fix can reach entrance caching * implement HasGroup and HasGroupUnique * add more tests and fix some bugs * Add name arg to create_entrance Co-authored-by: roseasromeo <11944660+roseasromeo@users.noreply.github.com> * fix json dumping option filters * restructure and test serialization * add prop to disable caching * switch to __call__ and revert access_rule changes * update docs and make edge cases match * ruff has lured me into a false sense of security * also unused * fix disabling caching * move filter function to filter class * add more docs * tests for explain functions * Update docs/rule builder.md Co-authored-by: roseasromeo <11944660+roseasromeo@users.noreply.github.com> * chore: Strip out uses of TYPE_CHECKING as much as possible * chore: add empty webworld for test * chore: optimize rule evaluations * remove getattr from hot code paths * testing new cache flags * only clear cache for rules cached as false in collect * update test for new behaviour * do not have rules inherit from each other * update docs on caching * fix name of attribute * make explain messages more colorful * fix issue with combining rules with different options * add convenience functions for filtering * use an operator with higher precedence * name conflicts less with optionfilter * move simplify and instance caching code * update docs * kill resolve_rule * kill true_rule and false_rule * move helpers to base classes * update docs * I really should finish all of my * fix test * rename mixin * fix typos * refactor rule builder into folder for better imports * update docs * do not dupe collectionrule * docs review feedback * missed a file * remove rule_caching_enabled from base World * update docs on caching * shuffle around some docs * use option instead of option.value * add in operator and more testing * rm World = object * test fixes * move cache to logic mixin * keep test rule builder world out of global registry * todone * call register_dependencies automatically * move register deps call to call_single * add filtered_resolution * allow bool opts on filters * fix serialization tests * allow reverse operations --------- Co-authored-by: BadMagic100 <dempsey.sean@outlook.com> Co-authored-by: roseasromeo <11944660+roseasromeo@users.noreply.github.com> * Core: Throw OptionError for option type Toggle in certain scenarios (#5874) * Throw OptionError for option type Toggle in certain scenarios * Adding missing space to Options.py Co-authored-by: Katelyn Gigante <clockwork.singularity@gmail.com> --------- Co-authored-by: Katelyn Gigante <clockwork.singularity@gmail.com> * Utils: Improvements to visualize_regions for debugging GER usage (#4685) * Improvements to visualize_regions for debugging GER usage - allow the user to pass in a dict[int, int] to visualize_regions that maps Entrance.randomization_group to a color in RGB form. This allows for better visualization of which dangling entrances should match, or which matching groups are not being correctly respected. - do full region visualization for unreached regions, so that entrances that could connect to new regions can be visualized. - visualize unconnected entrances on regions, in addition to connected and unconnected exits, so that available ER targets can be visualized as well * Add detail_disconnected_regions parameter to visualize_regions * Rename detail_disconnected_regions to detail_other_regions for consistency * Add auto_assign_colors param to visualize_regions * Make auto assignment of entrance colors deterministic * Assume show_other_regions is true if detail_other_regions is true * Remove unused random import * whitespace adjustments * Move overflow check to prevent potential infinite loop It wasn't exactly likely, as the user would have had to manually define all 4096 colors and then need an additional color on top of that, but accounting for that kind of nonsense is easy enough in this case. * positive condition --------- Co-authored-by: CodeGorilla <3672561+Ars-Ignis@users.noreply.github.com> * APQuest: Improve the auto-generated .gitignore for data/sounds (#5670) I didn't quite think this through: In this specific case, you want the gitignore to also ignore itself, since it itself is an auto-generated file. * Webhost: Fix defaults for NamedRange and TextChoice (#5139) * TUNIC: Depriority for some items (#5589) * Stardew Valley: 7.x.x - The Jojapocalypse Update (#5432) Major Content update for Stardew Valley ### Features - New BundleRandomization Value: Meme Bundles - Over 100 custom bundles, designed to be jokes, references, trolls, etc - New Setting: Bundles Per Room modifier - New Setting: Backpack Size - New Setting: Secretsanity - Checks for triggering easter eggs and secrets - New Setting: Moviesanity - Checks for watching movies and sharing snacks with Villagers - New Setting: Eatsanity - Checks for eating items - New Setting: Hatsanity - Checks for wearing Hats - New Setting: Start Without - Allows you to select any combination of various "starting" items, that you will actually not start with. Notably, tools, backpack slots, Day5 unlocks, etc. - New Setting: Allowed Filler Items - Allows you to customize the filler items you'll get - New Setting: Endgame Locations - Checks for various expensive endgame tasks and purchases - New Shipsanity value: Crops and Fish - New Settings: Jojapocalypse and settings to customize it - Bundle Plando: Replaced with BundleWhitelist and BundleBlacklist, for more customization freedom - Added a couple of Host.yaml settings to help hosts allow or ban specific difficult settings that could cause problems if the people don't know what they are signing up for. Plus a truckload of improvements on the mod side, not seen in this PR. ### Removed features - Integration for Stardew Valley Expanded. It is simply disabled, the code is all still there, but I'm extremely tired of providing tech support for it, plus Stardew Valley 1.7 was announced and that will break it again, so I'm done. When a maintainer steps up, it can be re-enabled. * CommonClient: actually close the UI on /exit (#5860) * Aquaria: Adding a lots of options and one check (#4414) First, there is one check that has been added. The location is "Sitting on the throne before the cathedral with the crest on it" and the item is the "Opening of the Cathedral door". In Vanilla, sitting on the crested throne open the door to the cathedral. Now for the options added: - infinite_hot_soup: Make the game impossible to run out of hot soup once you got it as an item. - open_body_tongue: The body level (the ending level) is blocked by a big tongue. This option remove the tongue without having to go to the Sunken City (where it is normally removed) - maximum_ingredient_amount: In the Vanilla game, the ingredients and dishes count is limited to 8. This option make this count configurable. - skip_final_boss_3rd_form: The final boss has 5 forms. The 3rd one is long and not really challenging. So, this option is used to skip this form. - save_healing: Normally, the save points heal the player. There is also beds in the game that can heal the player. This option removed the healing from the save point and forced the player to heal using beds (or healing monsters or healing items) - no_progression_(whatever): Make this "whatever" (generally regions) exempt of progression items. Note that this is not using the exclusion-feature of AP, as these locations may still contain 'Useful' items. It is only guaranteed that no 'Progression' and 'Progression_Skip_Balancing'-items will appear in these regions. This option does not remove locations. I did not exclude or completely remove the regions because I don't have enough location to put every useful item in the game. There is also 2 new goals: - Four gods: The goal is obtained when the player beat the four gods (this is something like half the game). Useful to have quicker runs - Gods and Creator: Like the Four Gods run, but when the four gods are obtained, that open a transportation turtle to the final boss (the Creator) and the player have to beat the final boss to obtain the goal. Note that for the 2 new goals, all locations from the last 4 areas (Abyss, Frozen Veil, Sunken City and The Body) are completely removed (not just excluded). * Launcher: generate templates for option presets (#5062) * Doc: running from source and building on Linux (#5881) * CI: make the comment in 'Build' more verbose * Doc: add Linux running from source and build instructions * Doc: fix name in running from source on Linux * Update docs/running from source.md Co-authored-by: qwint <qwint.42@gmail.com> --------- Co-authored-by: qwint <qwint.42@gmail.com> * core: If a user specifies --no-gui, don't show GUI messageboxes (#5514) * move `gui_enabled` to Utils * docstring * If a user specified no-gui, don't use GUI messageboxes --------- Co-authored-by: alwaysintreble <mmmcheese158@gmail.com> * Launcher: run init_logging before importing from worlds (#5402) * WebHost: Better document config loading fallback (#5948) * change functionality to follow comment * revert code change and explicitly document intent * Celeste (Open World): v1.0.7 Logic Fixes (#5827) ### Logic Fixes: - Old Site A - Logic now allows for going backwards from the `Awake` checkpoint - Golden Ridge A - `Golden Strawberry` now requires `Moving Platforms` as it should - Mirror Temple A - `Room b-01c Strawberry` and `Room b-10 Strawberry` no longer erroneously require `Red Boosters` - `Golden Strawberry` now requires `Dash Refills` as it should - Reflection A - Logic now allows for going backwards from the `Reflection` checkpoint - Reflection B - Logic now allows for going backwards from the `Reflection` checkpoint - Farewell - `Power Source Key 2` now logically requires `Dash Switches` and `Double Dash Refills` as it should * Rule Builder: Make region.connect and add_event support rule builder (#5933) * make region.connect and add_event support rule builder * fix test * oops fix * update tests and typing * rm unused * Options: support "random" and variations for OptionSet with defined valid_keys (#4418) * seemingly works? needs testing * attempt docs update * move to verify resolution (keep?) * account for no valid keys and "random" being passed * Update advanced_settings_en.md * Update Options.py Co-authored-by: qwint <qwint.42@gmail.com> * Update Options.py Co-authored-by: Doug Hoskisson <beauxq@users.noreply.github.com> * unify random handling between range and set * Update Options.py * Update Options.py * Update Options.py Co-authored-by: Doug Hoskisson <beauxq@users.noreply.github.com> * super is weird * fix item/location * remove groups from options * unittest * pep8 * Update Options.py Co-authored-by: Exempt-Medic <60412657+Exempt-Medic@users.noreply.github.com> * Update Options.py --------- Co-authored-by: qwint <qwint.42@gmail.com> Co-authored-by: Doug Hoskisson <beauxq@users.noreply.github.com> Co-authored-by: Exempt-Medic <60412657+Exempt-Medic@users.noreply.github.com> * Core: Add missing args to rule builder inits (#5912) * add filtered_resolution to inits * update from_dict calls too * Saving Princess: Fix each slot sharing the same `music_table` (#5952) `music_table` was initialized on the `SavingPrincessWorld` *class*, so was being shared by each Saving Princess slot in the multiworld. This has been fixed by initializing the `music_table` attribute on each `SavingPrincessWorld` *instance* in `generate_early()` instead. * HK: Fix cached filler item names persisting between generations (#5950) HK's `get_filler_item_name` was writing lists into a ClassVar[dict] on the `HKWorld` class. This dict would not be cleaned out between generations on the same process, leaving behind cached data from previous generations. I confirmed the issue when running single-slot generations on a local webhost, where `self.cached_filler_items` could be already populated during `HKWorld.__init__()`. This has been fixed by putting an individual cache list on each HKWorld instance, instead of a shared cached on the class. * Factorio: Update Download Image in guides (#5953) * Docs: Replace the 'true filler' weasel words in adding games.md's mention of get_filler_item_name() (#5958) * replace the 'true filler' weasel words with a clear term defined by the linked method's docstring * Update docs/adding games.md Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com> --------- Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com> * Core: Better scaling explicit indirect conditions (#4582) * Core: Better scaling explicit indirect conditions When the number of connections to retry was large and `queue` was large `new_entrance not in queue` would get slow. For the average supported world, the difference this change makes is negligible. For a game like Blasphemous, with a lot of explicit indirect conditions, generation of 10 template Blasphemous yamls with `--skip_output --seed 1` and progression balancing disabled went from 19.0s to 17.9s (5.9% reduction in generation duration). * Create a new variable for the new set created from the intersection * WebHost: memory leak fixes (#5966) * ALTTP: remove `world: MultiWorld` and typing (#5974) * WebHost: Add CORS headers to API Endpoints (#5777) * Return new state man (Vi's note: I have chosen not to change this title) (#5978) * The Messenger: minor maintenance (#5965) * CI: upgrade InnoSetup to 6.7.0 (#5979) * MultiServer: don't keep multidata alive for race_mode (#5980) * MultiServer, customserver: move data package handling Create a new class that handles conversion worlds+embedded -> context data. Create a derived class that uses static_server_data+pony instead. There is also a not very efficient feature to deduplicate strings (may need perf testing). By moving code around, we can simplify a lot of the world loading. Where code lines were touched, some typing and some reformatting was added. The back compat for GetDataPackage without games was finally dropped. This was done as a cleanup because the refactoring touched those lines anyway. Also reworked the per-context dicts and the RoomInfo to hopefully be more efficient by ignoring unused games. (Generating the list of used games was required for the new code anyway.) Side effect of the MultiServer cache: we now load worlds lazily (but still all at once) and don't modify the games package in place. If needed we create copies. This almost gets us to the point where MultiServer doesn't need worlds - it still needs them for the forbidden items. There is a bonus optimization that deduplicates strings in name_groups that may have bad performance and may need some perf testing if we run into issues. * MultiServer: fix string deduplication in data package cache * MultiServer, customserver: minor formatting fixes * MultiServer: fix data package cache for missing checksum case * MultiServer: improve string deduplication in games package cache * customserver: handle missing checksum in datapackage cache * customserver: typing cleanup in games package cache * Test, MultiServer, customser: add tests for games package cache * Test, MultiServer: reorder imports Hopefully this fixes the random test failures with pytest-xdist * customserver: make WebHost import lazy in games package cache and fix test * customserver: games package cache: fix py3.11 compat * MultiServer, customserver: cache: typing improvements * customserver: cache: reformat * Fix(undertale): prevent massive bounce msg spam for position updates (#5990) * fix(undertale): prevent massive bounce msg spam for position updates * make sure player is removed on leaving / timing out * do not check for tags: online, as bounce evaluation is or'd * Core: use typing_extensions `deprecated` (#5989) * Test: move customserver tests to not interfere with webhost * Undertale: Use check_locations helper to avoid redundant sends (#5993) * Core: allow async def functions as commands (#5859) * Core: introduce finalize_multiworld and pre_output stages (#5700) Co-authored-by: Ishigh1 <bonjour940@yahoo.fr> Co-authored-by: Duck <31627079+duckboycool@users.noreply.github.com> Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com> * MultiServer: graceful shutdown for ctrl+c and sigterm (#5996) * OptionCreator: 0.6.6 reported issues (#5949) * fix what reviewers said and add some improvements * remove unused argument * try fixing test with try * use yaml lists instead of string for config * fix value type bug on ephemeral type * reuse sockets with websockets api instead of opening and closing them * add used ports cache and filter used ports when looking for ports * fix port randomizer * Apply suggestions from code review Co-authored-by: Duck <31627079+duckboycool@users.noreply.github.com> * fix some reviews * use weights for random port and remove more-itertools * MultiServer, customserver: cache: rename module * fix net_connections not working on macOS * MultiServer: fix Windows compatibility (#6010) * rename variables and functions * lazy init `get_used_ports` * change `game_ports` to be `tuple` * fix last_used_ports not being updated locally * fix random choices and move game_port conversion into tuple * Apply suggestions from code review Co-authored-by: Duck <31627079+duckboycool@users.noreply.github.com> * use a named tuple on parse_game_ports * only use ranges * do it the duck way * this should check all usable ports before failing * fix while loop * add return type to weighted random * Docs: Better document state.locations_checked (#6018) * Update WebHostLib/customserver.py Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com> * simplify tuple conversion check * add tests * reformat file and change `create_random_port_socket` test * add more test cases for parse_game_ports * MM2: Fix /request command help (#5805) * MLSS: Fix client auto-connect bug + Client cleanup (#5895) * FF1: Added manifest (#5911) * OoT: change setup-guides to have 2.10 be the minimum version recommended (#5799) * Pokemon Emerald: Fix rare fuzzer errors (#5914) * Shivers: Adds Manifest File (#5918) * OOT: UTC deprecation warning fix (#5983) * Saving Princess: add manifest (#6008) * Lingo: Add archipelago.json (#6017) * Mega Man 3: Implement new game (#5237) * Stardew Valley: morel doesn't spawn in fall secret woods (#6003) * try to prevent busy-looping on create random port socket when doing test * simplify parse game port tests to one assertListEqual * make the range lesser for port test * reduce range on macOS * Docs: Don't serve non-static files in example_nginx.conf (#5971) * Docs: Don't serve non-static files in example_nginx.conf `try_files` will serve the file as long as it exists, which means I could `GET /autolauncher.py` and be served the file. * Use root instead of alias, add route for favicon * Update deploy/example_nginx.conf * Apply suggestions from code review Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com> * Update WebHostLib/customserver.py Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com> * Lingo: Fix logic for Near Eight Painting (#6014) * Apply suggestions from code review Co-authored-by: Doug Hoskisson <beauxq@users.noreply.github.com> * remove unused import * Update WebHostLib/customserver.py Co-authored-by: Doug Hoskisson <beauxq@users.noreply.github.com> * use generator expressions * The Messenger: Universal Tracker support (#5344) * Test: Defaults for Options test (#5428) * Muse Dash: Adds 3 new music packs plus fixes being able to roll songs without a legal way to obtain them (#5698) * Fix missing } in example_nginx.conf (#6027) * Pokemon Emerald: Dexsanity Encounter Type Option (#6016) --------- Co-authored-by: Bryce Wilson <gyroscope15@gmail.com> * Dark Souls 3: Update location descriptions for Red Tearstone Ring and Hood of Prayer (#5602) RTSR's description was incorrect and Hood of Prayer was missing its description * TUNIC: Refactor entrance hint generation (#5620) * Refactor hint generation * Remove debug print * Early out per qwint's comment * WebHost: Update UTC datetime usage (timezone-naive) (#4906) * Saving Princess: Security fixes for issues detected by Bandit (#6013) * Saving Princess: absolute paths on suprocess.run * Saving Princess: more error handling for downloads * Saving Princess: rework launch_command setting Apparently subprocess.Popen requires a list for args instead of a string everywhere but in Windows, so the change was preventing the game from running on Linux. Additionally, the game is now launched using absolute paths. * Saving Princess: prevent bandit warnings * Saving Princess: remove unnecessary compare_digest * Saving Princess: fix Linux paths by using which * Saving Princess: rename launch command setting Previously, launch_command held a string. Now it holds a list of strings. Additionally, the defaults have changed. To prevent the wrong type from being used, the setting has been renamed, effectively abandoning the original launch_command setting. * Saving Princess: fix Linux default command return type Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com> --------- Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com> * Docs: Add references to running from source (#6022) * Docs: Update plando_en.md with item group example (#6024) * Update plando_en.md with item group example Added example YAML block for item placement using an item group, including recommendation of use of `true` value with item groups to avoid unintended behaviors, with an example of the same. Adjustments more than welcome! * Made clarifying revision to description of Generator handling of item groups Clarified the behavior of the Generator regarding item creation when item groups are used in plando. * Tests: fix race in test hosting shutdown (#5987) * WebHost: add stats show cli command (#5995) Usage: flask -A "WebHost:get_app()" stats show Currently only shows sum and top10 biggest games packages. * LttP: add manifest (#6005) * RoR2: Seekers of the Storm (SOTS) DLC Support (#5569) * Core: Make Generic ER only consider the current world in isolation (#4680) * DS3: Use remaining_fill instead of custom fill (#4397) --------- Co-authored-by: Mysteryem <Mysteryem@users.noreply.github.com> * Docs: Reword 'could be generated from json' to avoid encouraging slow world loads (#5960) * Mark WebHost as beta --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Lexipherous <jasonnlelong@gmail.com> Co-authored-by: Fabian Dill <Berserker66@users.noreply.github.com> Co-authored-by: massimilianodelliubaldini <8584296+massimilianodelliubaldini@users.noreply.github.com> Co-authored-by: Morgan <morgan07kelley@gmail.com> Co-authored-by: Louis M <prog@tioui.com> Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com> Co-authored-by: GreenMarco <71452195+GreenMarco@users.noreply.github.com> Co-authored-by: PantoUwUr <99690102+PantoUwUr@users.noreply.github.com> Co-authored-by: RoobyRoo <thegreenrobby@gmail.com> Co-authored-by: soopercool101 <soopercoolstages@gmail.com> Co-authored-by: Jonathan Tan <tanjo3@users.noreply.github.com> Co-authored-by: mechanicset <22198918+mechanicset@users.noreply.github.com> Co-authored-by: jamesbrq <jamesbrq@gmail.com> Co-authored-by: PIEisFANTASTIC <49802408+PIEisFANTASTIC@users.noreply.github.com> Co-authored-by: James White <james_white_d@hotmail.com> Co-authored-by: ScorelessPine <scorelesspine@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ian Robinson <drtchops@users.noreply.github.com> Co-authored-by: BadMagic100 <dempsey.sean@outlook.com> Co-authored-by: roseasromeo <11944660+roseasromeo@users.noreply.github.com> Co-authored-by: earthor1 <earthor1@gmail.com> Co-authored-by: Katelyn Gigante <clockwork.singularity@gmail.com> Co-authored-by: CodeGorilla <just.a.smith@att.net> Co-authored-by: CodeGorilla <3672561+Ars-Ignis@users.noreply.github.com> Co-authored-by: NewSoupVi <57900059+NewSoupVi@users.noreply.github.com> Co-authored-by: josephwhite <22449090+josephwhite@users.noreply.github.com> Co-authored-by: Scipio Wright <scipiowright@gmail.com> Co-authored-by: agilbert1412 <alexgilbert@yahoo.com> Co-authored-by: Silvris <58583688+Silvris@users.noreply.github.com> Co-authored-by: qwint <qwint.42@gmail.com> Co-authored-by: alwaysintreble <mmmcheese158@gmail.com> Co-authored-by: PoryGone <98504756+PoryGone@users.noreply.github.com> Co-authored-by: Doug Hoskisson <beauxq@users.noreply.github.com> Co-authored-by: Exempt-Medic <60412657+Exempt-Medic@users.noreply.github.com> Co-authored-by: Mysteryem <Mysteryem@users.noreply.github.com> Co-authored-by: BroOtti <35010852+BroOtti@users.noreply.github.com> Co-authored-by: Ixrec <ericrhitchcock@gmail.com> Co-authored-by: DrAwesome4333 <22409322+DrAwesome4333@users.noreply.github.com> Co-authored-by: Duck <31627079+duckboycool@users.noreply.github.com> Co-authored-by: Chris W <trezc0@gmx.de> Co-authored-by: Ishigh1 <bonjour940@yahoo.fr> Co-authored-by: Uriel <imurx@proton.me> Co-authored-by: Suyooo <chrspangler@gmx.de> Co-authored-by: Rosalie <61372066+Rosalie-A@users.noreply.github.com> Co-authored-by: StripesOO7 <54711792+StripesOO7@users.noreply.github.com> Co-authored-by: Bryce Wilson <gyroscope15@gmail.com> Co-authored-by: GodlFire <46984098+GodlFire@users.noreply.github.com> Co-authored-by: LeonarthCG <33758848+LeonarthCG@users.noreply.github.com> Co-authored-by: Star Rauchenberger <fefferburbia@gmail.com> Co-authored-by: Noa Aarts <itepastra@gmail.com> Co-authored-by: Remy Jette <remy@remyjette.com> Co-authored-by: Jérémie Bolduc <16137441+Jouramie@users.noreply.github.com> Co-authored-by: Justus Lind <DeamonHunter@users.noreply.github.com> Co-authored-by: Goo-Dang <pado879@gmail.com> Co-authored-by: Matthew Wells <91291346+richarm4@users.noreply.github.com> Co-authored-by: Gryphonlady <gryphonlady1@gmail.com> Co-authored-by: Rjosephson <ryandj67@hotmail.com> * Rule Builder Refactor (#113) * Flips 3 & 5 chest exclusions (#118) * Overdrive Items & Locations (#114) * Overdrives from RuleBuilders * Tidus early overdrive access * Jupiter Sigil Rule * Wakka rules * Valefor overdrive ID * Valefor item * Change offsets * slot data & UT * Granular Tidus Overdrive Options * Define custom `.Resolved` subclasses for `CanReachMinimumRegions` & `CanReachMinimumLocations` * Rename character specific overdrive locations & items * Update Rules to match new location names * Fix Swordplay rules * Swordplay logic changed from 5 -> 3 overdrives per combat region * Overdrive Modes option * Wakka is Slots, not Reels * Slots rules name * Version increment v0.7.0 * Update ffx-rc to AP core v0.6.7 (#125) * KH2: Fix nondeterministic generation when CasualBounties is enabled (#5967) When CasualBounties was enabled, the location names in `exclusion_table["HitlistCasual"]` would be iterated into `self.random_super_boss_list` in `generate_early`, but `exclusion_table["HitlistCasual"]` was a `set`, so its iteration order would vary on each generation, even with same seed. Random location names would be picked from `self.random_super_boss_list` to place Bounty items at, so different locations could be picked on each generation with the same seed. `exclusion_table["Hitlist"]` is similar and was already a `list`, avoiding the issue of nondeterministic iteration order, so `exclusion_table["HitlistCasual"]` has been changed to a `list` to match. * Core: Update .gitignore to include an exe setup.py downloads (#6031) * CommonClient: Add explicit message for connection timeout (#5842) * Change timeout and add timeout-specific message * Revert open_timeout * Webhost: port reuse fix & configurable max room timeout (#6033) * WebHost: make autolauncher max room timeout configurable * WebHost: launch rooms with assigned port first * Factorio: only show fluid boxes on assembling machine 1 when the selected recipe needs fluids (#5412) * Core: other resources guide (#6043) Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com> Co-authored-by: Emily <35015090+EmilyV99@users.noreply.github.com> * Rule Builder: Fix count resolution when Oring HasAnyCount (#6048) * Muse Dash: Add support for Wuthering Waves Pioneer Podcast and Ay-Aye Horse (#6071) * sc2: Fixing random fill errors in unit tests (#6045) * Core: Make Generate.main only init logging on __main__ (#6069) * setup.py: add rule_builder.cached_world to included list (#6070) * Clients: remove datapackage from persistent_storage ... (#6074) ... next time it gets written to. This makes loading peristent_storage faster in the future. * Core, Webhost: update and pin dependency versions (#6075) * Launcher: Add konsole to terminal list and rework launch dialog (#5684) * Make component launching indicate if no terminal window, add konsole * Attempt to spell better and remove whitespace * Update terminal priority * Make helper for clearing LD_LIBRARY_PATH * Add handling to linux launch * Hopefully fix setter * Apply suggestions from code review Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com> --------- Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com> * Docs: update macOS setup instructions for more specificity on Python version (#6078) * Pokemon Emerald: Fix Latios KeyError (#6056) * Muse Dash: Fix nondeterministic generation with include_songs (#6040) The include_songs option is an OptionSet, whose value is a set, but was being iterated to produce self.included_songs. Sets are unordered and may have a different iteration order each time a python process is run. This meant that the order of the elements in self.included_songs could differ even when generating with a fixed seed. This caused nondeterministic generation with the same seed because create_song_pool() deterministically randomly picks songs from self.included_songs, which could be in a different order each time, so different songs could be picked. * Messenger: Require Wingsuit to traverse Dark Cave (#6059) * Stardew valley: Four small fixes (#6055) * - Fixed the Dr Seuss Bundle asking for tigerseye (mineral) instead of tiger trout (fish) * - Made blue grass starter more consistent * - Fragments of the past does not rely on ginger island * - Removed legacy hard coded strange bun recipe that messed with chefsanity logic * Stardew Valley: trimmed lucky purple shorts need gold to make (#6034) The current logic only requires the shorts and a sewing machine, but a gold bar is also necessary * Stardew Valley: Fixed an issue where some specific option combinations could create more items than locations (#6012) * - Improved the dynamic locations count algorithm to take into account the nature of various heavy settings in both directions * - Fixes from Code Review * - We're only testing for sunday locations, might as well only take sunday locations in the list to test * - One more slight optimization * - Added consideration for bundles per room in filler locations counting * - Registered some more IDs to handle items up to 10 * Super Mario Land 2: Fix Space Zone 2 Logic (#6025) * Satisfactory: bug fix in __init__.py (#5930) Solved indentation error to return to intended functionality * lufia2ac: update CollectionRule import (#5936) * WebHost: Remove space before comma separators in tutorial authors (#5999) * Remove space before comma * Factorio authors update * Simplify template * APQuest: Various fixes (#6079) * Import Buffer from typing_extensions instead of collections.abc for 3.11 compat * always re-set sound volumes before playing * fix game window scaling if parent is vertical * make default volume lower * Satisfactory: Fixed buildings missing from goal check (#5772) * Aquaria: Fixing bug where Urchin Costume is…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.