Fix dimensionally inconsistent mass regularisation in EVP dynamics (modes 1 & 2)#951
Open
patrickscholz wants to merge 2 commits into
Open
Fix dimensionally inconsistent mass regularisation in EVP dynamics (modes 1 & 2)#951patrickscholz wants to merge 2 commits into
patrickscholz wants to merge 2 commits into
Conversation
Contributor
Author
|
i will make a test bias run for this one as well! |
…HS (modes 1 and 2) The original expression `mass/(1+mass²)` mixes dimensionless 1 with [kg/m²]², making the formula physically meaningless. Replace with the correct `1/max(mass, 9.0)`, where 9.0 kg/m² is the same floor already used for inv_thickness in the same loop (≈1 cm of pure ice, ρ_ice ≈ 900 kg/m²). The fix is applied in stress2rhs_m (shared by mEVP mode 1 and aEVP mode 2) and the inlined equivalent in EVPdynamics_m (mode 1).
patrickscholz
force-pushed
the
workbench_fix_evp_mass_regularisation
branch
from
June 26, 2026 13:50
2879fe4 to
f5a0914
Compare
Contributor
Author
JanStreffing
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Problem
In
stress2rhs_m(called by both mEVP mode 1 and aEVP mode 2) and the inlined equivalent inEVPdynamics_m(mode 1 only), the column ice mass per unit area is regularised using:This expression is dimensionally inconsistent: the denominator adds a dimensionless
1tomass²which has units of(kg/m²)². The formula has no physical meaning.Effect
For typical Arctic sea ice (e.g., 1 m ice + 0.1 m snow):
The original formula suppresses ice acceleration by a factor of ~1000 more than physically correct for thick ice. For thin ice (mass ≈ 1 kg/m²) the expressions are closer, but the formula is still wrong.
Modes affected
EVPdynamics_m): affected in two places —stress2rhs_m(shared RHS assembly) and the inlined fused loop insideEVPdynamics_mEVPdynamics_a): affected viastress2rhs_m(called fromEVPdynamics_a)EVPdynamics): uses a different RHS path — not affectedFix
Replace the dimensionally inconsistent expression with the physically correct inverse mass, floored at
9.0 kg/m²(≈ 1 cm of pure ice,ρ_ice ≈ 900 kg/m³) to prevent near-zero mass from causing numerical problems:The
9.0 kg/m²floor is already used in the same loop forinv_thickness(! Limit the masscomment, line 653), so this is consistent with the existing convention in the code.The original expressions are kept as comments.
Files changed
src/ice_maEVP.F90: lines 415–416 (stress2rhs_m) and 655–656 (EVPdynamics_m)