Skip to content

Fix inverted interpolation weights for Redi K_33 at vertical interfaces #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
patrickscholz wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix inverted interpolation weights for Redi K_33 at vertical interfaces #944

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0452259
Fix inverted interpolation weights for Redi K_33 at vertical interfaces
patrickscholz Jun 25, 2026
275f47a
Merge branch 'main' into workbench_fix_redi_interpolation_weights
patrickscholz Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/oce_ale_tracer.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -952,8 +952,8 @@ subroutine diff_ver_part_impl_ale(tr_num, dynamics, tracers, ice, partit, mesh)
zinv=1.0_WP*dt ! no .../(zbar(1)-zbar(2)) because of ALE

! calculate isoneutral diffusivity : Kd*s^2 --> K_33 = Kv + Kd*s^2
Ty1= (Z_n(nz) -zbar_n(nz+1))*zinv2 *slope_tapered(3,nz ,n)**2*Ki(nz ,n) + &
(zbar_n(nz+1)-Z_n( nz+1))*zinv2 *slope_tapered(3,nz+1,n)**2*Ki(nz+1,n)
Ty1= (zbar_n(nz+1)-Z_n( nz+1))*zinv2 *slope_tapered(3,nz ,n)**2*Ki(nz ,n) + &
(Z_n(nz) -zbar_n(nz+1))*zinv2 *slope_tapered(3,nz+1,n)**2*Ki(nz+1,n)
Ty1=Ty1*isredi

! layer dependent coefficients for for solving dT(1)/dt+d/dz*K_33*d/dz*T(1) = ...
Expand Down Expand Up @@ -985,10 +985,10 @@ subroutine diff_ver_part_impl_ale(tr_num, dynamics, tracers, ice, partit, mesh)
! 1/dz(nz)
zinv2=1.0_WP/(Z_n(nz)-Z_n(nz+1))
! calculate isoneutral diffusivity : Kd*s^2 --> K_33 = Kv + Kd*s^2
Ty = (Z_n(nz-1 )-zbar_n(nz ))*zinv1 *slope_tapered(3,nz-1,n)**2*Ki(nz-1,n)+ &
(zbar_n(nz )-Z_n(nz ))*zinv1 *slope_tapered(3,nz ,n)**2*Ki(nz ,n)
Ty1= (Z_n(nz )-zbar_n(nz+1))*zinv2 *slope_tapered(3,nz ,n)**2*Ki(nz ,n)+ &
(zbar_n(nz+1)-Z_n(nz+1 ))*zinv2 *slope_tapered(3,nz+1,n)**2*Ki(nz+1,n)
Ty = (zbar_n(nz )-Z_n(nz ))*zinv1 *slope_tapered(3,nz-1,n)**2*Ki(nz-1,n)+ &
(Z_n(nz-1 )-zbar_n(nz ))*zinv1 *slope_tapered(3,nz ,n)**2*Ki(nz ,n)
Ty1= (zbar_n(nz+1)-Z_n(nz+1 ))*zinv2 *slope_tapered(3,nz ,n)**2*Ki(nz ,n)+ &
(Z_n(nz )-zbar_n(nz+1))*zinv2 *slope_tapered(3,nz+1,n)**2*Ki(nz+1,n)
Ty =Ty *isredi
Ty1=Ty1*isredi

Expand Down Expand Up @@ -1028,8 +1028,8 @@ subroutine diff_ver_part_impl_ale(tr_num, dynamics, tracers, ice, partit, mesh)
zinv=1.0_WP*dt ! no ... /(zbar(nzmax-1)-zbar(nzmax)) because of ale

! calculate isoneutral diffusivity : Kd*s^2 --> K_33 = Kv + Kd*s^2
Ty= (Z_n(nz-1) -zbar_n(nz)) * zinv1 * slope_tapered(3,nz-1,n)**2 * Ki(nz-1,n) + &
(zbar_n(nz)-Z_n(nz) ) * zinv1 * slope_tapered(3,nz ,n)**2 * Ki(nz,n)
Ty= (zbar_n(nz)-Z_n(nz) ) * zinv1 * slope_tapered(3,nz-1,n)**2 * Ki(nz-1,n) + &
(Z_n(nz-1) -zbar_n(nz)) * zinv1 * slope_tapered(3,nz ,n)**2 * Ki(nz,n)
Ty =Ty *isredi
! layer dependent coefficients for for solving dT(nz)/dt+d/dz*K_33*d/dz*T(nz) = ...

Expand Down
Loading