Repository navigation
fix(core): check job.health field in waitForJobToComplete for pod-status health sources - #144
Merged
Merged
Conversation
…tus health sources (#143) Services like eyevinn-ffmpeg-s3 signal completion via job.health === 'SuccessCriteriaMet' rather than job.status. The previous implementation only checked job.status, causing waitForJobToComplete to spin all 1000 iterations (~16 min) even after the job had finished. Now both job.status and job.health are checked against the terminal success and failure sets. Closes #143 Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
waitForJobToCompletenow checks bothjob.statusandjob.healthagainst terminal success/failure setseyevinn-ffmpeg-s3that use a pod-status health source signal completion viajob.health === 'SuccessCriteriaMet'—job.statusis never set to a terminal value for these servicesjob.health(e.g.'Failed','FailureTarget') is also detected and thrown correctlyRoot cause
The previous fix (#129) added
SuccessCriteriaMetas a recognisedjob.statusvalue. However foreyevinn-ffmpeg-s3the orchestrator never setsjob.statustoSuccessCriteriaMet— it setsjob.healthinstead. The two fields are populated by different health sources and are independent.Test plan
job.health === 'SuccessCriteriaMet'resolves,job.health === 'Complete'resolves,job.health === 'Failed'throws,job.health === 'FailureTarget'throwsCloses #143
Lessons
job.statusandjob.healthare populated by different orchestrator health sources and are independent — a service can have a terminalhealthvalue whilestatusstays non-terminal. Any completion predicate must check both fields.🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com