Repository navigation
ci: wait for sync-fork completion before finishing the workflow - #445
Merged
Merged
Conversation
@osaas/cli 4.33.0 adds -w/--wait to `osc admin sync-fork` (client-ts#151): it polls the sync-fork job to completion, then polls the auto-triggered remake order to completion, instead of returning right after the initial status check. Use it here so the workflow run actually reflects whether the fork sync + rebuild succeeded rather than exiting green immediately after kickoff. Bumped the job timeout from 5 to 15 minutes to give the full wait loop room to finish. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the new
-w/--waitflag to theosc admin sync-forkcall insync-fork.yml, per EyevinnOSC/client-ts#151 (merged, shipped in@osaas/cli4.33.0).Why
Previously the workflow fired the sync-fork request and exited immediately after the initial status check — a green run didn't mean the fork sync + rebuild actually succeeded.
--waitpolls the sync-fork job to completion, then polls the auto-triggered remake order to completion, so the workflow result reflects the real outcome.Other changes
timeout-minutesfrom 5 → 15 to give the wait loop (up to ~2 min for the remake order to appear, plus the order's own completion time) enough room, since the job no longer returns right after kickoff.Verification
@osaas/cliis installed unpinned (npm install -g @osaas/cli), so the workflow picks up 4.33.0+ automatically — confirmed on the npm registry.release: published,workflow_dispatchwith environment choice) or secrets wiring.🤖 Generated with Claude Code