Repository navigation
Review and merge #621: keep guest WHEP session binding on CouchDB revision conflict #623
Description
Part of #622 (broken down by daily-backlog-pr Phase 1 triage). Prerequisite for #542.
#621 extracts bindWhepSession. On a CouchDB 409 it re-reads the guest session doc, requires state !== 'left', merges only its own key and retries a bounded number of times. It also fixes a bug already on main: the return-picture binding is lost when the guest page opens the return picture and talkback at the same time.
Work
- Review fix(returns): keep the return-picture session binding on a revision conflict #621 with the normal gates (CI green, reviewer App approval) and merge it.
- Then ask @markusnygard to rebase Add opt-in commentator preview: undelayed per-source WHEP output for remote commentators #542 so it carries only the commentator preview change.
Single-service (open-live). Tracking PR: #621.
Metadata
Metadata
Assignees
Labels
No labels
Activity
birme commentedon Nov 4, 2026
daily-backlog-pr Phase 2: this item's work is the existing open PR #621, which has no review yet. Moving it to In review so Phase 3 reviews #621.
eyevinn-developer commentedon Nov 5, 2026
daily-backlog-pr Phase 3: done.
e0f6f5a. Typecheck, build and the full vitest suite pass (2013 tests), and CIbuild-and-testis green. It is merged tomainas 353e25d.mainso it carries only the commentator-preview change.Next step: #624.