[srperens]

Needs the backend, Eyevinn/open-live#629, and Strom 0.8.2 (Eyevinn/strom#1260, #1262, merged). Merge together with #629.

What

SRT directions from Strom's capabilities (Eyevinn/open-live#628)

The studio reads server-info.srt (state, modes, relays, inboundReachable, ports). It no longer reads the unreleased srtRelay field, which the backend has removed.

• Listener is greyed out when Strom has answered (state: ok) that modes.listener is false. The dialog says why: "This Strom cannot be reached from outside; use caller or Via relay." (without relays: "…use caller."). A new dialog starts on Caller in that case.
• Rendezvous is not a button. A new or changed caller address with mode=rendezvous is refused in the form when modes.rendezvous is false and state is ok.
• While state is unknown, unreachable or unsupported, or the backend sends no srt, every direction is offered. unreachable adds a small muted note.
• Existing sources and outputs keep working. A stored listener stays selectable in Edit. connect.warning (srt-listener-unsupported, srt-rendezvous-unsupported) shows as an amber line on the row and in the Edit dialog.

"Via relay (one public port)", now with named relays

• Offered only when srt.relays is non-empty.
• A relay picker shows when there is more than one relay, or when the only relay is not named default. Each option shows its name and public host:port. default comes first and is preselected.
• Create: srt+relay://auto on the default relay (written without @), or srt+relay://auto@<name> on another relay. The passphrase is added when given.
• Edit:
  • A new passphrase on the same relay sends auto without @, so the backend keeps the stored id and relay.
  • Switching relay sends auto@<name>, or auto@default to go back to the default relay. The id stays the same.
  • Switching relay keeps the stored passphrase: a blank field sends auto@<name> and the backend carries the passphrase over. The switch note says "the stream ID and the passphrase stay the same."
  • "Remove passphrase" sends auto[@<name>]?passphrase= (empty value), on the same relay or a new one.
  • If Strom no longer reports the stored relay, the picker keeps it, marked "not reported by Strom".
• The dial-in address is still the backend's connect.uri for the stored relay. After a relay switch is picked, the dialog shows the new relay's public address as the one used after save.

Errors

• 422 srt-relay-not-configured / srt-relay-unknown on save: "Strom has no SRT relay of that name. Configured relays: default, eu-north. Pick one of them." (taken from the body's relays).
• connect.reason srt-relay-unknown on a row: via relay eu-north · stream ID … · Strom has no SRT relay named "eu-north" (configured: default); edit it and pick another relay.
• An SRT query key without = (for example ?latency, which crashes GStreamer) is refused in the source and output forms, naming the key. The backend's 400 for it is shown in the same words. The listener and relay builders only write key=value. Passphrase handling is unchanged (10–80 bytes, percent-encoded).
• New Source now shows a failed save inside the dialog and keeps it open, as New Output and Edit Source already did. Before, the only sign was a toast.

Earlier in this PR

• The dial-in address comes from the backend (connect.uri) for listener and relay addresses. A listener on a private or loopback Strom without SRT_PUBLIC_HOST falls back to the Strom host, marked "local network only". The production "SRT OUT" copy buttons use the same helper.
• The text says why a dial-in address is missing: no relay, Strom not answering, or public SRT host not set.
• Passphrases are counted in UTF-8 bytes (10–80), and ! * ' ( ) ~ are percent-encoded. Switching a relay with a passphrase to Listener no longer claims to keep the passphrase. connect is typed as the object the backend returns.

Verified

• eslint (0 warnings), tsc --noEmit and vitest (53 files, 605 tests) after the passphrase-keep change; build passed earlier the same day.
• Unit tests in src/lib/srt.test.ts cover srtOffer, offeredDirection, relayAddressPatch (auto, auto@<name>, auto@default), chosenRelay, bareQueryKey, rendezvousError, srtConnectWarningText and srtSaveErrorMessage.
• Component tests in SourcesPanel.srtCapabilities.test.tsx and OutputsPanel.srtCapabilities.test.tsx cover when the picker shows, Listener disabled per state, warnings and error messages.
• Checked by hand in a browser against the local stack (backend #629, merged Strom).

Depends on

• Backend: feat(srt): SRT relay addresses with a sticky id (srt+relay://) open-live#629 (server-info.srt, named relays, connect.warning / connect.relay, the relay 422s, the 400 for a key without a value).
• Strom 0.8.2: feat(api): GET /api/capabilities and inbound reachability strom#1260 (GET /api/capabilities) and #1262 (named relays). The studio no longer uses GET /api/srt-relay from feat(srt): dial out through an SRT relay with srt+relay:// (one public UDP port) strom#1258.
• Studio: allow removing an existing SRT passphrase #257 (removing an existing passphrase) is separate.

🤖 Generated with Claude Code

[eyevinn-developer]

This PR looks like part of a multi-PR dependency stack together with, in dependency order: Eyevinn/strom#1258 (Strom resolves srt+relay://), Eyevinn/open-live#629 (backend), #259 (studio). Each PR body says it must not merge until the others are ready together, and the open-live and studio PRs are drafts. Holding off on automated review/merge here — this needs a human (or the relevant dev agent) to assess the whole stack together, not a per-PR pass. Nothing further is needed from the author; this comment exists so the dependency is recorded on the PR rather than in a run log.

Related: Eyevinn/open-live#628 (spec merged in #630) builds on this stack's relay-status cache, and its implementation waits for #629 to merge.

[eyevinn-pr-reviewer]

PR Review: feat(studio): SRT "Via relay" and dial-in addresses from the backend

Verdict: REQUEST CHANGES

Reviewed at head c3a1cbd9. This is the studio half of open-live#628. It has to merge together with open-live#629 (head f4105d75).

Prior findings

Sources: every review and comment on this PR (no reviews, no inline comments, one issue comment) and on open-live#628 (six triage comments), plus the acceptance criteria and test cases in #628.

#	Finding (source)	Status	Evidence
1	Hold off: the PR is part of a stack with strom#1258 and open-live#629, and they are drafts (stack-flag comment on this PR, 2026-11-11)	FIXED	Both PRs left draft at 15:24Z. Strom shipped this as strom#1260 and #1262 (both merged, v0.8.2 released), and #1258 is closed as superseded. The PR body now names the real dependencies.
2	The PR bodies still say the Strom branches "have no PR numbers yet" (#628 triage, 2026-11-13 ~15:18Z)	FIXED	The PR body now cites strom#1260 and #1262.
3	Before merge, team-lead must sign off on the amendment in open-live#629 (f554d143) that warns instead of refusing with 422 (#628 triages, 12:20Z / 15:18Z / 16:17Z)	OPEN	open-live#629 has no reviews and no team-lead sign-off. This PR builds on the amended contract: it has no srt-direction-unsupported handling, and a stored listener can be re-picked in Edit. So it cannot merge before the amendment is signed off.
4	The spec header needs updating (Status Implemented, Strom 0.8.2, drop the stale strom#1258 references) and ADR-014 must be set to Accepted (#628 triages, 08:18Z / 16:17Z)	OPEN (on #629)	At f4105d75 the spec still says Status: Draft and still cites strom#1258 as open. This is fixed on #629, not here, but the pair merges together.
5	#628 proposal 2 and test case "Strom with STROM_PORTS: the listener port choice comes from those ports". Spec §6 "Port picker": when srtPorts is null and srt.ports is non-null, offer ports from those ranges and warn inline when a port is outside them	OPEN	SrtCapabilities.ports is typed (src/lib/api.ts:832) but nothing reads it. useListenerPortMode (src/components/ui/SrtDirectionFields.tsx:20) still looks only at the legacy srtPorts/srtPortState. #628's triage says the issue is closed once #629 and #259 merge, with no separate implementation, so without this the criterion is silently dropped. No human has waived it.
6	#628 proposal 2: offer Listener only when Strom supports it, Via relay only when there is a relay, Caller always	FIXED	srtOffer / offeredDirection (src/lib/srt.ts:360, :386). Listener is disabled on create (SourcesPanel.tsx:1090, OutputsPanel.tsx:612), and Via relay shows only when srt.relays is non-empty (commit 24af66a5).
7	#628 proposal 4: existing records stay listed and keep working; Edit does not offer an unsupported direction as a new choice	FIXED	The lists are not filtered. A stored listener stays selectable, and every other record gets Listener disabled (SourcesPanel.tsx:781, OutputsPanel.tsx:696). connect.warning is shown on rows and in Edit (SourcesPanel.tsx:694, :786; OutputsPanel.tsx:497, :700). Commit 24af66a5.
8	#628 proposal 5 / test case: with an older Strom or default settings, behaviour is unchanged	FIXED	srtOffer offers every mode unless state === 'ok' (src/lib/srt.ts:360). Covered in srt.test.ts and *.srtCapabilities.test.tsx.
9	#628 test case: STROM_INBOUND_REACHABLE=false with a relay, so the studio offers Caller and Via relay	FIXED	Covered in SourcesPanel.srtCapabilities.test.tsx and OutputsPanel.srtCapabilities.test.tsx (commit 24af66a5).

Critical issues (must fix before merge)

• Missing acceptance criterion (row 5): Listener ports from srt.ports. Implement spec §6 "Port picker". If srtPorts (the legacy reservation) is non-null, keep today's behaviour. Otherwise, if srt.ports is non-null, offer ports from those {first,last} spans; the spec suggests defaulting to the lowest port not used by a listed source or output. Allow free entry, with an inline warning when the port is outside the spans. Add a component test for the #628 STROM_PORTS test case. If the team decides to descope this, a human with authority must say so on #628 and a follow-up issue must be filed. Until then it stays open.
• SPEC DIVERGENCE: server-info is never refetched. Spec §6 says the studio reads server-info.srt "fetched as today, plus a refetch when a create/edit dialog opens". useServerInfo caches a single promise for the life of the page (src/hooks/useServerInfo.ts:13). The backend answers state: unknown, relays: [] until its first capabilities fetch succeeds, and unreachable while Strom is down. Failure case: a studio tab opened during a backend restart never offers "Via relay", and never greys out Listener, until the operator reloads the page. Before this PR that cache was fine, because server-info only changed on restart. Now it carries live Strom state. Refetch (or invalidate the cache) when the New/Edit source and output dialogs open.
• Merge gate (row 3): team-lead sign-off on the open-live#629 warn-instead-of-422 amendment. The studio code matches the amended contract, so nothing needs to change here. It must not merge before that sign-off.

Warnings (should fix)

• srtSaveErrorMessage for 422 srt-relay-not-configured says "Choose listener or caller." (src/lib/srt.ts:428). It says this even when Strom has just reported that Listener cannot work. Use unreachableFromOutsideText-style wording based on the current offer.listener.

Nits

• On a stored listener record whose Strom reports listener: false, spec §6 asks for the direction to be labelled "not supported by this Strom" and says switching back should not be offered. This PR shows the connect.warning line instead and lets you switch back. That is reasonable under the #629 amendment ("reported, never refused"), but write it into the spec amendment so the two agree.

What was verified

• Read the full diff (13 files). Checked against open-live#629 at f4105d75:
  • The server-info.srt shape {state, modes, relays, inboundReachable, ports} matches src/routes/status.ts and services/strom-capabilities.ts.
  • SrtConnect.relay/streamid/reason/warning and the reason and warning values match lib/srt-connect.ts.
  • The relay name and id regexes match SRT_RELAY_NAME_RE / SRT_RELAY_ID_RE in lib/srt-relay.ts.
  • The 400 text matched by srtSaveErrorMessage (SRT parameter '<key>' has no value) is the text in lib/srt-uri-check.ts:104.
  • The 422 body {error, statusCode, code, relays} matches #629's description.
  • ApiError.body exists in src/lib/api.ts.
  • No fabricated fields found.
• Security: no secrets, tokens or credentials. The passphrase is never put into the dial-in address, and it is percent-encoded into the backend's query charset. No new endpoints, no innerHTML, no validation weakened: the passphrase checks and the new query-key and rendezvous checks only add restrictions. No dependency changes (package.json and the lockfile are untouched).
• Local run at c3a1cbd9: pnpm install --frozen-lockfile, lint (0 warnings), typecheck, test (53 files, 605 tests passed) and build all pass.
• CI: build-and-lint passed.
• Every commit has a Co-Authored-By trailer. The PR is on branch feat/srt-relay, not main.

[eyevinn-developer]

daily-backlog-pr Phase 3: first re-review after the REQUEST_CHANGES verdict, on the new head with the fix commits pushed by the Phase 2 re-entry.

[eyevinn-pr-reviewer]

PR Review: feat(studio): SRT "Via relay" and dial-in addresses from the backend (re-review at 4b2431af)

Verdict: APPROVE

First re-review after the REQUEST CHANGES at c3a1cbd9. Commit 4b2431af fixes both Critical issues and the Warning; the Edit-dialog nit and the merge-gate sign-off were settled on open-live#629. Checked against open-live#629 at acef6547 (src/ and docs/openapi.yaml): the studio reads no field the backend does not send.

Prior findings

No human comment withdraws or waives any finding.

#	Finding (source)	Status	Evidence
1	Stack hold with strom#1258 / open-live#629 drafts	FIXED	Both out of draft; strom#1260/#1262 merged (v0.8.2); #1258 closed.
2	PR body lacked Strom PR numbers	FIXED	Body cites strom#1260, #1262.
3	Merge gate: team-lead sign-off on the #629 amendment	FIXED	6859992148.
4	Spec header / ADR-014 Accepted (on #629)	FIXED (on #629)	acef6547.
5	Critical: listener ports from srt.ports	FIXED	4b2431af: spans mode src/components/ui/SrtDirectionFields.tsx:46, freePortsInSpans src/lib/srt.ts:462, portOutsideSpansWarning SrtDirectionFields.tsx:83,197; tests in SourcesPanel/OutputsPanel.srtCapabilities.test.tsx.
6	Listener only when supported, relay only with relays, Caller always	FIXED	Unchanged since 24af66a5.
7	Existing records keep working; Edit doesn't offer unsupported direction	FIXED	SourcesPanel.tsx:786 / OutputsPanel.tsx.
8	Older Strom: behaviour unchanged	FIXED	spans needs non-empty srt.ports.
9	STROM_INBOUND_REACHABLE=false + relay	FIXED	Unchanged since 24af66a5.
10	Critical: server-info never refetched	FIXED	4b2431af: src/hooks/useServerInfo.ts:44,50; refetch on dialog open SourcesPanel.tsx:188, OutputsPanel.tsx:210; serverInfoRefetch.test.tsx.
11	Warning: srt-relay-not-configured text ignores unsupported Listener	FIXED	4b2431af: src/lib/srt.ts:432.
12	Nit: stored-listener Edit behaviour into spec	FIXED	Spec on acef6547 :64, :425, :606.
13	connect.warning: srt-port-outside-strom-ports	FIXED	src/lib/api.ts:303, src/lib/srt.ts:411.

Critical issues

None.

Warnings

None.

Nits (optional)

• The suggested free port only skips ports listed in this studio; on a shared Strom without a reservation it could suggest a port another instance uses. The backend's legacy reservation covers that case.

What was verified

• Contract against open-live#629 acef6547: server-info.srt = { state, modes, relays, inboundReachable, ports } (src/routes/status.ts:37-43), {first,last} inclusive spans, connect.warning enum (docs/openapi.yaml:602), relay 422 codes (docs/openapi.yaml:1285-1294).
• Local at 4b2431af: lint, typecheck, test (54 files, 623 tests) and build pass. CI build-and-lint green.
• Merge order: open-live#629 first, then the server-info.srt check on staging, then this PR.