Skip to content
This repository was archived by the owner on Dec 6, 2018. It is now read-only.

First config add for webpack release and dev server - #337

Open
jeremenichelli wants to merge 1 commit into
masterfrom
feature/webpack
Open

jeremenichelli wants to merge 1 commit into
masterfrom
feature/webpack

Conversation

@jeremenichelli

Copy link
Copy Markdown

🔴 NOT READY FOR MERGING YET 🔴

ISSUE 👉 #331

This pull request contains all the configuration to run our projects under webpack, so far it's making half of our scripts obsolete and bundles are smaller by default thanks to scope hoisting, tree shaking and better modules overhead.

TODO:

  • Test with BigWheel project
  • Add support for LESS styles
  • Discuss ASSETS_PATH variable use

@neo

neo commented Jul 21, 2017

Copy link
Copy Markdown
Member

@jeremenichelli 👍 respect
I will def take a look on Monday.
but a little thought: I don't think we need to support bigwheel and less, at least for now. I personally don't think we are using them for most of the projects.

@neo

neo commented Jul 21, 2017

Copy link
Copy Markdown
Member

The other thing is the team might want to use it as an option for now? Instead of replacing budo? I don't know...

@jeremenichelli

Copy link
Copy Markdown
Author

@neo I think that adding LESS support is super easy so that wouldn't be a problem. DOn't know the way we want to go on BIg Wheel but I wouldn't kill it under this PR.

Mainting budo and webpack on the same template is possible I think though a bit more complicated ot me since I don't have much experience doing heavy modifications to the generator but if that's the way the team wanna go I will change the PR for sure, just let me know :)

@neo

neo commented Jul 22, 2017

Copy link
Copy Markdown
Member

@jeremenichelli I'm not saying to kill them, I am just saying we don't have to support them at least for now.

And for sure, I know it's not gonna be easy. It will be a long way to go. But this is def a great first step! 👍

@neo

neo commented Aug 3, 2017

Copy link
Copy Markdown
Member

Just one thought: should we just use https://github.com/facebookincubator/create-react-app?

@jeremenichelli

Copy link
Copy Markdown
Author

@neo it could be useful for some projects, the problem is that is hard to scalate the config I heard. So if you want to create specific vendor files or add some complex loader config you might have problems, and that happens really often in Jam3 projects.

@neo

neo commented Aug 4, 2017

Copy link
Copy Markdown
Member

@jeremenichelli You are right, that was just a thought anyway. We always use custom builds, but what we could do is refer to how they do it I guess and get something useful out of it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants