Recognize duplicate-record error as ALREADY_CREATED - #98972
Draft
rinej wants to merge 1 commit into
Draft
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Issue: Expenses created offline can silently disappear from a submitted report. The submitter sees them locally, but they never make it to the approver, and no error is shown.
Root cause: When a create request succeeds on the server but the response is lost in transit (flaky connection), the client re-sends it. The server correctly rejects the retry as a duplicate - Auth throws
400 Unique Constraints Violation- but the API layer re-wraps that 400 asjsonCode: 666while keeping the original message.Solution: Add
CONST.ERROR_TITLE.DUPLICATE_RECORD('400 Unique Constraints Violation') toALREADY_CREATED_MESSAGESinsrc/libs/HttpUtils.ts. The re-wrapped duplicate then follows the same path as the existing'Transaction already created.'/'Already paid'variants: the queue appliessuccessData, removes the request, and moves on - the expense stays, matching server stateFixed Issues
$ #98314
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari