Skip to content

[No QA] Add NumberForm root with SymbolInput and TextInput primitives - #98967

Draft
jmgraa wants to merge 20 commits into
Expensify:mainfrom
software-mansion-labs:jmgraa/NumberWithSymbolFrom-migration_1
Draft

[No QA] Add NumberForm root with SymbolInput and TextInput primitives#98967
jmgraa wants to merge 20 commits into
Expensify:mainfrom
software-mansion-labs:jmgraa/NumberWithSymbolFrom-migration_1

Conversation

@jmgraa

@jmgraa jmgraa commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

This PR introduces the new composable NumberForm foundation and extracts numeric input behavior from the monolithic NumberWithSymbolForm implementation.

NumberForm now provides shared controlled state, external value synchronization, error handling, callbacks, and the imperative ref API through context. It exposes two specialized primitives:

  • NumberForm.SymbolInput for inputs using TextInputWithSymbol
  • NumberForm.TextInput for standard text inputs

Both primitives use the shared useNumberFormInputLogic hook, which centralizes:

  • Locale digit and separator normalization
  • Leading-zero handling
  • Negative-value handling
  • Decimal and maximum-length validation
  • Caret and selection updates
  • Forward-delete keyboard handling
  • External value changes and focus restoration
  • Ref forwarding and the clearSelection, updateNumber, and getNumber imperative methods

This differs from NumberWithSymbolForm in that the legacy component combines the form state, numeric input logic, rendering branches, number pad, symbol/currency controls, flip controls, and layout composition in a single component. It also maintains separate setter paths for the symbol input and the standard text-input mode. The new implementation separates the shared numeric behavior from the visual input primitives, allowing future features such as currency buttons and number-pad composition to be added independently.

Normalization is now performed by NumberForm itself. TextInputWithSymbol supports an opt-out flag so that the new component does not normalize the value twice, while the legacy NumberWithSymbolForm behavior remains unchanged.

The new component is introduced as the foundation for subsequent migration work. Dedicated tests cover root state management, both input variants, formatting, validation, ref behavior, external updates, and native selection-event guards.

Fixed Issues

$ #98169
PROPOSAL: #97970

Tests

  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

N/A

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

@melvin-bot

melvin-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/components/NumberForm/NumberForm.tsx 100.00% <100.00%> (ø)
...components/NumberForm/context/NumberFormContext.ts 100.00% <100.00%> (ø)
src/components/NumberForm/index.tsx 100.00% <100.00%> (ø)
...ts/NumberForm/primitives/NumberFormSymbolInput.tsx 100.00% <100.00%> (ø)
...ents/NumberForm/primitives/NumberFormTextInput.tsx 100.00% <100.00%> (ø)
...ts/TextInputWithSymbol/BaseTextInputWithSymbol.tsx 100.00% <100.00%> (ø)
...onents/NumberForm/hooks/useNumberFormInputLogic.ts 87.50% <87.50%> (ø)
... and 16 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant