[No QA] Fix latent lint errors that only surface on an uncached lint

[roryabraham]

Explanation of Change

Five ESLint errors that already exist on main but that most PRs never see.

The ESLint cache key hashes config/eslint/**, so a PR that touches that directory gets a cold, whole-repo re-lint instead of only its changed files — and then fails on errors it did not introduce. #97199 hit exactly this while adding an evals project to the ESLint config. Splitting the fix out so it can land on its own.

They aren't caught by eslint-seatbelt because the baseline lists these files under @typescript-eslint/no-unsafe-type-assertion, while the errors are no-unnecessary-type-assertion and no-deprecated — different rules, so nothing grandfathers them.

Four redundant type assertions. f2d5991a487 gave getCardFeedWithDomainID overloads that already return CompanyCardFeedWithDomainID, so as CompanyCardFeedWithDomainID became a no-op at three call sites, plus a fourth that carried the same value through to an Onyx write. TypeScript reports these as assertions that don't change the type, so removing them changes nothing at runtime or in the type system. One type import became unused and is dropped with them.

One deprecated navigation call. CommonActions.navigate's object form is deprecated in favour of navigate(name, params, options). The call in linkTo passes only name and params — no key, no merge — so the positional form dispatches an identical action. It is the only CommonActions.navigate( call in src/.

Fixed Issues

$
PROPOSAL:

Tests

1. npm run lint completes without these five errors. To see them on main, a cached run won't do it — bun scripts/lint.ts --no-cache src/libs/Navigation/helpers/linkTo/index.ts src/libs/actions/CompanyCards.ts src/pages/workspace/companyCards/WorkspaceCompanyCardFeedSelectorPage.tsx src/pages/workspace/companyCards/addNew/CardInstructionsStep.tsx reports all five before this change and none after.
2. npm run typecheck passes. This is the meaningful check on the cast removals: if any assertion had been doing real work, dropping it would fail here.
3. npx jest tests/navigation tests/unit/Navigation passes (1007 tests, 65 suites), covering the linkTo change.

• Verify that no errors appear in the JS console

Offline tests

None — no runtime behaviour changes.

QA Steps

None. No user-facing change: four removed no-op type assertions and one deprecated API call swapped for its non-deprecated equivalent.

• Verify that no errors appear in the JS console

Screenshots/Videos

n/a

[melvin-bot]

@stitesExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/Navigation/helpers/linkTo/index.ts	95.04% <100.00%> (+1.54%)	⬆️
...space/companyCards/addNew/CardInstructionsStep.tsx	0.00% <ø> (ø)
src/libs/actions/CompanyCards.ts	33.73% <0.00%> (ø)
...panyCards/WorkspaceCompanyCardFeedSelectorPage.tsx	0.00% <0.00%> (ø)
... and 11 files with indirect coverage changes

[github-actions]

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #98943.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-3b45d93-3d1e22c-3dd7e1f437199e4d0adc9153d4b89bb674ffdcd4/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-3b45d93-3d1e22c-a2da96aaf16496dfdbf7e1e5130e5ddc850871ae/index.html

Web 🕸️
https://98943.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀