[No QA] Remove redundant unscoped sign-in.ad and dead sign-in-drive.sh (agent-device)

[kacper-mikolajczak]

Explanation of Change

Removes two redundant/dead agent-device sign-in artifacts. No live flow changes behavior.

1. The unscoped macros/sign-in.ad. Sign-in is fully platform-scoped: macros/web/sign-in.ad and macros/android/sign-in.ad both exist and win via resolve_sign_in_ad (which picks macros/<platform>/sign-in.ad and only falls back to the unscoped file when no scoped copy exists). Melvin CI drives only web and android, so it never used the unscoped copy - it was just a third, drift-prone duplicate of the login selectors (it still carried the stale role="textfield"). Removing it. iOS is a supported agent-device platform but has no macros/ios/ copy today; a future iOS driver must add its own macros/ios/sign-in.ad rather than lean on an unscoped fallback (README updated to say so).

2. The lib/sign-in-drive.sh drive library (and its lib/ entry in flows/README.md). Nothing sources it anymore: Melvin's CI sign-in was refactored to replay the .ad macro directly, and the old two-layer drive split (Melvin's melvin-app-drive.sh staging mirror and its resolve_app_drive resolver) is gone. No file in this repo sources it or uses its drive_sign_in/SEL_* exports - only a README example referenced it.

The platform-scoped macros (macros/web/sign-in.ad, macros/android/sign-in.ad) are untouched.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/672996 (part of #87030)
PROPOSAL:

Tests

1. Confirm nothing references the removed library: grep -rn "sign-in-drive\|drive_sign_in" .claude returns no matches.
2. Confirm sign-in is now web+android only: ls .claude/skills/agent-device/flows/macros/**/sign-in.ad lists exactly the web and android copies, and there is no unscoped macros/sign-in.ad.
3. Melvin App prestart sign-in still works on both platforms it drives (each uses its own scoped macro, unaffected by these removals):
   • web: https://github.com/Expensify/melvin/actions/runs/32194080525 (STATUS=ok, 1 attempt)
   • android: https://github.com/Expensify/melvin/actions/runs/32196808283 (STATUS=ok, 1 attempt)

• Verify that no errors appear in the JS console

Offline tests

N/A - this change modifies CI test-tooling selector definitions only (.claude/skills/agent-device/...); it has no App runtime effect and no offline behavior.

QA Steps

Same as the Tests section. [No QA] - this is an internal CI test-tooling selector change with no user-facing behavior, so there is nothing for QA to validate on staging.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[melvin-bot]

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[kacper-mikolajczak]

CC @Julesssss @rlinoz

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 341400bc54

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[MelvinBot]

🤖 Opened the app on web — it loaded successfully. After passing the post-signin Welcome/Join interstitial, it reached the Home screen with the full nav rail (Home/Inbox/Spend/Workspaces/Account) and Home content visible. No JS console errors.

Evidence

Home screen after sign-in, showing left nav (Home/Inbox/Spend/Workspaces/Account) and Home tab content

[kacper-mikolajczak]

Successful on both web and android ✅:

• web https://github.com/Expensify/melvin/actions/runs/32194080525
• android https://github.com/Expensify/melvin/actions/runs/32196808283

CC @Julesssss @rlinoz

[MelvinBot]

🤖 Opened the app on Android — it loaded successfully. After completing the remaining post-sign-in setup (Join → notification permission → skip work email → onboarding purpose → name), it reached the Home screen with the bottom nav (Home/Inbox/Spend/Workspaces/Account) and the Home tab active. No console errors.

Evidence

Expensify Android Home screen showing Time sensitive validate-account card, Recently added (no recent expenses), Discover section, and bottom nav with Home tab active

[Julesssss]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.