Update the expense merchant label - #98915
Conversation
Co-authored-by: Jules <Julesssss@users.noreply.github.com>
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Jules <Julesssss@users.noreply.github.com>
|
Fixed the failing checks — the two Jest failures ( That string isn't only the field label:
Only the two test files changed; no production code touched. CI will re-run the suites on the new commit ( Why the tests, not the sourceThe failures are the test fixtures hardcoding the old copy, and this PR's explicit intent is to change Note: |
✅ Web test passedRan the PR's testing steps on dev NewDot (web). The Merchant field label now reads Merchant name everywhere it appears, and the expense saved with all the requested values.
EvidenceMerchant field edit screen — label & placeholder now "Merchant name"Confirm Details — Amount 12.34, Merchant name "Disposable Test Cafe", Description "Melvin self-test"Saved expense detail view — "Merchant name" label and valueNotes
|
…ame' Co-authored-by: Jules <Julesssss@users.noreply.github.com>
|
Pushed a follow-up fix ( That's the complete set now: all Only |
|
The failing test checks are now green. ✅ Latest commit (
The only remaining red check is No further code changes are needed from me. |
|
TEST |



Explanation of Change
Renames the English expense Merchant field label to Merchant name. This updates the
common.merchantstring insrc/languages/en.ts, which is the label rendered for the merchant field on the expense/money-request view and confirmation form. No other files are touched.Fixed Issues
$ N/A — disposable test PR.
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari