[No QA] fix(ci): Raise generateTranslations bun test timeout to fix oxfmt SIGTERM flake - #98905
Merged
Merged
Conversation
…RM flake Co-authored-by: Rory Abraham <roryabraham@users.noreply.github.com>
roryabraham
marked this pull request as ready for review
August 18, 2026 18:55
melvin-bot
Bot
requested review from
roryabraham and
truph01
and removed request for
a team
August 18, 2026 18:55
|
@truph01 @roryabraham One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
Valforte
approved these changes
Aug 18, 2026
61 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/Valforte in version: 9.4.56-0 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
The
generateTranslationsbun tests (tests/tooling/generateTranslations.test.ts) intermittently flaked thebunTests / Bun testsjob onmain(e.g. #98898, #98889), producing a misleading error:Root cause: each test shells out to the real
oxfmtbinary (twice per locale) plus file I/O. Under a loaded CI runner, individual tests spike well past bun's default 5000ms per-test timeout. When bun hits the timeout it tears the test down and sendsSIGTERMto the in-flightoxfmtsubprocess — surfacing as theCommand failed ... SIGTERMabove rather than a normal timeout message.oxfmtdid not crash; it was killed by the test runner.This is purely an environmental/timing flake — a healthy run finishes these tests in ~275ms at the peak, but the failing runs showed spikes of 4451ms (completed), 6362ms, 9848ms, and 11503ms under contention. This PR raises the per-test timeout for this file to 30000ms via
setDefaultTimeout(30000)— the same mechanism and value already used by the sibling subprocess-spawning tooling testCIGitLogic.test.ts. 30s leaves ample headroom (~2.6× the worst observed, ~100× a healthy peak) while still bounding a genuinely hung test.Fixed Issues
$ #98898
PROPOSAL:
Tests
n/a - automated tests only
Offline tests
n/a
QA Steps
None.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari