Skip to content

fix: Register report pagination after app reload - #98876

Draft
chrispader wants to merge 1 commit into
Expensify:mainfrom
chrispader:codex/fix-pagination-registration
Draft

fix: Register report pagination after app reload#98876
chrispader wants to merge 1 commit into
Expensify:mainfrom
chrispader:codex/fix-pagination-registration

Conversation

@chrispader

@chrispader chrispader commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Report-action pagination registration was tied to the splash screen becoming hidden. Hybrid app reloads do not always replay that splash-state transition, so after clearing Onyx and reloading, the pagination middleware could start with no report-action configuration. OpenReport responses would then skip creating the report-action page metadata, preventing GetOlderActions from being requested at the top of a report.

This moves the existing lazy pagination-registration import into universal app setup, immediately after Onyx.init(). App setup runs for every JavaScript runtime on native and web, while retaining the existing lazy chunk and avoiding extra startup-bundle work.

Fixed Issues

$ #98902

Tests

  1. Sign in with an account that has a chat containing more than one page of report actions.
  2. Open the chat and scroll to the oldest loaded action.
  3. Verify older actions load.
  4. Go to Settings > Troubleshoot and clear the Onyx cache.
  5. Open the chat again without scrolling to the oldest action.
  6. Reload the app from Metro or the React Native developer menu.
  7. Open the chat and scroll to the oldest loaded action.
  8. Verify GetOlderActions is requested and older actions load.
  9. Repeat steps 4–8 after another cache clear and reload.

Automated validation completed:

  • tests/unit/AppSetupTest.ts and tests/ui/PaginationTest.tsx
  • Full TypeScript check
  • Production web build
  • ESLint and Oxfmt on changed files

Native manual validation remains pending. The cached Hybrid iOS build stayed on its native splash, and the cached Hybrid Android build attempted to load an asset bundle instead of the isolated Metro bundle even with the reverse mapping configured. The registration call was temporarily removed during diagnosis and did not change the iOS startup hang, so this appears unrelated to the patch.

  • Verify that no errors appear in the JS console

Offline tests

  1. Load a chat with more report-action history while online.
  2. Disable the network connection and scroll to the oldest loaded action.
  3. Verify the app does not crash or repeatedly request older actions.
  4. Restore the network connection and retry.
  5. Verify older actions load.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Before fix:

After fix:

iOS: Native

Before fix:

PaginationReloadBugRepro.mov

After fix:

@chrispader

Copy link
Copy Markdown
Contributor Author

@MelvinBot create an issue in the format of a problem/solution for this PR, assign me to it and link it in this PR.

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Created a problem/solution issue for this PR and linked it here.

Issue: Report actions fail to paginate after clearing Onyx cache and reloading — assigned to chrispader.

  • Problem: Report-action pagination registration was tied to the splash screen hiding. Hybrid app reloads don't always replay that transition, so after a cache clear + reload the pagination middleware starts with no report-action config — OpenReport skips creating page metadata and GetOlderActions is never requested, so older actions never load.
  • Solution: Move the lazy registerPaginationConfig import into universal app setup (right after Onyx.init()), so it runs for every JS runtime on native and web regardless of splash-state transitions.

I also filled in the ### Fixed Issues section of this PR with the new issue link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants